You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Chandan Purushothama <Ch...@citrix.com> on 2014/12/18 03:29:53 UTC
Review Request 29187: CLOUDSTACK-8086: Simulator needs a Portable IP
Range to execute Portable IP Test Cases
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29187/
-----------------------------------------------------------
Review request for cloudstack and SrikanteswaraRao Talluri.
Bugs: CLOUDSTACK-8086
https://issues.apache.org/jira/browse/CLOUDSTACK-8086
Repository: cloudstack-git
Description
-------
Currently test cases are failing in Simulator, since the portable IP Range dictionary is empty in testdata.py. Fake IP Range information needs to be provided so that the test cases can be run without any issues.
Diffs
-----
tools/marvin/marvin/config/test_data.py 269f46e
Diff: https://reviews.apache.org/r/29187/diff/
Testing
-------
Testing not done
Thanks,
Chandan Purushothama
Re: Review Request 29187: CLOUDSTACK-8086: Simulator needs a Portable
IP Range to execute Portable IP Test Cases
Posted by Sebastien Goasguen <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29187/#review78985
-----------------------------------------------------------
Thank you for submitting your CloudStack contribution through review board. After discussion on the dev@cloudstack.apache.org the community decided to close down review board and start accepting contributiong through GitHub pull requests. We have been using GH PR for several months now and the process is better than review board.
We will keep Review Board open for another week to give you time to migrate your patch to a github PR if you wish. After that time, your patch will no longer be viewable (even though it will not be deleted).
Please consider submitting a pull request.
Great instructions are available at:
https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md
Thank you very much for your time and your contribution to Apache CloudStack, we hope that using this new process will encourage you to do more.
- Sebastien Goasguen
On Dec. 18, 2014, 2:29 a.m., Chandan Purushothama wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29187/
> -----------------------------------------------------------
>
> (Updated Dec. 18, 2014, 2:29 a.m.)
>
>
> Review request for cloudstack and SrikanteswaraRao Talluri.
>
>
> Bugs: CLOUDSTACK-8086
> https://issues.apache.org/jira/browse/CLOUDSTACK-8086
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Currently test cases are failing in Simulator, since the portable IP Range dictionary is empty in testdata.py. Fake IP Range information needs to be provided so that the test cases can be run without any issues.
>
>
> Diffs
> -----
>
> tools/marvin/marvin/config/test_data.py 269f46e
>
> Diff: https://reviews.apache.org/r/29187/diff/
>
>
> Testing
> -------
>
> Testing not done
>
>
> Thanks,
>
> Chandan Purushothama
>
>
Re: Review Request 29187: CLOUDSTACK-8086: Simulator needs a Portable
IP Range to execute Portable IP Test Cases
Posted by SrikanteswaraRao Talluri <sr...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29187/#review65605
-----------------------------------------------------------
Ship it!
696698090eb2ea548bfc74b802ba7dd01a584b91 master
f2c7ead8ee68de963a97eae9dc78bf524565691e 4.5
- SrikanteswaraRao Talluri
On Dec. 18, 2014, 2:29 a.m., Chandan Purushothama wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29187/
> -----------------------------------------------------------
>
> (Updated Dec. 18, 2014, 2:29 a.m.)
>
>
> Review request for cloudstack and SrikanteswaraRao Talluri.
>
>
> Bugs: CLOUDSTACK-8086
> https://issues.apache.org/jira/browse/CLOUDSTACK-8086
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Currently test cases are failing in Simulator, since the portable IP Range dictionary is empty in testdata.py. Fake IP Range information needs to be provided so that the test cases can be run without any issues.
>
>
> Diffs
> -----
>
> tools/marvin/marvin/config/test_data.py 269f46e
>
> Diff: https://reviews.apache.org/r/29187/diff/
>
>
> Testing
> -------
>
> Testing not done
>
>
> Thanks,
>
> Chandan Purushothama
>
>