You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Will Berkeley (Code Review)" <ge...@cloudera.org> on 2017/05/16 19:15:04 UTC

[kudu-CR] Fix ToolTest.TestFsCheck for Mac

Will Berkeley has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/6899

Change subject: Fix ToolTest.TestFsCheck for Mac
......................................................................

Fix ToolTest.TestFsCheck for Mac

Stats on total live blocks aren't gathered for the FBM, which caused
ToolTest.TestFsCheck to fail on OS X. This patch fixes the test
so it passes on OS X.

Change-Id: I1da28d1f1187e6fab793a751ea02953998929cb4
---
M src/kudu/tools/kudu-tool-test.cc
1 file changed, 5 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/99/6899/1
-- 
To view, visit http://gerrit.cloudera.org:8080/6899
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1da28d1f1187e6fab793a751ea02953998929cb4
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley <wd...@gmail.com>

[kudu-CR] Fix ToolTest.TestFsCheck for Mac

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.

Change subject: Fix ToolTest.TestFsCheck for Mac
......................................................................


Patch Set 1: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/6899
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1da28d1f1187e6fab793a751ea02953998929cb4
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No

[kudu-CR] Fix ToolTest.TestFsCheck for Mac

Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has submitted this change and it was merged.

Change subject: Fix ToolTest.TestFsCheck for Mac
......................................................................


Fix ToolTest.TestFsCheck for Mac

Stats on total live blocks aren't gathered for the FBM, which caused
ToolTest.TestFsCheck to fail on OS X. This patch fixes the test
so it passes on OS X.

Change-Id: I1da28d1f1187e6fab793a751ea02953998929cb4
Reviewed-on: http://gerrit.cloudera.org:8080/6899
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
M src/kudu/tools/kudu-tool-test.cc
1 file changed, 5 insertions(+), 1 deletion(-)

Approvals:
  Adar Dembo: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/6899
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1da28d1f1187e6fab793a751ea02953998929cb4
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>