You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by Cris Rockwell <cm...@umich.edu> on 2021/10/07 20:18:51 UTC
Maven Archetypes
Hi all
For SLING-10857 <https://issues.apache.org/jira/browse/SLING-10857> I took an inventory of the Sling Maven archetypes in an attempt to improve the docs. and grouped the GitHub links below with failing/passing tests. Are they all still supported? I recently tried starting sling-launchpad-standalone-archetype but it failed to complete.
Failing
https://github.com/apache/sling-launchpad-standalone-archetype <https://github.com/apache/sling-launchpad-standalone-archetype>
https://github.com/apache/sling-launchpad-webapp-archetype <https://github.com/apache/sling-launchpad-webapp-archetype>
https://github.com/apache/sling-servlet-archetype <https://github.com/apache/sling-servlet-archetype>
https://github.com/apache/sling-bundle-archetype <https://github.com/apache/sling-bundle-archetype>
https://github.com/apache/sling-jcrinstall-bundle-archetype <https://github.com/apache/sling-jcrinstall-bundle-archetype>
Passing
https://github.com/apache/sling-initial-content-archetype <https://github.com/apache/sling-initial-content-archetype>
https://github.com/apache/sling-content-package-archetype <https://github.com/apache/sling-content-package-archetype>
https://github.com/apache/sling-project-archetype <https://github.com/apache/sling-project-archetype>
Cris
Re: Maven Archetypes
Posted by Ruben Reusser <rr...@headwire.com>.
it would be great if it gets the same bells and whistles as the
archetype AEM has at the moment and maybe starts aligning with the split
code and content structure a bit more as well.
Ruben
On 10/8/2021 12:34 PM, Andreas Schaefer wrote:
> Hi
>
> I did not work on the Project Archetype for a while but I am going to have a look into it with respect to FMs.
> There were some suggestions on how to improve it a while back and I will try to find them again.
>
> Cheers - Andy
>
>> On Oct 8, 2021, at 8:01 AM, Robert Munteanu <ro...@apache.org> wrote:
>>
>> On Fri, 2021-10-08 at 08:44 -0400, Cris Rockwell wrote:
>>> Hi
>>>
>>>> Shall we mark those archetypes as deprecated for now?
>>> Yes. I can make that update to the site (if no one objects). It makes
>>> sense to deprecate broken archetypes, at least temporarily. These
>>> provide an initial starting point for developers looking to try the
>>> framework, so I think they should not only work properly but also
>>> have good documentation if possible. I also understand resource
>>> constraints.
>> +1 from me.
>>>
>>>> I would be in favour of just maintaing the sling-project-archetype
>>>> and
>>>> making sure that a) it works and b) is a reasonable starting point
>>>> for
>>>> Sling-based apps.
>>> FYI. I used sling-project-archetype two days ago. It worked well for
>>> me. It provided a reasonable starting basis for my new project.
>> Good to know, thanks.
>> Robert
Re: Maven Archetypes
Posted by Robert Munteanu <ro...@apache.org>.
Hi Andy,
As a FYI, the basic feature model work is done at
https://github.com/apache/sling-project-archetype/pull/5
I did not merge it because it would then require us to release Sling
Starter 12 to release any version of the project archetype. If we are
fine with that, I can merge it.
Other than that, we have a list of issues targeted to the current
release
https://issues.apache.org/jira/issues/?jql=project%20%3D%20SLING%20AND%20fixVersion%20%3D%20%22Sling%20Project%20Archetype%201.0.6%22
Your ideas sound good to me, feel free to raise issues and improve the
archetype :-)
Ah, and if we're retiring all but one archetype I think we should also
retire the archetype parent and move all the logic in the project
archetype.
Thanks,
Robert
On Fri, 2021-10-08 at 13:10 -0700, Andreas Schaefer wrote:
> Hi team
>
> Looking at the Project Archetype I see that I did not add support for
> FMs. So I was wondering if that would be something you might be
> interested.
> I was thinking to keep the current code / layout around with Bundle and
> Content Package(s) but add support for FMs and FARs.
>
> This would require:
>
> - Add a ‘far’ module that creates a FM and FAR like the All does
> - Migrate the rest to be able to generate FMs and convert if needed
> - Added a Bundle Content Module for the traditional and FM version
> - Use the post processing to remove unwanted modules or parts of them
> - Use kickstart to test the deployment of the FM / FAR module
>
> Cheers - Andy
>
> > On Oct 8, 2021, at 12:34 PM, Andreas Schaefer
> > <sc...@me.com.INVALID> wrote:
> >
> > Hi
> >
> > I did not work on the Project Archetype for a while but I am going to
> > have a look into it with respect to FMs.
> > There were some suggestions on how to improve it a while back and I
> > will try to find them again.
> >
> > Cheers - Andy
> >
> > > On Oct 8, 2021, at 8:01 AM, Robert Munteanu <ro...@apache.org>
> > > wrote:
> > >
> > > On Fri, 2021-10-08 at 08:44 -0400, Cris Rockwell wrote:
> > > > Hi
> > > >
> > > > > Shall we mark those archetypes as deprecated for now?
> > > > Yes. I can make that update to the site (if no one objects). It
> > > > makes
> > > > sense to deprecate broken archetypes, at least temporarily. These
> > > > provide an initial starting point for developers looking to try
> > > > the
> > > > framework, so I think they should not only work properly but also
> > > > have good documentation if possible. I also understand resource
> > > > constraints.
> > >
> > > +1 from me.
> > > >
> > > >
> > > > > I would be in favour of just maintaing the sling-project-
> > > > > archetype
> > > > > and
> > > > > making sure that a) it works and b) is a reasonable starting
> > > > > point
> > > > > for
> > > > > Sling-based apps.
> > > >
> > > > FYI. I used sling-project-archetype two days ago. It worked well
> > > > for
> > > > me. It provided a reasonable starting basis for my new project.
> > >
> > > Good to know, thanks.
> > > Robert
> >
>
Re: Maven Archetypes
Posted by Andreas Schaefer <sc...@me.com.INVALID>.
Hi team
Looking at the Project Archetype I see that I did not add support for FMs. So I was wondering if that would be something you might be interested.
I was thinking to keep the current code / layout around with Bundle and Content Package(s) but add support for FMs and FARs.
This would require:
- Add a ‘far’ module that creates a FM and FAR like the All does
- Migrate the rest to be able to generate FMs and convert if needed
- Added a Bundle Content Module for the traditional and FM version
- Use the post processing to remove unwanted modules or parts of them
- Use kickstart to test the deployment of the FM / FAR module
Cheers - Andy
> On Oct 8, 2021, at 12:34 PM, Andreas Schaefer <sc...@me.com.INVALID> wrote:
>
> Hi
>
> I did not work on the Project Archetype for a while but I am going to have a look into it with respect to FMs.
> There were some suggestions on how to improve it a while back and I will try to find them again.
>
> Cheers - Andy
>
>> On Oct 8, 2021, at 8:01 AM, Robert Munteanu <ro...@apache.org> wrote:
>>
>> On Fri, 2021-10-08 at 08:44 -0400, Cris Rockwell wrote:
>>> Hi
>>>
>>>> Shall we mark those archetypes as deprecated for now?
>>> Yes. I can make that update to the site (if no one objects). It makes
>>> sense to deprecate broken archetypes, at least temporarily. These
>>> provide an initial starting point for developers looking to try the
>>> framework, so I think they should not only work properly but also
>>> have good documentation if possible. I also understand resource
>>> constraints.
>>
>> +1 from me.
>>>
>>>
>>>> I would be in favour of just maintaing the sling-project-archetype
>>>> and
>>>> making sure that a) it works and b) is a reasonable starting point
>>>> for
>>>> Sling-based apps.
>>>
>>> FYI. I used sling-project-archetype two days ago. It worked well for
>>> me. It provided a reasonable starting basis for my new project.
>>
>> Good to know, thanks.
>> Robert
>
Re: Maven Archetypes
Posted by Andreas Schaefer <sc...@me.com.INVALID>.
Hi
I did not work on the Project Archetype for a while but I am going to have a look into it with respect to FMs.
There were some suggestions on how to improve it a while back and I will try to find them again.
Cheers - Andy
> On Oct 8, 2021, at 8:01 AM, Robert Munteanu <ro...@apache.org> wrote:
>
> On Fri, 2021-10-08 at 08:44 -0400, Cris Rockwell wrote:
>> Hi
>>
>>> Shall we mark those archetypes as deprecated for now?
>> Yes. I can make that update to the site (if no one objects). It makes
>> sense to deprecate broken archetypes, at least temporarily. These
>> provide an initial starting point for developers looking to try the
>> framework, so I think they should not only work properly but also
>> have good documentation if possible. I also understand resource
>> constraints.
>
> +1 from me.
>>
>>
>>> I would be in favour of just maintaing the sling-project-archetype
>>> and
>>> making sure that a) it works and b) is a reasonable starting point
>>> for
>>> Sling-based apps.
>>
>> FYI. I used sling-project-archetype two days ago. It worked well for
>> me. It provided a reasonable starting basis for my new project.
>
> Good to know, thanks.
> Robert
Re: Maven Archetypes
Posted by Robert Munteanu <ro...@apache.org>.
On Fri, 2021-10-08 at 08:44 -0400, Cris Rockwell wrote:
> Hi
>
> > Shall we mark those archetypes as deprecated for now?
> Yes. I can make that update to the site (if no one objects). It makes
> sense to deprecate broken archetypes, at least temporarily. These
> provide an initial starting point for developers looking to try the
> framework, so I think they should not only work properly but also
> have good documentation if possible. I also understand resource
> constraints.
+1 from me.
>
>
> > I would be in favour of just maintaing the sling-project-archetype
> > and
> > making sure that a) it works and b) is a reasonable starting point
> > for
> > Sling-based apps.
>
> FYI. I used sling-project-archetype two days ago. It worked well for
> me. It provided a reasonable starting basis for my new project.
Good to know, thanks.
Robert
Re: Maven Archetypes
Posted by Cris Rockwell <cm...@umich.edu>.
Hi
> Shall we mark those archetypes as deprecated for now?
Yes. I can make that update to the site (if no one objects). It makes sense to deprecate broken archetypes, at least temporarily. These provide an initial starting point for developers looking to try the framework, so I think they should not only work properly but also have good documentation if possible. I also understand resource constraints.
> I would be in favour of just maintaing the sling-project-archetype and
> making sure that a) it works and b) is a reasonable starting point for
> Sling-based apps.
FYI. I used sling-project-archetype two days ago. It worked well for me. It provided a reasonable starting basis for my new project.
- Cris
> On Oct 8, 2021, at 4:53 AM, Bertrand Delacretaz <bd...@apache.org> wrote:
>
> Hi,
>
> On Fri, Oct 8, 2021 at 10:35 AM Robert Munteanu <ro...@apache.org> wrote:
>> ...Thanks for looking into this. We do have lots of archetypes, and
>> technically all of them are supported, even the launchpad one...
>
> Technically yes, but in practice not really, until someone is willing
> to spend time maintaining them.
>
> Shall we mark those archetypes as deprecated for now?
>
> It would make the situation clearer, that doesn't prevent people from
> using them, and that status can be reverted if someone wants to work
> on them later.
>
> -Bertrand
Re: Maven Archetypes
Posted by Bertrand Delacretaz <bd...@apache.org>.
Hi,
On Fri, Oct 8, 2021 at 10:35 AM Robert Munteanu <ro...@apache.org> wrote:
> ...Thanks for looking into this. We do have lots of archetypes, and
> technically all of them are supported, even the launchpad one...
Technically yes, but in practice not really, until someone is willing
to spend time maintaining them.
Shall we mark those archetypes as deprecated for now?
It would make the situation clearer, that doesn't prevent people from
using them, and that status can be reverted if someone wants to work
on them later.
-Bertrand
Re: Maven Archetypes
Posted by Robert Munteanu <ro...@apache.org>.
Hi,
On Thu, 2021-10-07 at 16:18 -0400, Cris Rockwell wrote:
> Hi all
>
> For SLING-10857 <https://issues.apache.org/jira/browse/SLING-10857>
> I took an inventory of the Sling Maven archetypes in an attempt to
> improve the docs. and grouped the GitHub links below with
> failing/passing tests. Are they all still supported? I recently tried
> starting sling-launchpad-standalone-archetype but it failed to
> complete.
Thanks for looking into this. We do have lots of archetypes, and
technically all of them are supported, even the launchpad one.
In practice, we don't have the resources to maintain all of them. I
would be in favour of just maintaing the sling-project-archetype and
making sure that a) it works and b) is a reasonable starting point for
Sling-based apps.
Thanks,
Robert
>
> Failing
> https://github.com/apache/sling-launchpad-standalone-archetype <
> https://github.com/apache/sling-launchpad-standalone-archetype>
> https://github.com/apache/sling-launchpad-webapp-archetype <
> https://github.com/apache/sling-launchpad-webapp-archetype>
> https://github.com/apache/sling-servlet-archetype <
> https://github.com/apache/sling-servlet-archetype>
> https://github.com/apache/sling-bundle-archetype <
> https://github.com/apache/sling-bundle-archetype>
> https://github.com/apache/sling-jcrinstall-bundle-archetype <
> https://github.com/apache/sling-jcrinstall-bundle-archetype>
>
> Passing
> https://github.com/apache/sling-initial-content-archetype <
> https://github.com/apache/sling-initial-content-archetype>
> https://github.com/apache/sling-content-package-archetype <
> https://github.com/apache/sling-content-package-archetype>
> https://github.com/apache/sling-project-archetype <
> https://github.com/apache/sling-project-archetype>
>
> Cris
>