You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@syncope.apache.org by "massx1 (via GitHub)" <gi...@apache.org> on 2025/12/30 14:24:05 UTC

[PR] [SYNCOPE-1942] added getString to retrieve the label from localizatio… [syncope]

massx1 opened a new pull request, #1278:
URL: https://github.com/apache/syncope/pull/1278

   …n properties file


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@syncope.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [SYNCOPE-1942] added getString to retrieve the label from localization properties file [syncope]

Posted by "ilgrosso (via GitHub)" <gi...@apache.org>.
ilgrosso commented on code in PR #1278:
URL: https://github.com/apache/syncope/pull/1278#discussion_r2657907651


##########
client/idrepo/console/src/main/resources/org/apache/syncope/client/console/pages/BasePage.properties:
##########
@@ -33,3 +33,7 @@ endDelegation=End Delegation
 sessionExpiration.header=Session Expiration
 sessionExpiration.body=Your session is about to expire. Please select the appropriate option to keep working.
 sessionExpiration.extend=Extend
+

Review Comment:
   The menu is shown by all pages, which are all inheriting from `BasPage`, that's why putting the label in `BasePage*.properties` works. 
   
   You can't put it in `Topology*.properties` because otherwise all other pages will not know how to translate the Topology label.
   
   There should be a way to move the translations with their own module, especially considering ext pages, which are currently not included in this PR but need to.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@syncope.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [SYNCOPE-1942] added getString to retrieve the label from localization properties file [syncope]

Posted by "massx1 (via GitHub)" <gi...@apache.org>.
massx1 merged PR #1278:
URL: https://github.com/apache/syncope/pull/1278


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@syncope.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [SYNCOPE-1942] added getString to retrieve the label from localization properties file [syncope]

Posted by "ilgrosso (via GitHub)" <gi...@apache.org>.
ilgrosso commented on code in PR #1278:
URL: https://github.com/apache/syncope/pull/1278#discussion_r2653121125


##########
client/idrepo/console/src/main/java/org/apache/syncope/client/console/pages/BasePage.java:
##########
@@ -187,7 +187,7 @@ protected void populateItem(final ListItem<Class<? extends BasePage>> item) {
                 IdMPage ann = item.getModelObject().getAnnotation(IdMPage.class);
 
                 BookmarkablePageLink<Page> link = new BookmarkablePageLink<>("idmPage", item.getModelObject());
-                link.add(new Label("idmPageLabel", ann.label()));
+                link.add(new Label("idmPageLabel", getString(ann.label())));

Review Comment:
   Use the `getString()` variant with default, e.g.
   
   ```java
   getString(ann.label(), null, ann.label())
   ```
   
   so it will work even when the actual translation is not available



##########
client/idrepo/console/src/main/java/org/apache/syncope/client/console/pages/BasePage.java:
##########
@@ -226,7 +226,7 @@ protected void populateItem(final ListItem<Class<? extends BasePage>> item) {
                 AMPage ann = item.getModelObject().getAnnotation(AMPage.class);
 
                 BookmarkablePageLink<Page> link = new BookmarkablePageLink<>("amPage", item.getModelObject());
-                link.add(new Label("amPageLabel", ann.label()));
+                link.add(new Label("amPageLabel", getString(ann.label())));

Review Comment:
   same here



##########
client/idrepo/console/src/main/resources/org/apache/syncope/client/console/pages/BasePage.properties:
##########
@@ -33,3 +33,7 @@ endDelegation=End Delegation
 sessionExpiration.header=Session Expiration
 sessionExpiration.body=Your session is about to expire. Please select the appropriate option to keep working.
 sessionExpiration.extend=Extend
+

Review Comment:
   These labels shall be provided in the same module where the corresponding page is located, e.g. ``client/idm/console/src/main/resources/...` for `Topology`
   
   The other two labels are useless and should be removed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@syncope.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [SYNCOPE-1942] added getString to retrieve the label from localization properties file [syncope]

Posted by "massx1 (via GitHub)" <gi...@apache.org>.
massx1 commented on code in PR #1278:
URL: https://github.com/apache/syncope/pull/1278#discussion_r2658029083


##########
client/idrepo/console/src/main/resources/org/apache/syncope/client/console/pages/BasePage.properties:
##########
@@ -33,3 +33,7 @@ endDelegation=End Delegation
 sessionExpiration.header=Session Expiration
 sessionExpiration.body=Your session is about to expire. Please select the appropriate option to keep working.
 sessionExpiration.extend=Extend
+

Review Comment:
   I used the BasePage.properties file otherwise, the localized label would be visible only on the selected page. For example, the Home page would show the default label, while the Topology page would show the localized label. I think using BasePage is also a logical choice, since we are referring to the menu.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@syncope.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [SYNCOPE-1942] added getString to retrieve the label from localization properties file [syncope]

Posted by "ilgrosso (via GitHub)" <gi...@apache.org>.
ilgrosso commented on code in PR #1278:
URL: https://github.com/apache/syncope/pull/1278#discussion_r2658037164


##########
client/idrepo/console/src/main/resources/org/apache/syncope/client/console/pages/BasePage.properties:
##########
@@ -33,3 +33,7 @@ endDelegation=End Delegation
 sessionExpiration.header=Session Expiration
 sessionExpiration.body=Your session is about to expire. Please select the appropriate option to keep working.
 sessionExpiration.extend=Extend
+

Review Comment:
   Maybe you can have a look at [Wicket docs](https://nightlies.apache.org/wicket/guide/10.x/single.html#_internationalization_with_wicket) and come up with something that actually solves a general issue rather than just enabling the translation of `Topology` - because this is all that this PR seems to be about, while there is actually room for some serious improvement.
   
   Summarizing:
   
   1. come up with a solution which allows to plug-in translations for page menu items, whether such pages are idm, am or ext
   2. find a way to leave the labels in the same source module where the page is



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@syncope.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [SYNCOPE-1942] added getString to retrieve the label from localization properties file [syncope]

Posted by "ilgrosso (via GitHub)" <gi...@apache.org>.
ilgrosso commented on code in PR #1278:
URL: https://github.com/apache/syncope/pull/1278#discussion_r2668785517


##########
client/idrepo/common-ui/src/main/java/org/apache/syncope/client/ui/commons/DynamicMenuRegister.java:
##########
@@ -0,0 +1,38 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.syncope.client.ui.commons;
+
+import java.util.HashMap;
+import java.util.Map;
+
+public class DynamicMenuRegister {

Review Comment:
   If you place this class under UI commons, I would expect it to be used by both Console and Enduser, which I don't think is the case.
   
   The correct placement would be in `client-idrepo-console`.
   
   Secondly, there is no need to work with `static`: Console is a Spring Boot application, you can define a `Bean`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@syncope.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [SYNCOPE-1942] added getString to retrieve the label from localization properties file [syncope]

Posted by "ilgrosso (via GitHub)" <gi...@apache.org>.
ilgrosso commented on code in PR #1278:
URL: https://github.com/apache/syncope/pull/1278#discussion_r2689184341


##########
client/idrepo/console/src/main/java/org/apache/syncope/client/console/SyncopeWebApplication.java:
##########
@@ -240,6 +244,26 @@ protected void init() {
 
         mountPage("/login", getSignInPageClass());
 
+        //[SYNCOPE-1942]

Review Comment:
   No need to comment with issue reference, we have `git blame` for this



##########
client/idrepo/common-ui/src/main/java/org/apache/syncope/client/ui/commons/DynamicMenuStringResourceLoader.java:
##########
@@ -0,0 +1,68 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.syncope.client.ui.commons;
+
+import java.util.Locale;
+import org.apache.wicket.core.util.resource.locator.IResourceNameIterator;
+import org.apache.wicket.resource.IPropertiesFactory;
+import org.apache.wicket.resource.Properties;
+import org.apache.wicket.resource.loader.ClassStringResourceLoader;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+public class DynamicMenuStringResourceLoader extends ClassStringResourceLoader {
+
+    protected static final Logger LOG = LoggerFactory.getLogger(DynamicMenuStringResourceLoader.class);
+
+    public DynamicMenuStringResourceLoader() {
+        super(DynamicMenuStringResourceLoader.class);
+    }
+
+    @Override
+    public String loadStringResource(
+            final Class<?> clazz,
+            final String key,
+            final Locale locale,
+            final String style,
+            final String variation) {
+
+        if (key != null && key.startsWith("menu.")) {
+            Class<?> pageClass = DynamicMenuRegister.getPage(key);
+
+            if (pageClass != null) {
+                final String path = pageClass.getName().replace('.', '/');
+                final IResourceNameIterator iter = newResourceNameIterator(path, locale, style, variation);
+                final IPropertiesFactory propertiesFactory = getPropertiesFactory();
+
+                while (iter.hasNext()) {

Review Comment:
   Use streams, not iterators



##########
client/idrepo/console/src/main/resources/org/apache/syncope/client/console/pages/BasePage.properties:
##########
@@ -16,7 +16,7 @@
 # under the License.
 home=Home
 version=Version
-domain=Domain
+domain=Domain   

Review Comment:
   Please revert this space-adding change



##########
client/idrepo/enduser/src/main/java/org/apache/syncope/client/enduser/SyncopeWebApplication.java:
##########
@@ -203,6 +206,26 @@ public IResource getResource() {
             }
         }
 
+        //[SYNCOPE-1942]

Review Comment:
   Same as above



##########
client/idrepo/common-ui/src/main/java/org/apache/syncope/client/ui/commons/DynamicMenuRegister.java:
##########
@@ -0,0 +1,38 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.syncope.client.ui.commons;
+
+import java.util.HashMap;
+import java.util.Map;
+
+public final class DynamicMenuRegister {

Review Comment:
   Turn this class into a bean.
   
   You can take https://github.com/apache/syncope/blob/master/client/idrepo/common-ui/src/main/java/org/apache/syncope/client/ui/commons/MIMETypesLoader.java as reference



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@syncope.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [SYNCOPE-1942] added getString to retrieve the label from localization properties file [syncope]

Posted by "ilgrosso (via GitHub)" <gi...@apache.org>.
ilgrosso commented on PR #1278:
URL: https://github.com/apache/syncope/pull/1278#issuecomment-3699539246

   @massx1 welcome back!
   Have you already linked your GitHub and ASF accounts by https://gitbox.apache.org/boxer/ ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@syncope.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [SYNCOPE-1942] added getString to retrieve the label from localization properties file [syncope]

Posted by "ilgrosso (via GitHub)" <gi...@apache.org>.
ilgrosso commented on code in PR #1278:
URL: https://github.com/apache/syncope/pull/1278#discussion_r2689183209


##########
client/idrepo/common-ui/src/main/java/org/apache/syncope/client/ui/commons/DynamicMenuStringResourceLoader.java:
##########
@@ -0,0 +1,68 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.syncope.client.ui.commons;
+
+import java.util.Locale;
+import org.apache.wicket.core.util.resource.locator.IResourceNameIterator;
+import org.apache.wicket.resource.IPropertiesFactory;
+import org.apache.wicket.resource.Properties;
+import org.apache.wicket.resource.loader.ClassStringResourceLoader;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+public class DynamicMenuStringResourceLoader extends ClassStringResourceLoader {
+
+    protected static final Logger LOG = LoggerFactory.getLogger(DynamicMenuStringResourceLoader.class);
+
+    public DynamicMenuStringResourceLoader() {
+        super(DynamicMenuStringResourceLoader.class);
+    }
+
+    @Override
+    public String loadStringResource(
+            final Class<?> clazz,
+            final String key,
+            final Locale locale,
+            final String style,
+            final String variation) {
+
+        if (key != null && key.startsWith("menu.")) {
+            Class<?> pageClass = DynamicMenuRegister.getPage(key);
+
+            if (pageClass != null) {
+                final String path = pageClass.getName().replace('.', '/');
+                final IResourceNameIterator iter = newResourceNameIterator(path, locale, style, variation);
+                final IPropertiesFactory propertiesFactory = getPropertiesFactory();
+
+                while (iter.hasNext()) {

Review Comment:
   Use streams, not iterators



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@syncope.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [SYNCOPE-1942] added getString to retrieve the label from localization properties file [syncope]

Posted by "ilgrosso (via GitHub)" <gi...@apache.org>.
ilgrosso commented on code in PR #1278:
URL: https://github.com/apache/syncope/pull/1278#discussion_r2668772636


##########
client/idrepo/common-ui/src/main/java/org/apache/syncope/client/ui/commons/DynamicMenuStringResourceLoader.java:
##########
@@ -0,0 +1,78 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.syncope.client.ui.commons;
+
+import java.util.Locale;
+import org.apache.syncope.client.ui.commons.DynamicMenuRegister;
+import org.apache.wicket.core.util.resource.locator.IResourceNameIterator;
+import org.apache.wicket.resource.IPropertiesFactory;
+import org.apache.wicket.resource.Properties;
+import org.apache.wicket.resource.loader.ClassStringResourceLoader;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+public class DynamicMenuStringResourceLoader extends ClassStringResourceLoader {
+
+    protected static final Logger LOG = LoggerFactory.getLogger(DynamicMenuStringResourceLoader.class);
+
+    public DynamicMenuStringResourceLoader() {
+        super(DynamicMenuStringResourceLoader.class);
+    }
+
+    @Override
+    public String loadStringResource(
+            Class<?> clazz,
+            String key,
+            Locale locale,
+            String style,
+            String variation) {
+        LOG.info("XXXXX key {}", key);

Review Comment:
   Remove all those `LOG` statements or at least fix them



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@syncope.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [SYNCOPE-1942] added getString to retrieve the label from localization properties file [syncope]

Posted by "massx1 (via GitHub)" <gi...@apache.org>.
massx1 commented on code in PR #1278:
URL: https://github.com/apache/syncope/pull/1278#discussion_r2668783076


##########
client/idrepo/common-ui/src/main/java/org/apache/syncope/client/ui/commons/DynamicMenuStringResourceLoader.java:
##########
@@ -0,0 +1,78 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.syncope.client.ui.commons;
+
+import java.util.Locale;
+import org.apache.syncope.client.ui.commons.DynamicMenuRegister;
+import org.apache.wicket.core.util.resource.locator.IResourceNameIterator;
+import org.apache.wicket.resource.IPropertiesFactory;
+import org.apache.wicket.resource.Properties;
+import org.apache.wicket.resource.loader.ClassStringResourceLoader;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+public class DynamicMenuStringResourceLoader extends ClassStringResourceLoader {
+
+    protected static final Logger LOG = LoggerFactory.getLogger(DynamicMenuStringResourceLoader.class);
+
+    public DynamicMenuStringResourceLoader() {
+        super(DynamicMenuStringResourceLoader.class);
+    }
+
+    @Override
+    public String loadStringResource(
+            Class<?> clazz,
+            String key,
+            Locale locale,
+            String style,
+            String variation) {
+        LOG.info("XXXXX key {}", key);

Review Comment:
   already done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@syncope.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [SYNCOPE-1942] added getString to retrieve the label from localization properties file [syncope]

Posted by "massx1 (via GitHub)" <gi...@apache.org>.
massx1 commented on code in PR #1278:
URL: https://github.com/apache/syncope/pull/1278#discussion_r2668772331


##########
client/idrepo/console/src/main/resources/org/apache/syncope/client/console/pages/BasePage.properties:
##########
@@ -33,3 +33,7 @@ endDelegation=End Delegation
 sessionExpiration.header=Session Expiration
 sessionExpiration.body=Your session is about to expire. Please select the appropriate option to keep working.
 sessionExpiration.extend=Extend
+

Review Comment:
   Pushed a new version with dynamic property reading. With this approach, the label is read from a property file located in the same package as the page. All pages with these annotations (IdmPages, AmPages, ExtPages) will be managed automatically.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@syncope.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [SYNCOPE-1942] added getString to retrieve the label from localization properties file [syncope]

Posted by "massx1 (via GitHub)" <gi...@apache.org>.
massx1 commented on code in PR #1278:
URL: https://github.com/apache/syncope/pull/1278#discussion_r2668874682


##########
client/idrepo/common-ui/src/main/java/org/apache/syncope/client/ui/commons/DynamicMenuRegister.java:
##########
@@ -0,0 +1,38 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.syncope.client.ui.commons;
+
+import java.util.HashMap;
+import java.util.Map;
+
+public class DynamicMenuRegister {

Review Comment:
   Yes It's used by both...  
   
   Static should be necessary to have the same instance Map for all the used classes.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@syncope.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [SYNCOPE-1942] added getString to retrieve the label from localization properties file [syncope]

Posted by "massx1 (via GitHub)" <gi...@apache.org>.
massx1 commented on code in PR #1278:
URL: https://github.com/apache/syncope/pull/1278#discussion_r2657897304


##########
client/idrepo/console/src/main/resources/org/apache/syncope/client/console/pages/BasePage.properties:
##########
@@ -33,3 +33,7 @@ endDelegation=End Delegation
 sessionExpiration.header=Session Expiration
 sessionExpiration.body=Your session is about to expire. Please select the appropriate option to keep working.
 sessionExpiration.extend=Extend
+

Review Comment:
   Removed labels for SRA and WA.
   It seems that the labels are available only via the BasePage properties file. Creating a Topology properties file does not work, possibly because the IdmPages are dynamic.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@syncope.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [SYNCOPE-1942] added getString to retrieve the label from localization properties file [syncope]

Posted by "massx1 (via GitHub)" <gi...@apache.org>.
massx1 commented on PR #1278:
URL: https://github.com/apache/syncope/pull/1278#issuecomment-3705474850

   > @massx1 welcome back! Have you already linked your GitHub and ASF accounts by https://gitbox.apache.org/boxer/ ?
   
   done


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@syncope.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org