You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/05/10 07:14:25 UTC

[GitHub] [pulsar] coderzc opened a new pull request, #15521: [doc] Add a note of enabled package management on admin-api-packages page

coderzc opened a new pull request, #15521:
URL: https://github.com/apache/pulsar/pull/15521

   Fixes #14472
   
   ### Motivation
   
   Missing a note of enabled package management on admin-api-packages page
   
   ### Modifications
   
   Add a note of enabled package management on admin-api-packages page
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If `yes` was chosen, please highlight the changes*
   
     - Dependencies (does it add or upgrade a dependency): (yes / no)
     - The public API: (yes / no)
     - The schema: (yes / no / don't know)
     - The default values of configurations: (yes / no)
     - The wire protocol: (yes / no)
     - The rest endpoints: (yes / no)
     - The admin cli options: (yes / no)
     - Anything that affects deployment: (yes / no / don't know)
   
   ### Documentation
   
   Check the box below or label this PR directly.
   
   Need to update docs? 
   
   - [ ] `doc-required` 
   (Your PR needs to update docs and you will update later)
     
   - [ ] `no-need-doc` 
   (Please explain why)
     
   - [x] `doc` 
   (Your PR contains doc changes)
   
   - [ ] `doc-added`
   (Docs have been already added)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] coderzc commented on pull request #15521: [doc] Add a note of enabled package management on admin-api-packages page

Posted by GitBox <gi...@apache.org>.
coderzc commented on PR #15521:
URL: https://github.com/apache/pulsar/pull/15521#issuecomment-1122032358

   @codelipenghui can you review the PR?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] momo-jun commented on a diff in pull request #15521: [doc] Add a note of enabled package management on admin-api-packages page

Posted by GitBox <gi...@apache.org>.
momo-jun commented on code in PR #15521:
URL: https://github.com/apache/pulsar/pull/15521#discussion_r868906112


##########
site2/docs/admin-api-packages.md:
##########
@@ -60,7 +60,18 @@ source://my-tenant/my-ns/mysql-cdc-source@2.3
 
 ## Package management in Pulsar
 
-You can use the command line tools, REST API, or the Java client to manage your package resources in Pulsar. More specifically, you can use these tools to [upload](#upload-a-package), [download](#download-a-package), and [delete](#delete-a-package) a package, [get the metadata](#get-the-metadata-of-a-package) and [update the metadata](#update-the-metadata-of-a-package) of a package, [get the versions](#list-all-versions-of-a-package) of a package, and [get all packages of a specific type under a namespace](#list-all-packages-of-a-specific-type-under-a-namespace).  
+You can use the command line tools, REST API, or the Java client to manage your package resources in Pulsar. More specifically, you can use these tools to [upload](#upload-a-package), [download](#download-a-package), and [delete](#delete-a-package) a package, [get the metadata](#get-the-metadata-of-a-package) and [update the metadata](#update-the-metadata-of-a-package) of a package, [get the versions](#list-all-versions-of-a-package) of a package, and [get all packages of a specific type under a namespace](#list-all-packages-of-a-specific-type-under-a-namespace).
+
+To use Package management service, ensure that the package management service has been enabled in your cluster by setting the following properties in broker.conf.

Review Comment:
   ```suggestion
   To use package management service, ensure that the package management service has been enabled in your cluster by setting the following properties in `broker.conf`.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Anonymitaet merged pull request #15521: [improve][doc] Add a note of enabled package management on admin-api-packages page

Posted by GitBox <gi...@apache.org>.
Anonymitaet merged PR #15521:
URL: https://github.com/apache/pulsar/pull/15521


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Anonymitaet commented on pull request #15521: [doc] Add a note of enabled package management on admin-api-packages page

Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on PR #15521:
URL: https://github.com/apache/pulsar/pull/15521#issuecomment-1122080936

   can you please rename your PR? eg. [improve][doc] xxx
   guideline: https://docs.google.com/document/d/1d8Pw6ZbWk-_pCKdOmdvx9rnhPiyuxwq60_TrD68d7BA/edit#heading=h.wu6ygjne8e35 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] momo-jun commented on a diff in pull request #15521: [doc] Add a note of enabled package management on admin-api-packages page

Posted by GitBox <gi...@apache.org>.
momo-jun commented on code in PR #15521:
URL: https://github.com/apache/pulsar/pull/15521#discussion_r868908666


##########
site2/docs/admin-api-packages.md:
##########
@@ -60,7 +60,18 @@ source://my-tenant/my-ns/mysql-cdc-source@2.3
 
 ## Package management in Pulsar
 
-You can use the command line tools, REST API, or the Java client to manage your package resources in Pulsar. More specifically, you can use these tools to [upload](#upload-a-package), [download](#download-a-package), and [delete](#delete-a-package) a package, [get the metadata](#get-the-metadata-of-a-package) and [update the metadata](#update-the-metadata-of-a-package) of a package, [get the versions](#list-all-versions-of-a-package) of a package, and [get all packages of a specific type under a namespace](#list-all-packages-of-a-specific-type-under-a-namespace).  
+You can use the command line tools, REST API, or the Java client to manage your package resources in Pulsar. More specifically, you can use these tools to [upload](#upload-a-package), [download](#download-a-package), and [delete](#delete-a-package) a package, [get the metadata](#get-the-metadata-of-a-package) and [update the metadata](#update-the-metadata-of-a-package) of a package, [get the versions](#list-all-versions-of-a-package) of a package, and [get all packages of a specific type under a namespace](#list-all-packages-of-a-specific-type-under-a-namespace).
+
+To use Package management service, ensure that the package management service has been enabled in your cluster by setting the following properties in broker.conf.
+
+> Note: Package management service is not enabled by default.
+
+```yaml
+enablePackagesManagement=true
+packagesManagementStorageProvider=org.apache.pulsar.packages.management.storage.bookkeeper.BookKeeperPackagesStorageProvider
+packagesReplicas=1

Review Comment:
   Need a double-check on the number "1", which may not be appropriate for production.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] momo-jun commented on pull request #15521: [doc] Add a note of enabled package management on admin-api-packages page

Posted by GitBox <gi...@apache.org>.
momo-jun commented on PR #15521:
URL: https://github.com/apache/pulsar/pull/15521#issuecomment-1122032275

   @coderzc Thanks for contributing to docs and fixing this issue. 
   Can you pls request a peer review from a technical perspective?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] coderzc commented on pull request #15521: [doc] Add a note of enabled package management on admin-api-packages page

Posted by GitBox <gi...@apache.org>.
coderzc commented on PR #15521:
URL: https://github.com/apache/pulsar/pull/15521#issuecomment-1122091989

   > [improve][doc]
   
   ok


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org