You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "hubgeter (via GitHub)" <gi...@apache.org> on 2026/03/15 12:32:08 UTC

[PR] branch-4.0:[fix](iceberg)fix core when read a iceberg table that have schema change and equality delete. (#59984) [doris]

hubgeter opened a new pull request, #61348:
URL: https://github.com/apache/doris/pull/61348

   bp #59984
   Problem Summary:
   This PR addresses three major issues related to reading Iceberg tables:
   
   1. When reading an Iceberg table that contains equality delete files, a crash may occur if schema changes have been applied to the affected columns.
   The root cause is that the previous implementation matched columns by column name when applying equality deletes. However, Iceberg requires matching columns by Iceberg field ID to correctly identify the original column across schema evolution.
   This PR updates the equality delete logic to resolve columns using Iceberg IDs instead of column names.
   
   2. For Iceberg tables migrated from Hive, legacy data files do not contain Iceberg field IDs.
   In this case, columns must be resolved using the table property `schema.name-mapping.default.`
   This PR adds support for using the name mapping defined in table properties to correctly match columns when reading such data files.
   
   3. Reduce Thrift metadata overhead during table reads. To optimize read performance, this PR reduces the amount of Thrift metadata transmitted when reading Iceberg tables. `History_schema_info` now includes only the columns required for the read, including pruning of nested fields within complex types.
   
   Handle Iceberg data files with missing field IDs.
   Fix equality delete handling for Iceberg tables with schema changes.
   
   ### What problem does this PR solve?
   
   Issue Number: close #xxx
   
   Related PR: #xxx
   
   Problem Summary:
   
   ### Release note
   
   None
   
   ### Check List (For Author)
   
   - Test <!-- At least one of them must be included. -->
       - [ ] Regression test
       - [ ] Unit Test
       - [ ] Manual test (add detailed scripts or steps below)
       - [ ] No need to test or manual test. Explain why:
           - [ ] This is a refactor/code format and no logic has been changed.
           - [ ] Previous test can cover this change.
           - [ ] No code files have been changed.
           - [ ] Other reason <!-- Add your reason?  -->
   
   - Behavior changed:
       - [ ] No.
       - [ ] Yes. <!-- Explain the behavior change -->
   
   - Does this need documentation?
       - [ ] No.
       - [ ] Yes. <!-- Add document PR link here. eg: https://github.com/apache/doris-website/pull/1214 -->
   
   ### Check List (For Reviewer who merge this PR)
   
   - [ ] Confirm the release note
   - [ ] Confirm test cases
   - [ ] Confirm document
   - [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] branch-4.0:[fix](iceberg)fix core when read a iceberg table that have schema change and equality delete. (#59984) [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #61348:
URL: https://github.com/apache/doris/pull/61348#issuecomment-4065391658

   # BE Regression && UT Coverage Report
   Increment line coverage `3.62% (22/607)` :tada:
   
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/61348_53b8814d5bcb571d40dccd4f551725498801905f_merge/increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/61348_53b8814d5bcb571d40dccd4f551725498801905f_merge/report/index.html)
   | Category          | Coverage           |
   |-------------------|--------------------|
   | Function Coverage | 71.39% (25299/35437) |
   | Line Coverage     | 54.05% (266854/493685) |
   | Region Coverage   | 51.57% (220293/427171) |
   | Branch Coverage   | 53.09% (95028/179001) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] branch-4.0:[fix](iceberg)fix core when read a iceberg table that have schema change and equality delete. (#59984) [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #61348:
URL: https://github.com/apache/doris/pull/61348#issuecomment-4065224911

   # BE UT Coverage Report
   Increment line coverage `11.04% (67/607)` :tada:
   
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/53b8814d5bcb571d40dccd4f551725498801905f_53b8814d5bcb571d40dccd4f551725498801905f/increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/53b8814d5bcb571d40dccd4f551725498801905f_53b8814d5bcb571d40dccd4f551725498801905f/report/index.html)
   | Category          | Coverage           |
   |-------------------|--------------------|
   | Function Coverage | 52.98% (19181/36201) |
   | Line Coverage     | 36.13% (178704/494569) |
   | Region Coverage   | 32.75% (138494/422896) |
   | Branch Coverage   | 33.73% (60164/178358) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] branch-4.0:[fix](iceberg)fix core when read a iceberg table that have schema change and equality delete. (#59984) [doris]

Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei merged PR #61348:
URL: https://github.com/apache/doris/pull/61348


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] branch-4.0:[fix](iceberg)fix core when read a iceberg table that have schema change and equality delete. (#59984) [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #61348:
URL: https://github.com/apache/doris/pull/61348#issuecomment-4064842791

   # Cloud UT Coverage Report
   Increment line coverage ` ` :tada:
   
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/53b8814d5bcb571d40dccd4f551725498801905f_53b8814d5bcb571d40dccd4f551725498801905f_cloud/increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/53b8814d5bcb571d40dccd4f551725498801905f_53b8814d5bcb571d40dccd4f551725498801905f_cloud/report/index.html)
   | Category          | Coverage           |
   |-------------------|--------------------|
   | Function Coverage | 79.15% (1788/2259) |
   | Line Coverage     | 64.55% (31972/49530) |
   | Region Coverage   | 65.33% (15985/24468) |
   | Branch Coverage   | 55.92% (8508/15214) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] branch-4.0:[fix](iceberg)fix core when read a iceberg table that have schema change and equality delete. (#59984) [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #61348:
URL: https://github.com/apache/doris/pull/61348#issuecomment-4063003680

   # FE UT Coverage Report
   Increment line coverage `  70.75% (75/106)` :tada:
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/61348_a5971fe535a789ff1d2ed93e80d791417e46f2eb/fe_increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/61348_a5971fe535a789ff1d2ed93e80d791417e46f2eb/fe_report/index.html)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] branch-4.0:[fix](iceberg)fix core when read a iceberg table that have schema change and equality delete. (#59984) [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #61348:
URL: https://github.com/apache/doris/pull/61348#issuecomment-4064950966

   # FE UT Coverage Report
   Increment line coverage `  70.75% (75/106)` :tada:
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/61348_53b8814d5bcb571d40dccd4f551725498801905f/fe_increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/61348_53b8814d5bcb571d40dccd4f551725498801905f/fe_report/index.html)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] branch-4.0:[fix](iceberg)fix core when read a iceberg table that have schema change and equality delete. (#59984) [doris]

Posted by "Thearas (via GitHub)" <gi...@apache.org>.
Thearas commented on PR #61348:
URL: https://github.com/apache/doris/pull/61348#issuecomment-4062901125

   
   Thank you for your contribution to Apache Doris.
   Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
   
   Please clearly describe your PR:
   1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
   2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
   3. What features were added. Why was this function added?
   4. Which code was refactored and why was this part of the code refactored?
   5. Which functions were optimized and what is the difference before and after the optimization?
       


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] branch-4.0:[fix](iceberg)fix core when read a iceberg table that have schema change and equality delete. (#59984) [doris]

Posted by "hubgeter (via GitHub)" <gi...@apache.org>.
hubgeter commented on PR #61348:
URL: https://github.com/apache/doris/pull/61348#issuecomment-4064764293

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] branch-4.0:[fix](iceberg)fix core when read a iceberg table that have schema change and equality delete. (#59984) [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #61348:
URL: https://github.com/apache/doris/pull/61348#issuecomment-4062955261

   # Cloud UT Coverage Report
   Increment line coverage ` ` :tada:
   
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/a5971fe535a789ff1d2ed93e80d791417e46f2eb_a5971fe535a789ff1d2ed93e80d791417e46f2eb_cloud/increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/a5971fe535a789ff1d2ed93e80d791417e46f2eb_a5971fe535a789ff1d2ed93e80d791417e46f2eb_cloud/report/index.html)
   | Category          | Coverage           |
   |-------------------|--------------------|
   | Function Coverage | 79.15% (1788/2259) |
   | Line Coverage     | 64.49% (31942/49530) |
   | Region Coverage   | 65.29% (15975/24468) |
   | Branch Coverage   | 55.87% (8500/15214) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] branch-4.0:[fix](iceberg)fix core when read a iceberg table that have schema change and equality delete. (#59984) [doris]

Posted by "hubgeter (via GitHub)" <gi...@apache.org>.
hubgeter commented on PR #61348:
URL: https://github.com/apache/doris/pull/61348#issuecomment-4062901227

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org