You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@iceberg.apache.org by gi...@apache.org on 2026/10/12 11:21:16 UTC

(iceberg-rust) branch gh-readonly-queue/main/pr-3407-693339072b87eebf075479393a8ef55182f27aca created (now 418732fbd)

This is an automated email from the ASF dual-hosted git repository.

github-merge-queue[bot] pushed a change to branch gh-readonly-queue/main/pr-3407-693339072b87eebf075479393a8ef55182f27aca
in repository https://gitbox.apache.org/repos/asf/iceberg-rust.git


      at 418732fbd refactor(catalog-loader): rename CatalogBuilderFactory to BoxedCatalogBuilderFactory (#3407)

This branch includes the following new commits:

     new 418732fbd refactor(catalog-loader): rename CatalogBuilderFactory to BoxedCatalogBuilderFactory (#3407)

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.



(iceberg-rust) 01/01: refactor(catalog-loader): rename CatalogBuilderFactory to BoxedCatalogBuilderFactory (#3407)

Posted by gi...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

github-merge-queue[bot] pushed a commit to branch gh-readonly-queue/main/pr-3407-693339072b87eebf075479393a8ef55182f27aca
in repository https://gitbox.apache.org/repos/asf/iceberg-rust.git

commit 418732fbd48ba41ca7c2393d6ba35645907a8a99
Author: NoahKusaba <97...@users.noreply.github.com>
AuthorDate: Mon Oct 12 09:14:36 2026 +0000

    refactor(catalog-loader): rename CatalogBuilderFactory to BoxedCatalogBuilderFactory (#3407)
    
    The factories in the registry return a Box<dyn BoxedCatalogBuilder>, not a
    CatalogBuilder, so name the alias after the trait it produces. Suggested in
    review of #3286.
---
 crates/catalog/loader/src/lib.rs | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/crates/catalog/loader/src/lib.rs b/crates/catalog/loader/src/lib.rs
index 3993de676..cfb2f3270 100644
--- a/crates/catalog/loader/src/lib.rs
+++ b/crates/catalog/loader/src/lib.rs
@@ -28,11 +28,11 @@ use iceberg_catalog_rest::RestCatalogBuilder;
 use iceberg_catalog_s3tables::S3TablesCatalogBuilder;
 use iceberg_catalog_sql::SqlCatalogBuilder;
 
-/// A CatalogBuilderFactory creating a new catalog builder.
-type CatalogBuilderFactory = fn() -> Box<dyn BoxedCatalogBuilder>;
+/// Creates a new catalog builder, boxed as a [`BoxedCatalogBuilder`].
+type BoxedCatalogBuilderFactory = fn() -> Box<dyn BoxedCatalogBuilder>;
 
-/// A registry of catalog builders.
-static CATALOG_REGISTRY: &[(&str, CatalogBuilderFactory)] = &[
+/// Maps each catalog type to the factory for its builder.
+static CATALOG_REGISTRY: &[(&str, BoxedCatalogBuilderFactory)] = &[
     ("rest", || Box::new(RestCatalogBuilder::default())),
     ("glue", || Box::new(GlueCatalogBuilder::default())),
     ("s3tables", || Box::new(S3TablesCatalogBuilder::default())),