You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2022/10/22 23:27:23 UTC
[GitHub] [fineract] josehernandezfintecheandomx opened a new pull request, #2692: FINERACT-1706: Fix Loan Transaction Chargeback outstanding
josehernandezfintecheandomx opened a new pull request, #2692:
URL: https://github.com/apache/fineract/pull/2692
## Description
There was an issue in the Loan trancsaction Chargeback outstanding amount when the Loan was previously overpaid and the user applies a Chargeback transaction
[FINERACT-1706](https://issues.apache.org/jira/browse/FINERACT-1706)
Part of the log messages in the integration test
<img width="1535" alt="Screen Shot 2022-10-22 at 18 16 50" src="https://user-images.githubusercontent.com/44206706/197366011-39cee638-14a1-40eb-88af-598596de3af4.png">
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [ ] Write the commit message as per https://github.com/apache/fineract/#pull-requests
- [ ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
- [ ] Create/update unit or integration tests for verifying the changes made.
- [ ] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
- [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
- [ ] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] galovics merged pull request #2692: FINERACT-1706: Fix Loan Transaction Chargeback outstanding
Posted by GitBox <gi...@apache.org>.
galovics merged PR #2692:
URL: https://github.com/apache/fineract/pull/2692
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] adamsaghy commented on a diff in pull request #2692: FINERACT-1706: Fix Loan Transaction Chargeback outstanding
Posted by GitBox <gi...@apache.org>.
adamsaghy commented on code in PR #2692:
URL: https://github.com/apache/fineract/pull/2692#discussion_r1003149720
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/api/LoanTransactionsApiResourceSwagger.java:
##########
@@ -164,6 +164,22 @@ private GetLoanTransactionRelation() {}
public String reversalExternalId;
@Schema(example = "[2012, 5, 18]")
public LocalDate reversedOnDate;
+ @Schema(example = "1000.00")
Review Comment:
netDisbursalAmount has nothing to do with Loan transaction. Please remove!
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/api/LoanTransactionsApiResourceSwagger.java:
##########
@@ -164,6 +164,22 @@ private GetLoanTransactionRelation() {}
public String reversalExternalId;
@Schema(example = "[2012, 5, 18]")
public LocalDate reversedOnDate;
+ @Schema(example = "1000.00")
+ public Double netDisbursalAmount;
+ @Schema(example = "240.00")
+ public Double principalPortion;
+ @Schema(example = "23.90")
+ public Double feeChargesPortion;
+ @Schema(example = "12.80")
+ public Double penaltyChargesPortion;
+ @Schema(example = "33.00")
+ public Double overpaymentPortion;
+ @Schema(example = "55.50")
+ public Double unrecognizedIncomePortion;
+ @Schema(example = "100.00")
+ public Double outstandingLoanBalance;
+ @Schema(example = "[2012, 5, 18]")
+ public LocalDate possibleNextRepaymentDate;
Review Comment:
possibleNextRepaymentDate has nothing to do with Loan transaction. Please remove!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org