You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "zhengruifeng (via GitHub)" <gi...@apache.org> on 2023/07/10 01:17:43 UTC
[GitHub] [spark] zhengruifeng opened a new pull request, #41911: [SPARK-43710][PS][FOLLOWUP] Fix `date_part` invocations
zhengruifeng opened a new pull request, #41911:
URL: https://github.com/apache/spark/pull/41911
### What changes were proposed in this pull request?
fix https://github.com/apache/spark/commit/bc20e85b0e1da510cc091dbd03f210ef9fc56b25:
1, should use `F.lit("HOUR")` as the parameter;
2, should also change `def microseconds` since the old function was removed;
### Why are the changes needed?
to fix wrong usage
### Does this PR introduce _any_ user-facing change?
no
### How was this patch tested?
existing UT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on pull request #41911: [SPARK-43710][PS][FOLLOWUP] Fix `date_part` invocations
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on PR #41911:
URL: https://github.com/apache/spark/pull/41911#issuecomment-1628236173
thank you @yaooqinn @LuciferYang
merged into master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng closed pull request #41911: [SPARK-43710][PS][FOLLOWUP] Fix `date_part` invocations
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng closed pull request #41911: [SPARK-43710][PS][FOLLOWUP] Fix `date_part` invocations
URL: https://github.com/apache/spark/pull/41911
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org