[jira] [Commented] (PDFBOX-2225) ClassCastException in PDFMergerUtility.appendDocument

["Andreas Lehmkühler (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PDFBOX-2225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14117298#comment-14117298 ] 

Andreas Lehmkühler commented on PDFBOX-2225:
--------------------------------------------

[~tilman] IMO we don't need to rethrow the exception, just the remove the second catch clause. As you already said, the authors original intention was to handle IOExceptions based on the state of ignoreAcroFormErrors

> ClassCastException in PDFMergerUtility.appendDocument
> -----------------------------------------------------
>
>                 Key: PDFBOX-2225
>                 URL: https://issues.apache.org/jira/browse/PDFBOX-2225
>             Project: PDFBox
>          Issue Type: Bug
>          Components: Utilities
>    Affects Versions: 1.8.1, 1.8.6, 1.8.7, 2.0.0
>         Environment: Windows 7 64-bit, JDK8
>            Reporter: Brandon Lyon
>            Priority: Minor
>             Fix For: 1.8.7, 2.0.0
>
>
> Edit: Problem confirmed to exist in 1.8.1 and 1.8.6
> The following exception will occur if any type of Exception other than IOException is thrown within a particular try-catch in PDFMergerUtility.appendDocument:
> java.lang.ClassCastException: java.lang.IndexOutOfBoundsException cannot be cast to java.io.IOException
> For the version I am using (1.8.1), the problem occurs on line 294
> The problem is that the author mistakenly assumed that the only exception which could be caught was IOException. I recommend that the cast be removed, and that either the additional checked exceptions be thrown by appendDocument or wrapped with an unchecked exception
> Also, anyone seeing this may want to investigate why an IndexOutOfBoundsException is occurring here, though this is obviously a separate issue



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)