You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2021/09/15 19:28:11 UTC

[GitHub] [incubator-yunikorn-core] craigcondit commented on pull request #318: [YUNIKORN-831] node sorting should check other resources of nodes instead of comparing node id directly

craigcondit commented on pull request #318:
URL: https://github.com/apache/incubator-yunikorn-core/pull/318#issuecomment-920315442


   Upon testing this locally, it seems that we really do need to consider the fact that resources have different units. I've opened a new issue https://issues.apache.org/jira/browse/YUNIKORN-847 with PR https://github.com/apache/incubator-yunikorn-core/pull/323 that provides an alternative approach. The new PR uses configurable weights for each resource and normalizes resources into percentage occupied rather than considering the absolute values. By default, weights are equal for vcore and memory, and 0 for everything else (effectively ignoring them).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org