You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by faisal-hameed <gi...@git.apache.org> on 2016/03/10 19:09:23 UTC
[GitHub] httpcore pull request: Code quality fix - Utility classes should n...
GitHub user faisal-hameed opened a pull request:
https://github.com/apache/httpcore/pull/26
Code quality fix - Utility classes should not have public constructors.
This pull request is focused on resolving occurrences of Sonar rule
squid:S1118 - Utility classes should not have public constructors.
You can find more information about the issue here:
https://dev.eclipse.org/sonar/rules/show/squid:S1118
Please let me know if you have any questions.
Faisal Hameed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/DevFactory/httpcore release/utility-classes-should-not-have-public-constructor-fix-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/httpcore/pull/26.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #26
----
commit c46038b7e434fd46a1cb0b87140733347edf07b8
Author: Faisal Hameed <fa...@devfactory.com>
Date: 2016-03-09T19:50:18Z
Fixing squid:S1118 - Utility classes should not have public constructors.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] httpcore pull request: Code quality fix - Utility classes should n...
Posted by garydgregory <gi...@git.apache.org>.
Github user garydgregory commented on the pull request:
https://github.com/apache/httpcore/pull/26#issuecomment-195153712
Thank you for the updated patch!
Committed revision 1734489.
Gary
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] httpcore pull request #26: Code quality fix - Utility classes should not hav...
Posted by faisal-hameed <gi...@git.apache.org>.
Github user faisal-hameed closed the pull request at:
https://github.com/apache/httpcore/pull/26
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] httpcore pull request: Code quality fix - Utility classes should n...
Posted by faisal-hameed <gi...@git.apache.org>.
Github user faisal-hameed commented on the pull request:
https://github.com/apache/httpcore/pull/26#issuecomment-195012745
@garydgregory Done changes as you suggested.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] httpcore pull request: Code quality fix - Utility classes should n...
Posted by garydgregory <gi...@git.apache.org>.
Github user garydgregory commented on the pull request:
https://github.com/apache/httpcore/pull/26#issuecomment-194998971
I think that if you want to have this kind of change, I would like it better if there was a code comment on the ctor that read something like "Do not allow utility this class to be instantiated."
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org