You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@struts.apache.org by Lukasz Lenart <lu...@apache.org> on 2014/09/21 15:36:15 UTC
Struts 2.3.18 ready for test
Hi,
Please take a time and test the bits - any help is appreciated. Please
report back any problems. I'll call for vote in a week if no problems
will be spotted.
Staging Maven repo
https://repository.apache.org/content/groups/staging/
Standalone artifacts
http://people.apache.org/builds/struts/2.3.18/
Release notes
https://cwiki.apache.org/confluence/display/WW/Version+Notes+2.3.18
Thanks in advance & regards
--
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Struts 2.3.18 ready for test
Posted by Lukasz Lenart <lu...@apache.org>.
2014-09-23 14:10 GMT+02:00 Volker Krebs <vo...@abas.de>:
> It's not working in the exception_handling example as well:
> http://localhost:8080/exception_handling/actionspecificexception.action
I was able solve this issue, see
https://git-wip-us.apache.org/repos/asf?p=struts.git;a=commit;h=3b9d58614f0ad192da8bffa657b820c28cdaa1ef
Regards
--
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Struts 2.3.18 ready for test
Posted by Volker Krebs <vo...@abas.de>.
It's not working in the exception_handling example as well:
http://localhost:8080/exception_handling/actionspecificexception.action
Am 23.09.2014 um 13:38 schrieb Volker Krebs:
> Found another strange behaviour with 2.3.18
>
> I have defined an exception mapping like this:
> <action name="workdeskCheckIn"
> class="shopfloor.pdc.workdeskCheckIn.action" method="checkInToWorkdesk">
> <exception-mapping exception="services.NotFoundException"
> result="error" />
> <result name="success">success.jsp</result>
> <result name="error">error.jsp</result>
> </action>
>
> When checkInToWorkdesk throws an NotFoundException I'll get the
> following Error:
>
> Exception1: Method "checkInToWorkdesk" failed for object
> shopfloor.pdc.WorkdeskCheckIn@72916b9a
> Exception Class: class ognl.MethodFailedException
> ognl.OgnlRuntime.callAppropriateMethod(OgnlRuntime.java:1305)
> ognl.ObjectMethodAccessor.callMethod(ObjectMethodAccessor.java:68)
>
> com.opensymphony.xwork2.ognl.accessor.XWorkMethodAccessor.callMethodWithDebugInfo(XWorkMethodAccessor.java:117)
>
>
> com.opensymphony.xwork2.ognl.accessor.XWorkMethodAccessor.callMethod(XWorkMethodAccessor.java:108)
>
> ognl.OgnlRuntime.callMethod(OgnlRuntime.java:1369)
> Exception2: null
> Exception Class: class services.NotFound
>
> I'll try to confirm this with exception_handling example on
> git://git.apache.org/struts-examples.git
>
>
> Am 22.09.2014 um 23:01 schrieb Lukasz Lenart:
>> Finally I was able redeploy new artifacts - you can test them again :-)
>>
>> 2014-09-22 8:58 GMT+02:00 Lukasz Lenart <lu...@apache.org>:
>>> 2014-09-22 8:55 GMT+02:00 Greg Huber <gr...@gmail.com>:
>>>> ..The reason for message: The following artifacts could not be
>>>> resolved:
>>>> org.apache.struts:struts2-core:jar:2.3.18... ?
>>>>
>>>> at
>>>>
>>>> https://repository.apache.org/content/groups/staging/
>>>
>>> Just dropped them and preparing new build...
>>>
>>>
>>> Regards
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Struts 2.3.18 ready for test
Posted by Volker Krebs <vo...@abas.de>.
Found another strange behaviour with 2.3.18
I have defined an exception mapping like this:
<action name="workdeskCheckIn"
class="shopfloor.pdc.workdeskCheckIn.action" method="checkInToWorkdesk">
<exception-mapping exception="services.NotFoundException"
result="error" />
<result name="success">success.jsp</result>
<result name="error">error.jsp</result>
</action>
When checkInToWorkdesk throws an NotFoundException I'll get the
following Error:
Exception1: Method "checkInToWorkdesk" failed for object
shopfloor.pdc.WorkdeskCheckIn@72916b9a
Exception Class: class ognl.MethodFailedException
ognl.OgnlRuntime.callAppropriateMethod(OgnlRuntime.java:1305)
ognl.ObjectMethodAccessor.callMethod(ObjectMethodAccessor.java:68)
com.opensymphony.xwork2.ognl.accessor.XWorkMethodAccessor.callMethodWithDebugInfo(XWorkMethodAccessor.java:117)
com.opensymphony.xwork2.ognl.accessor.XWorkMethodAccessor.callMethod(XWorkMethodAccessor.java:108)
ognl.OgnlRuntime.callMethod(OgnlRuntime.java:1369)
Exception2: null
Exception Class: class services.NotFound
I'll try to confirm this with exception_handling example on
git://git.apache.org/struts-examples.git
Am 22.09.2014 um 23:01 schrieb Lukasz Lenart:
> Finally I was able redeploy new artifacts - you can test them again :-)
>
> 2014-09-22 8:58 GMT+02:00 Lukasz Lenart <lu...@apache.org>:
>> 2014-09-22 8:55 GMT+02:00 Greg Huber <gr...@gmail.com>:
>>> ..The reason for message: The following artifacts could not be resolved:
>>> org.apache.struts:struts2-core:jar:2.3.18... ?
>>>
>>> at
>>>
>>> https://repository.apache.org/content/groups/staging/
>>
>> Just dropped them and preparing new build...
>>
>>
>> Regards
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Struts 2.3.18 ready for test
Posted by Lukasz Lenart <lu...@apache.org>.
2014-09-23 11:26 GMT+02:00 Volker Krebs <vo...@abas.de>:
> Hello,
> we are using the spring object factory in our project.
> We have a bean named "localeProvider", so does struts 2.3.18
> This was never a Problem before, but now when starting the server I'll get
> the exception below.
>
> The class JakartaMultiPartRequest gets a localeProvider injected.
> But in struts 2.3.18 our bean named "localeProvider" is found not the
> struts2 bean.
>
> Has something changed with the autowire strategy ?
> When renaming our bean everything works fine.
>
> impl.DefaultConversionPropertiesProcessor - Conversion registration error
> org.springframework.beans.TypeMismatchException: Failed to convert property
> value of type [com.ourproject.LocaleProvider] to required type
> [com.opensymphony.xwork2.LocaleProvider] for property 'localeProvider';
> nested exception is java.lang.IllegalArgumentException: Cannot convert value
> of type [com.ourproject.LocaleProvider] to required type
> [com.opensymphony.xwork2.LocaleProvider] for property 'localeProvider': no
> matching editors or conversion strategy found
> at
> org.springframework.beans.BeanWrapperImpl.convertForProperty(BeanWrapperImpl.java:391)
> at
> org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.convertForProperty(AbstractAutowireCapableBeanFactory.java:1289)
> at
> org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.applyPropertyValues(AbstractAutowireCapableBeanFactory.java:1250)
> at
> org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.populateBean(AbstractAutowireCapableBeanFactory.java:1010)
> at
> org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.autowireBeanProperties(AbstractAutowireCapableBeanFactory.java:329)
> at
> com.opensymphony.xwork2.spring.SpringObjectFactory.autoWireBean(SpringObjectFactory.java:218)
> at
> com.opensymphony.xwork2.spring.SpringObjectFactory.buildBean(SpringObjectFactory.java:198)
> at
> com.opensymphony.xwork2.spring.SpringObjectFactory.buildBean(SpringObjectFactory.java:164)
> at
> com.opensymphony.xwork2.ObjectFactory.buildBean(ObjectFactory.java:178)
> at
> com.opensymphony.xwork2.conversion.impl.DefaultTypeConverterCreator.createTypeConverter(DefaultTypeConverterCreator.java:23)
Can you post the whole stacktrace?
Maybe it has something to do with that change
https://git-wip-us.apache.org/repos/asf?p=struts.git;a=blobdiff;f=xwork-core/src/main/java/com/opensymphony/xwork2/conversion/impl/DefaultTypeConverter.java;h=e3363c2d367e4350884ce71c67d847debe5956a5;hp=b1342cd0266cceaa7fb0d1996f26e1e4eafdcdfd;hb=d749bb8;hpb=08ad1199edcc68d32549ba23ff3f0cedd87dadb5
Regards
--
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Struts 2.3.18 ready for test
Posted by Volker Krebs <vo...@abas.de>.
Hello,
we are using the spring object factory in our project.
We have a bean named "localeProvider", so does struts 2.3.18
This was never a Problem before, but now when starting the server I'll
get the exception below.
The class JakartaMultiPartRequest gets a localeProvider injected.
But in struts 2.3.18 our bean named "localeProvider" is found not the
struts2 bean.
Has something changed with the autowire strategy ?
When renaming our bean everything works fine.
impl.DefaultConversionPropertiesProcessor - Conversion registration error
org.springframework.beans.TypeMismatchException: Failed to convert
property value of type [com.ourproject.LocaleProvider] to required type
[com.opensymphony.xwork2.LocaleProvider] for property 'localeProvider';
nested exception is java.lang.IllegalArgumentException: Cannot convert
value of type [com.ourproject.LocaleProvider] to required type
[com.opensymphony.xwork2.LocaleProvider] for property 'localeProvider':
no matching editors or conversion strategy found
at
org.springframework.beans.BeanWrapperImpl.convertForProperty(BeanWrapperImpl.java:391)
at
org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.convertForProperty(AbstractAutowireCapableBeanFactory.java:1289)
at
org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.applyPropertyValues(AbstractAutowireCapableBeanFactory.java:1250)
at
org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.populateBean(AbstractAutowireCapableBeanFactory.java:1010)
at
org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.autowireBeanProperties(AbstractAutowireCapableBeanFactory.java:329)
at
com.opensymphony.xwork2.spring.SpringObjectFactory.autoWireBean(SpringObjectFactory.java:218)
at
com.opensymphony.xwork2.spring.SpringObjectFactory.buildBean(SpringObjectFactory.java:198)
at
com.opensymphony.xwork2.spring.SpringObjectFactory.buildBean(SpringObjectFactory.java:164)
at com.opensymphony.xwork2.ObjectFactory.buildBean(ObjectFactory.java:178)
at
com.opensymphony.xwork2.conversion.impl.DefaultTypeConverterCreator.createTypeConverter(DefaultTypeConverterCreator.java:23)
Am 22.09.2014 um 23:01 schrieb Lukasz Lenart:
> Finally I was able redeploy new artifacts - you can test them again :-)
>
> 2014-09-22 8:58 GMT+02:00 Lukasz Lenart <lu...@apache.org>:
>> 2014-09-22 8:55 GMT+02:00 Greg Huber <gr...@gmail.com>:
>>> ..The reason for message: The following artifacts could not be resolved:
>>> org.apache.struts:struts2-core:jar:2.3.18... ?
>>>
>>> at
>>>
>>> https://repository.apache.org/content/groups/staging/
>>
>> Just dropped them and preparing new build...
>>
>>
>> Regards
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Struts 2.3.18 ready for test
Posted by Lukasz Lenart <lu...@apache.org>.
2014-09-23 8:53 GMT+02:00 Greg Huber <gr...@gmail.com>:
> Lukasz,
>
> I have used in the past the class="" on the s:a tag:
>
> <s:a class="divtab" action="..">..</s:a>
>
> I now get a "Unable to find setter method for attribute: class" message.
> Do I have to change all these now to cssClass?
>
> The class shows as still being available.
>
> .... The css class to use for element - it's an alias of cssClass attribute.
hm... something wrong, it supposed to work without rewriting
anything... will check, thanks!
Regards
--
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Struts 2.3.18 ready for test
Posted by Lukasz Lenart <lu...@apache.org>.
2014-09-23 21:26 GMT+02:00 Aaron Johnson <jo...@gmail.com>:
> Have a look at
> https://github.com/StripesFramework/stripes/blob/master/stripes/src/main/java/net/sourceforge/stripes/tag/HtmlTagSupportBeanInfo.java.
> This allows the HtmlTagSupport tag to have an attribute named 'class'
> without interfering with the getClass() method.
Thanks a lot! I gave up too fast :-)
Regards
--
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Struts 2.3.18 ready for test
Posted by Lukasz Lenart <lu...@apache.org>.
2014-09-24 9:10 GMT+02:00 Greg Huber <gr...@gmail.com>:
> The url I have is:
>
> <url>https://repository.apache.org/content/groups/snapshots-group/</url>
>
> ie
>
> http://repository.apache.org/content/groups/snapshots-group/org/apache/struts/struts2-core/2.3.18-SNAPSHOT/
> etc..
>
> If this is correct, it works, no exception and checked it uses the class.
Yes, it's the correct URL and thanks a lot!
Regards
--
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Struts 2.3.18 ready for test
Posted by Greg Huber <gr...@gmail.com>.
The url I have is:
<url>https://repository.apache.org/content/groups/snapshots-group/</url>
ie
http://repository.apache.org/content/groups/snapshots-group/org/apache/struts/struts2-core/2.3.18-SNAPSHOT/
etc..
If this is correct, it works, no exception and checked it uses the class.
Cheers Greg
On 24 September 2014 06:15, Lukasz Lenart <lu...@apache.org> wrote:
> Hi,
>
> Can you test the changes based on the SNAPSHOT version? I can publish
> new release build but it will take few hours or days (repository.a.o
> gets timeouts very often during uploading large artefacts) - if not I
> will prepare new build, just let me know!
>
>
> Regards
> --
> Łukasz
> + 48 606 323 122 http://www.lenart.org.pl/
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>
Re: Re: Struts 2.3.18 ready for test
Posted by "caolbmail@gmail.com" <ca...@gmail.com>.
ok.
caolbmail@gmail.com
From: Lukasz Lenart
Date: 2014-09-24 13:15
To: Struts Developers List
Subject: Re: Struts 2.3.18 ready for test
Hi,
Can you test the changes based on the SNAPSHOT version? I can publish
new release build but it will take few hours or days (repository.a.o
gets timeouts very often during uploading large artefacts) - if not I
will prepare new build, just let me know!
Regards
--
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Struts 2.3.18 ready for test
Posted by Lukasz Lenart <lu...@apache.org>.
Hi,
Can you test the changes based on the SNAPSHOT version? I can publish
new release build but it will take few hours or days (repository.a.o
gets timeouts very often during uploading large artefacts) - if not I
will prepare new build, just let me know!
Regards
--
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Struts 2.3.18 ready for test
Posted by Lukasz Lenart <lu...@apache.org>.
2014-09-23 21:26 GMT+02:00 Aaron Johnson <jo...@gmail.com>:
> Have a look at
> https://github.com/StripesFramework/stripes/blob/master/stripes/src/main/java/net/sourceforge/stripes/tag/HtmlTagSupportBeanInfo.java.
> This allows the HtmlTagSupport tag to have an attribute named 'class'
> without interfering with the getClass() method.
Thanks Aaron, implemented!
Regards
--
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Struts 2.3.18 ready for test
Posted by Aaron Johnson <jo...@gmail.com>.
Have a look at
https://github.com/StripesFramework/stripes/blob/master/stripes/src/main/java/net/sourceforge/stripes/tag/HtmlTagSupportBeanInfo.java.
This allows the HtmlTagSupport tag to have an attribute named 'class'
without interfering with the getClass() method.
On Tue, Sep 23, 2014 at 1:35 PM, Lukasz Lenart <lu...@apache.org>
wrote:
> 2014-09-23 8:53 GMT+02:00 Greg Huber <gr...@gmail.com>:
> > Lukasz,
> >
> > I have used in the past the class="" on the s:a tag:
> >
> > <s:a class="divtab" action="..">..</s:a>
> >
> > I now get a "Unable to find setter method for attribute: class" message.
> > Do I have to change all these now to cssClass?
> >
> > The class shows as still being available.
> >
> > .... The css class to use for element - it's an alias of cssClass
> attribute.
>
> It won't work :( I will have to revert that change (will drop "class"
> attribute) - it depends on a container how to interpret this property.
>
>
> Regards
> --
> Łukasz
> + 48 606 323 122 http://www.lenart.org.pl/
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>
Re: Struts 2.3.18 ready for test
Posted by Lukasz Lenart <lu...@apache.org>.
2014-09-23 8:53 GMT+02:00 Greg Huber <gr...@gmail.com>:
> Lukasz,
>
> I have used in the past the class="" on the s:a tag:
>
> <s:a class="divtab" action="..">..</s:a>
>
> I now get a "Unable to find setter method for attribute: class" message.
> Do I have to change all these now to cssClass?
>
> The class shows as still being available.
>
> .... The css class to use for element - it's an alias of cssClass attribute.
It won't work :( I will have to revert that change (will drop "class"
attribute) - it depends on a container how to interpret this property.
Regards
--
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Struts 2.3.18 ready for test
Posted by Greg Huber <gr...@gmail.com>.
Lukasz,
I have used in the past the class="" on the s:a tag:
<s:a class="divtab" action="..">..</s:a>
I now get a "Unable to find setter method for attribute: class" message.
Do I have to change all these now to cssClass?
The class shows as still being available.
.... The css class to use for element - it's an alias of cssClass attribute.
Cheers Greg
On 22 September 2014 22:01, Lukasz Lenart <lu...@apache.org> wrote:
> Finally I was able redeploy new artifacts - you can test them again :-)
>
> 2014-09-22 8:58 GMT+02:00 Lukasz Lenart <lu...@apache.org>:
> > 2014-09-22 8:55 GMT+02:00 Greg Huber <gr...@gmail.com>:
> >> ..The reason for message: The following artifacts could not be
> resolved:
> >> org.apache.struts:struts2-core:jar:2.3.18... ?
> >>
> >> at
> >>
> >> https://repository.apache.org/content/groups/staging/
> >
> > Just dropped them and preparing new build...
> >
> >
> > Regards
> > --
> > Łukasz
> > + 48 606 323 122 http://www.lenart.org.pl/
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>
Re: Struts 2.3.18 ready for test
Posted by Lukasz Lenart <lu...@apache.org>.
Finally I was able redeploy new artifacts - you can test them again :-)
2014-09-22 8:58 GMT+02:00 Lukasz Lenart <lu...@apache.org>:
> 2014-09-22 8:55 GMT+02:00 Greg Huber <gr...@gmail.com>:
>> ..The reason for message: The following artifacts could not be resolved:
>> org.apache.struts:struts2-core:jar:2.3.18... ?
>>
>> at
>>
>> https://repository.apache.org/content/groups/staging/
>
> Just dropped them and preparing new build...
>
>
> Regards
> --
> Łukasz
> + 48 606 323 122 http://www.lenart.org.pl/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Struts 2.3.18 ready for test
Posted by Lukasz Lenart <lu...@apache.org>.
2014-09-22 8:55 GMT+02:00 Greg Huber <gr...@gmail.com>:
> ..The reason for message: The following artifacts could not be resolved:
> org.apache.struts:struts2-core:jar:2.3.18... ?
>
> at
>
> https://repository.apache.org/content/groups/staging/
Just dropped them and preparing new build...
Regards
--
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Struts 2.3.18 ready for test
Posted by Greg Huber <gr...@gmail.com>.
..The reason for message: The following artifacts could not be resolved:
org.apache.struts:struts2-core:jar:2.3.18... ?
at
https://repository.apache.org/content/groups/staging/
Cheers Greg
On 22 September 2014 07:42, Lukasz Lenart <lu...@apache.org> wrote:
> 2014-09-21 15:36 GMT+02:00 Lukasz Lenart <lu...@apache.org>:
> > Hi,
> >
> > Please take a time and test the bits - any help is appreciated. Please
> > report back any problems. I'll call for vote in a week if no problems
> > will be spotted.
> >
> > Staging Maven repo
> > https://repository.apache.org/content/groups/staging/
> >
> > Standalone artifacts
> > http://people.apache.org/builds/struts/2.3.18/
> >
> > Release notes
> > https://cwiki.apache.org/confluence/display/WW/Version+Notes+2.3.18
>
> Just discovered issue with dynamicAttributes ...
>
>
> Regards
> --
> Łukasz
> + 48 606 323 122 http://www.lenart.org.pl/
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>
Re: Struts 2.3.18 ready for test
Posted by Lukasz Lenart <lu...@apache.org>.
2014-09-21 15:36 GMT+02:00 Lukasz Lenart <lu...@apache.org>:
> Hi,
>
> Please take a time and test the bits - any help is appreciated. Please
> report back any problems. I'll call for vote in a week if no problems
> will be spotted.
>
> Staging Maven repo
> https://repository.apache.org/content/groups/staging/
>
> Standalone artifacts
> http://people.apache.org/builds/struts/2.3.18/
>
> Release notes
> https://cwiki.apache.org/confluence/display/WW/Version+Notes+2.3.18
Just discovered issue with dynamicAttributes ...
Regards
--
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Struts 2.3.18 ready for test
Posted by Greg Huber <gr...@gmail.com>.
sorry.... did a manual project "clean" and now works ok, something new with
luna especially when changing jars around.
Cheers greg
On 29 September 2014 08:00, Lukasz Lenart <lu...@apache.org> wrote:
> 2014-09-29 8:55 GMT+02:00 Greg Huber <gr...@gmail.com>:
> > Retesting this, it seems that the validator messages have stopped
> working.
> > Have there been any changes wrt to this from the previous snapshot,
> which I
> > think were working OK.
>
> Rather no... what kind of validator messages, from
> <actionName>-validation.xml?
>
>
> Regards
> --
> Łukasz
> + 48 606 323 122 http://www.lenart.org.pl/
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>
Re: Struts 2.3.18 ready for test
Posted by Lukasz Lenart <lu...@apache.org>.
2014-09-29 9:07 GMT+02:00 Greg Huber <gr...@gmail.com>:
> From the log file :
>
> 2014-09-29 07:53:50,801 WARN
> com.opensymphony.xwork2.util.LocalizedTextUtil CommonsLogger:warn
>
> Missing key [bean.description.required] in bundle [ApplicationResources]!
> Missing key [bean.description.required] in bundle
> [org/apache/struts2/struts-messages]!
> Missing key [bean.description.required] in bundle
> [com/opensymphony/xwork2/xwork-messages]!
>
> the properties file :
>
> ui/struts2/editor/EventAdd.properties
>
> and the class :
>
> ui/struts2/editor/EventAdd.java
>
> and the validation file :
>
> ui/struts2/editor/EventAdd-eventAdd!save-validation.xml
Is it related to missing validation messages or is it something else?
Regards
--
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Struts 2.3.18 ready for test
Posted by Greg Huber <gr...@gmail.com>.
>From the log file :
2014-09-29 07:53:50,801 WARN
com.opensymphony.xwork2.util.LocalizedTextUtil CommonsLogger:warn
Missing key [bean.description.required] in bundle [ApplicationResources]!
Missing key [bean.description.required] in bundle
[org/apache/struts2/struts-messages]!
Missing key [bean.description.required] in bundle
[com/opensymphony/xwork2/xwork-messages]!
the properties file :
ui/struts2/editor/EventAdd.properties
and the class :
ui/struts2/editor/EventAdd.java
and the validation file :
ui/struts2/editor/EventAdd-eventAdd!save-validation.xml
Cheers Greg.
On 29 September 2014 08:00, Lukasz Lenart <lu...@apache.org> wrote:
> 2014-09-29 8:55 GMT+02:00 Greg Huber <gr...@gmail.com>:
> > Retesting this, it seems that the validator messages have stopped
> working.
> > Have there been any changes wrt to this from the previous snapshot,
> which I
> > think were working OK.
>
> Rather no... what kind of validator messages, from
> <actionName>-validation.xml?
>
>
> Regards
> --
> Łukasz
> + 48 606 323 122 http://www.lenart.org.pl/
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>
Re: Struts 2.3.18 ready for test
Posted by Lukasz Lenart <lu...@apache.org>.
2014-09-29 8:55 GMT+02:00 Greg Huber <gr...@gmail.com>:
> Retesting this, it seems that the validator messages have stopped working.
> Have there been any changes wrt to this from the previous snapshot, which I
> think were working OK.
Rather no... what kind of validator messages, from <actionName>-validation.xml?
Regards
--
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Struts 2.3.18 ready for test
Posted by Greg Huber <gr...@gmail.com>.
Retesting this, it seems that the validator messages have stopped working.
Have there been any changes wrt to this from the previous snapshot, which I
think were working OK.
Cheers Greg.
On 27 September 2014 10:01, Lukasz Lenart <lu...@apache.org> wrote:
> Hi,
>
> I have deployed new artefacts to staging repo, please test the bits!
>
> Staging Maven repo
> https://repository.apache.org/content/groups/staging/
>
> Standalone artifacts
> http://people.apache.org/builds/struts/2.3.18/
>
> Release notes
> https://cwiki.apache.org/confluence/display/WW/Version+Notes+2.3.18
>
>
> Thanks in advance
> --
> Łukasz
> + 48 606 323 122 http://www.lenart.org.pl/
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>
Re: Struts 2.3.18 ready for test
Posted by Christoph Nenning <Ch...@lex-com.net>.
> > 3. LocaleProvider created by a ConfigurationProvider
> > To deal with errors on file uploads we have a ConfigurationProvider
that
> > registers a LocaleProvider programmatically which is only used before
the
> > interceptor stack is executed.
> > With struts 2.3.16 that LocaleProvider was only called once per
request,
> > now it is called all over the place (probably for each getText()).
> > So it seems that the before-interceptor-stack-approach does not work
> > anymore.
> >
>
> So a new LocaleProvider is needed just to satisfy bootstrap time
>
>
I think you can forget about that one.
After some more investigation it seems that it happens just in conjunction
with WW-4408 and only on first request after HttpSession was created.
regards,
Christoph
This Email was scanned by Sophos Anti Virus
Re: Struts 2.3.18 ready for test
Posted by Lukasz Lenart <lu...@apache.org>.
2014-09-29 17:38 GMT+02:00 Christoph Nenning <Ch...@lex-com.net>:
> 3. LocaleProvider created by a ConfigurationProvider
> To deal with errors on file uploads we have a ConfigurationProvider that
> registers a LocaleProvider programmatically which is only used before the
> interceptor stack is executed.
> With struts 2.3.16 that LocaleProvider was only called once per request,
> now it is called all over the place (probably for each getText()).
> So it seems that the before-interceptor-stack-approach does not work
> anymore.
>
>
>
> 4. ActionContext.getContext().getSession()
> Again the ConfigurationProvider from point 3. It tries to access the
> HttpSession to figure out if the user has a language chosen.
> With struts 2.3.16 it returned always a map which may have been empty. Now
> we get null.
> That happens on the login page, so there might be no session yet.
So a new LocaleProvider is needed just to satisfy bootstrap time
Regards
--
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Struts 2.3.18 ready for test
Posted by Lukasz Lenart <lu...@apache.org>.
Looks like a time for Vote.
Regards
--
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Struts 2.3.18 ready for test
Posted by Mi...@silbergrau.com.
looks good
From: Lukasz Lenart <lu...@apache.org>
To: Struts Developers List <de...@struts.apache.org>
Date: 21/10/2014 16:46
Subject: Re: Struts 2.3.18 ready for test
2014-10-17 14:31 GMT+02:00 Lukasz Lenart <lu...@apache.org>:
> H,
>
> Just pushed new artifacts, please remember to purge previous release
> artifacts (rm ~/.m2/repository/org/apache/struts)
>
http://stackoverflow.com/questions/7959499/force-re-download-of-release-dependency-using-maven
>
> Staging Maven repo
> https://repository.apache.org/content/groups/staging/
>
> Standalone artifacts
> http://people.apache.org/builds/struts/2.3.18/
>
> Release notes
> https://cwiki.apache.org/confluence/display/WW/Version+Notes+2.3.18
Did you have chance to test the new artifacts with the latest fixes? I
would like call for Vote at the beginning of next week.
Regards
--
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Struts 2.3.18 ready for test
Posted by Christoph Nenning <Ch...@lex-com.net>.
> 2014-10-17 14:31 GMT+02:00 Lukasz Lenart <lu...@apache.org>:
> > H,
> >
> > Just pushed new artifacts, please remember to purge previous release
> > artifacts (rm ~/.m2/repository/org/apache/struts)
> > http://stackoverflow.com/questions/7959499/force-re-download-of-
> release-dependency-using-maven
> >
> > Staging Maven repo
> > https://repository.apache.org/content/groups/staging/
> >
> > Standalone artifacts
> > http://people.apache.org/builds/struts/2.3.18/
> >
> > Release notes
> > https://cwiki.apache.org/confluence/display/WW/Version+Notes+2.3.18
>
> Did you have chance to test the new artifacts with the latest fixes? I
> would like call for Vote at the beginning of next week.
>
>
Downloaded them and tested -> works fine !
Regards,
Christoph
This Email was scanned by Sophos Anti Virus
Re: Struts 2.3.18 ready for test
Posted by Lukasz Lenart <lu...@apache.org>.
2014-10-17 14:31 GMT+02:00 Lukasz Lenart <lu...@apache.org>:
> H,
>
> Just pushed new artifacts, please remember to purge previous release
> artifacts (rm ~/.m2/repository/org/apache/struts)
> http://stackoverflow.com/questions/7959499/force-re-download-of-release-dependency-using-maven
>
> Staging Maven repo
> https://repository.apache.org/content/groups/staging/
>
> Standalone artifacts
> http://people.apache.org/builds/struts/2.3.18/
>
> Release notes
> https://cwiki.apache.org/confluence/display/WW/Version+Notes+2.3.18
Did you have chance to test the new artifacts with the latest fixes? I
would like call for Vote at the beginning of next week.
Regards
--
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Struts 2.3.18 ready for test
Posted by Lukasz Lenart <lu...@apache.org>.
H,
Just pushed new artifacts, please remember to purge previous release
artifacts (rm ~/.m2/repository/org/apache/struts)
http://stackoverflow.com/questions/7959499/force-re-download-of-release-dependency-using-maven
Staging Maven repo
https://repository.apache.org/content/groups/staging/
Standalone artifacts
http://people.apache.org/builds/struts/2.3.18/
Release notes
https://cwiki.apache.org/confluence/display/WW/Version+Notes+2.3.18
Regards
--
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Struts 2.3.18 ready for test
Posted by Lukasz Lenart <lu...@apache.org>.
2014-10-12 13:10 GMT+02:00 Lukasz Lenart <lu...@apache.org>:
> 2014-10-12 11:34 GMT+02:00 Greg Huber <gr...@gmail.com>:
>> Went through this release and tested it, seems good to be released.
>>
>> Are there other issues?
>
> Christoph Nenning registered two issues, still working on them
>
> https://issues.apache.org/jira/issues/?jql=project%20%3D%20WW%20AND%20fixVersion%20%3D%202.3.18%20AND%20resolution%20%3D%20Unresolved%20ORDER%20BY%20due%20ASC%2C%20priority%20DESC%2C%20created%20ASC
Looks like all the issues are solved, I'm going to prepare a new artifacts
Regards
--
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Struts 2.3.18 ready for test
Posted by Lukasz Lenart <lu...@apache.org>.
2014-10-12 11:34 GMT+02:00 Greg Huber <gr...@gmail.com>:
> Went through this release and tested it, seems good to be released.
>
> Are there other issues?
Christoph Nenning registered two issues, still working on them
https://issues.apache.org/jira/issues/?jql=project%20%3D%20WW%20AND%20fixVersion%20%3D%202.3.18%20AND%20resolution%20%3D%20Unresolved%20ORDER%20BY%20due%20ASC%2C%20priority%20DESC%2C%20created%20ASC
Regards
--
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Struts 2.3.18 ready for test
Posted by Greg Huber <gr...@gmail.com>.
Went through this release and tested it, seems good to be released.
Are there other issues?
Cheers Greg
On 3 October 2014 07:49, Lukasz Lenart <lu...@apache.org> wrote:
> 2014-09-30 9:09 GMT+02:00 Lukasz Lenart <lu...@apache.org>:
> > Added a note to docs (I thought there was one already) - in your case
> > the problem is with a constructor, its target is evaluated to
> > java.lang.Class which is on the excluded list of classes.
> >
> >
> https://cwiki.apache.org/confluence/display/WW/Security#Security-Internalsecuritymechanism
>
> I have extended the description as there is one more case in which
> application can blow up :-)
>
>
> https://cwiki.apache.org/confluence/display/WW/Security#Security-OGNLisusedtocallaction'smethods
>
>
> Regards
> --
> Łukasz
> + 48 606 323 122 http://www.lenart.org.pl/
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>
Re: Struts 2.3.18 ready for test
Posted by Christoph Nenning <Ch...@lex-com.net>.
> > Added a note to docs (I thought there was one already) - in your case
> > the problem is with a constructor, its target is evaluated to
> > java.lang.Class which is on the excluded list of classes.
> >
> > https://cwiki.apache.org/confluence/display/WW/Security#Security-
> Internalsecuritymechanism
>
> I have extended the description as there is one more case in which
> application can blow up :-)
>
> https://cwiki.apache.org/confluence/display/WW/Security#Security-
> OGNLisusedtocallaction'smethods
>
>
This is good to know - might bite me again
Regards,
Christoph
This Email was scanned by Sophos Anti Virus
Re: Struts 2.3.18 ready for test
Posted by Lukasz Lenart <lu...@apache.org>.
2014-09-30 9:09 GMT+02:00 Lukasz Lenart <lu...@apache.org>:
> Added a note to docs (I thought there was one already) - in your case
> the problem is with a constructor, its target is evaluated to
> java.lang.Class which is on the excluded list of classes.
>
> https://cwiki.apache.org/confluence/display/WW/Security#Security-Internalsecuritymechanism
I have extended the description as there is one more case in which
application can blow up :-)
https://cwiki.apache.org/confluence/display/WW/Security#Security-OGNLisusedtocallaction'smethods
Regards
--
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Struts 2.3.18 ready for test
Posted by Christoph Nenning <Ch...@lex-com.net>.
> >> 1. OGNL security blocking (https://github.com/apache/struts/pull/11)
> >> I'm actually hit by this. So it means: it really works ;)
> >> I have JSPs that create a ViewModel Object with ognl which is blocked
now.
> >> (new is used in ognl expression)
> >> The question here is how to enable the new whitelist?
> >> There should be a link on the Version Notes page.
> >
> > Did you get a WARN in the logs?
Yes, exactly the message as in the wiki:
WARN opensymphony.xwork2.ognl.SecurityMemberAccess - Target class [class
my.package.MyClass] or declaring class of member type [public
my.package.MyClass(my.package.MyClass)] are excluded!
>
> Added a note to docs (I thought there was one already) - in your case
> the problem is with a constructor, its target is evaluated to
> java.lang.Class which is on the excluded list of classes.
>
> https://cwiki.apache.org/confluence/display/WW/Security#Security-
> Internalsecuritymechanism
>
>
Allowing java.lang.Class by removing it from struts.excludedClasses solved
it. But I will rather follow the advice in wiki and redesign :)
regards,
Christoph
This Email was scanned by Sophos Anti Virus
Re: Struts 2.3.18 ready for test
Posted by Lukasz Lenart <lu...@apache.org>.
2014-09-30 8:36 GMT+02:00 Lukasz Lenart <lu...@apache.org>:
> 2014-09-29 17:38 GMT+02:00 Christoph Nenning <Ch...@lex-com.net>:
>> 1. OGNL security blocking (https://github.com/apache/struts/pull/11)
>> I'm actually hit by this. So it means: it really works ;)
>> I have JSPs that create a ViewModel Object with ognl which is blocked now.
>> (new is used in ognl expression)
>> The question here is how to enable the new whitelist?
>> There should be a link on the Version Notes page.
>
> Did you get a WARN in the logs?
Added a note to docs (I thought there was one already) - in your case
the problem is with a constructor, its target is evaluated to
java.lang.Class which is on the excluded list of classes.
https://cwiki.apache.org/confluence/display/WW/Security#Security-Internalsecuritymechanism
Regards
--
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Struts 2.3.18 ready for test
Posted by Lukasz Lenart <lu...@apache.org>.
2014-09-29 17:38 GMT+02:00 Christoph Nenning <Ch...@lex-com.net>:
> 1. OGNL security blocking (https://github.com/apache/struts/pull/11)
> I'm actually hit by this. So it means: it really works ;)
> I have JSPs that create a ViewModel Object with ognl which is blocked now.
> (new is used in ognl expression)
> The question here is how to enable the new whitelist?
> There should be a link on the Version Notes page.
Did you get a WARN in the logs?
Regards
--
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Struts 2.3.18 ready for test
Posted by Christoph Nenning <Ch...@lex-com.net>.
> >
> > Should I create JIRAs for some of these?
>
> Yes, please - there is too many of them to keep track via mail :-)
>
>
As you have already seen:
https://issues.apache.org/jira/browse/WW-4407
https://issues.apache.org/jira/browse/WW-4408
regards,
Christoph
This Email was scanned by Sophos Anti Virus
Re: Struts 2.3.18 ready for test
Posted by Lukasz Lenart <lu...@apache.org>.
2014-09-29 17:38 GMT+02:00 Christoph Nenning <Ch...@lex-com.net>:
>> Hi,
>>
>> I have deployed new artefacts to staging repo, please test the bits!
>>
>> Staging Maven repo
>> https://repository.apache.org/content/groups/staging/
>>
>> Standalone artifacts
>> http://people.apache.org/builds/struts/2.3.18/
>>
>> Release notes
>> https://cwiki.apache.org/confluence/display/WW/Version+Notes+2.3.18
>>
>>
>> Thanks in advance
>> --
>> Łukasz
>> + 48 606 323 122 http://www.lenart.org.pl/
>>
>> ---------------------------------------------------------------------
>
>
> Hi,
>
>
> could already see some of my patches in action, yay :)
>
>
> I found some issues with our apps. Some stuff must be fixed there, but for
> other stuff i'm not sure whether it shall be fixed in the framework or the
> app.
>
>
>
> 1. OGNL security blocking (https://github.com/apache/struts/pull/11)
> I'm actually hit by this. So it means: it really works ;)
> I have JSPs that create a ViewModel Object with ognl which is blocked now.
> (new is used in ognl expression)
> The question here is how to enable the new whitelist?
> There should be a link on the Version Notes page.
>
>
> 2. LocalizedTextUtil
> Now I'm getting lots of WARN messages in log like this:
> WARN opensymphony.xwork2.util.LocalizedTextUtil - Missing key [...] in
> bundle [...]!
> In this app we use some JARs which provide their own resource bundles.
> Those messages appear while struts searches the bundles for the current
> key.
> Probably that is caused by WW-4379.
>
> Is there a way to set a default resource bundle? So that I don't need to
> specify a bundle everywhere.
>
>
>
> 3. LocaleProvider created by a ConfigurationProvider
> To deal with errors on file uploads we have a ConfigurationProvider that
> registers a LocaleProvider programmatically which is only used before the
> interceptor stack is executed.
> With struts 2.3.16 that LocaleProvider was only called once per request,
> now it is called all over the place (probably for each getText()).
> So it seems that the before-interceptor-stack-approach does not work
> anymore.
>
>
>
> 4. ActionContext.getContext().getSession()
> Again the ConfigurationProvider from point 3. It tries to access the
> HttpSession to figure out if the user has a language chosen.
> With struts 2.3.16 it returned always a map which may have been empty. Now
> we get null.
> That happens on the login page, so there might be no session yet.
>
>
>
> Should I create JIRAs for some of these?
Yes, please - there is too many of them to keep track via mail :-)
Regards
--
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Struts 2.3.18 ready for test
Posted by Christoph Nenning <Ch...@lex-com.net>.
> Hi,
>
> I have deployed new artefacts to staging repo, please test the bits!
>
> Staging Maven repo
> https://repository.apache.org/content/groups/staging/
>
> Standalone artifacts
> http://people.apache.org/builds/struts/2.3.18/
>
> Release notes
> https://cwiki.apache.org/confluence/display/WW/Version+Notes+2.3.18
>
>
> Thanks in advance
> --
> Łukasz
> + 48 606 323 122 http://www.lenart.org.pl/
>
> ---------------------------------------------------------------------
Hi,
could already see some of my patches in action, yay :)
I found some issues with our apps. Some stuff must be fixed there, but for
other stuff i'm not sure whether it shall be fixed in the framework or the
app.
1. OGNL security blocking (https://github.com/apache/struts/pull/11)
I'm actually hit by this. So it means: it really works ;)
I have JSPs that create a ViewModel Object with ognl which is blocked now.
(new is used in ognl expression)
The question here is how to enable the new whitelist?
There should be a link on the Version Notes page.
2. LocalizedTextUtil
Now I'm getting lots of WARN messages in log like this:
WARN opensymphony.xwork2.util.LocalizedTextUtil - Missing key [...] in
bundle [...]!
In this app we use some JARs which provide their own resource bundles.
Those messages appear while struts searches the bundles for the current
key.
Probably that is caused by WW-4379.
Is there a way to set a default resource bundle? So that I don't need to
specify a bundle everywhere.
3. LocaleProvider created by a ConfigurationProvider
To deal with errors on file uploads we have a ConfigurationProvider that
registers a LocaleProvider programmatically which is only used before the
interceptor stack is executed.
With struts 2.3.16 that LocaleProvider was only called once per request,
now it is called all over the place (probably for each getText()).
So it seems that the before-interceptor-stack-approach does not work
anymore.
4. ActionContext.getContext().getSession()
Again the ConfigurationProvider from point 3. It tries to access the
HttpSession to figure out if the user has a language chosen.
With struts 2.3.16 it returned always a map which may have been empty. Now
we get null.
That happens on the login page, so there might be no session yet.
Should I create JIRAs for some of these?
regards,
Christoph
This Email was scanned by Sophos Anti Virus
Re: Struts 2.3.18 ready for test
Posted by Greg Huber <gr...@gmail.com>.
....May need to add:
<updatePolicy>always</updatePolicy>
as changes may not be picked up.
On 28 September 2014 17:55, Lukasz Lenart <lu...@apache.org> wrote:
> 2014-09-28 3:18 GMT+02:00 Martin Gainty <mg...@hotmail.com>:
> >> Staging Maven repo
> >> https://repository.apache.org/content/groups/staging/
> >
> > https://repository.apache.org/content/groups/staging/org/apache/struts
> > ?
>
> Nope, it's too deep - the best option to use that repo is to define it
> inside your ~/.m2/settings.xml -
> http://maven.apache.org/settings.html#Repositories
>
> <profiles>
> <profile>
> <id>local</id>
> <activation>
> <activeByDefault>true</activeByDefault>
> </activation>
> <repositories>
> <repository>
> <id>apache-snapshots</id>
>
> <url>https://repository.apache.org/content/groups/snapshots/</url>
> <layout>default</layout>
> <snapshots>
> <enabled>true</enabled>
> </snapshots>
> </repository>
> <repository>
> <id>apache-staging</id>
>
> <url>https://repository.apache.org/content/groups/staging/</url>
> <layout>default</layout>
> <releases>
> <enabled>false</enabled>
> </releases>
> </repository>
> </repositories>
> </profile>
> </profiles>
>
>
> Regard
> --
> Łukasz
> + 48 606 323 122 http://www.lenart.org.pl/
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>
Re: Struts 2.3.18 ready for test
Posted by Lukasz Lenart <lu...@apache.org>.
2014-09-28 3:18 GMT+02:00 Martin Gainty <mg...@hotmail.com>:
>> Staging Maven repo
>> https://repository.apache.org/content/groups/staging/
>
> https://repository.apache.org/content/groups/staging/org/apache/struts
> ?
Nope, it's too deep - the best option to use that repo is to define it
inside your ~/.m2/settings.xml -
http://maven.apache.org/settings.html#Repositories
<profiles>
<profile>
<id>local</id>
<activation>
<activeByDefault>true</activeByDefault>
</activation>
<repositories>
<repository>
<id>apache-snapshots</id>
<url>https://repository.apache.org/content/groups/snapshots/</url>
<layout>default</layout>
<snapshots>
<enabled>true</enabled>
</snapshots>
</repository>
<repository>
<id>apache-staging</id>
<url>https://repository.apache.org/content/groups/staging/</url>
<layout>default</layout>
<releases>
<enabled>false</enabled>
</releases>
</repository>
</repositories>
</profile>
</profiles>
Regard
--
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
RE: Struts 2.3.18 ready for test
Posted by Martin Gainty <mg...@hotmail.com>.
> From: lukaszlenart@apache.org
> Date: Sat, 27 Sep 2014 11:01:44 +0200
> Subject: Re: Struts 2.3.18 ready for test
> To: dev@struts.apache.org
>
> Hi,
>
> I have deployed new artefacts to staging repo, please test the bits!
>
> Staging Maven repo
> https://repository.apache.org/content/groups/staging/
https://repository.apache.org/content/groups/staging/org/apache/struts
?
>
> Standalone artifacts
> http://people.apache.org/builds/struts/2.3.18/
>
> Release notes
> https://cwiki.apache.org/confluence/display/WW/Version+Notes+2.3.18
>
>
> Thanks in advance
> --
> Łukasz
> + 48 606 323 122 http://www.lenart.org.pl/
>Thank YOU
>Martin
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
Re: Struts 2.3.18 ready for test
Posted by Lukasz Lenart <lu...@apache.org>.
Hi,
I have deployed new artefacts to staging repo, please test the bits!
Staging Maven repo
https://repository.apache.org/content/groups/staging/
Standalone artifacts
http://people.apache.org/builds/struts/2.3.18/
Release notes
https://cwiki.apache.org/confluence/display/WW/Version+Notes+2.3.18
Thanks in advance
--
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Struts 2.3.18 ready for test
Posted by Lukasz Lenart <lu...@apache.org>.
2014-09-25 19:37 GMT+02:00 Johannes Geppert <jo...@apache.org>:
> Just tested with Struts2 jQuery Showcase.
> No problems so far, looks fine to me.
Great, thanks!
Anyone, any other obstacles? If not I will prepare a new build (during
weekend), call for test (whole week) and then vote.
Regards
--
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Struts 2.3.18 ready for test
Posted by Johannes Geppert <jo...@apache.org>.
Just tested with Struts2 jQuery Showcase.
No problems so far, looks fine to me.
Regards
Johannes
#################################################
web: http://www.jgeppert.com
twitter: http://twitter.com/jogep
2014-09-21 15:36 GMT+02:00 Lukasz Lenart <lu...@apache.org>:
> Hi,
>
> Please take a time and test the bits - any help is appreciated. Please
> report back any problems. I'll call for vote in a week if no problems
> will be spotted.
>
> Staging Maven repo
> https://repository.apache.org/content/groups/staging/
>
> Standalone artifacts
> http://people.apache.org/builds/struts/2.3.18/
>
> Release notes
> https://cwiki.apache.org/confluence/display/WW/Version+Notes+2.3.18
>
>
> Thanks in advance & regards
> --
> Łukasz
> + 48 606 323 122 http://www.lenart.org.pl/
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>
Re: Struts 2.3.18 ready for test
Posted by Lukasz Lenart <lu...@apache.org>.
2014-11-07 16:44 GMT+01:00 Volker Krebs <vo...@abas.de>:
> Yes my workaround was to directly exclude orderinfo param.
>
> I don't know if it is broken. But when the behavior of
> <param name="acceptParamNames">param1</param>
> should be to ignore every parameter but param1, then it's not working as
> expected.
Yeah, it's broken as this will open what was blocked previously :(
> I'll try to make a simple example on monday to test it.
Great! Thanks a lot!
Regards
--
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Struts 2.3.18 ready for test
Posted by Lukasz Lenart <lu...@apache.org>.
2014-11-13 14:40 GMT+01:00 Volker Krebs <vo...@abas.de>:
> Yes, thats good.
Great!
> I have extended my example a bit and will prepare a PR.
Great! Great!
Cheers
--
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Struts 2.3.18 ready for test
Posted by Volker Krebs <vo...@abas.de>.
Am 13.11.2014 um 11:22 schrieb Lukasz Lenart:
> 2014-11-13 10:57 GMT+01:00 Volker Krebs <vo...@abas.de>:
>> For exclude pattern I would use addExcludedPatterns and for accept patterns
>> I would use setAcceptedPatterns.
>> IMO, just by setting (adding) an exclude pattern it shouldn't be possible to
>> overwrite security relevant excludes.
>
> This is a good idea except this changes the previous behaviour -
> that's why I have reverted everything to not surprise users. We can
> think about that when I start working on 2.5
>
>> But I don't know exactly what the purpose of
>> DefaultAcceptedPatternsChecker.ACCEPTED_PATTERNS is. So I'm skating a bit on
>> thin ice here.
>
> Yeah... the same here :-)
>
> I assume this is good and works for you?
>
Yes, thats good.
I have extended my example a bit and will prepare a PR.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Struts 2.3.18 ready for test
Posted by Lukasz Lenart <lu...@apache.org>.
2014-11-13 10:57 GMT+01:00 Volker Krebs <vo...@abas.de>:
> For exclude pattern I would use addExcludedPatterns and for accept patterns
> I would use setAcceptedPatterns.
> IMO, just by setting (adding) an exclude pattern it shouldn't be possible to
> overwrite security relevant excludes.
This is a good idea except this changes the previous behaviour -
that's why I have reverted everything to not surprise users. We can
think about that when I start working on 2.5
> But I don't know exactly what the purpose of
> DefaultAcceptedPatternsChecker.ACCEPTED_PATTERNS is. So I'm skating a bit on
> thin ice here.
Yeah... the same here :-)
I assume this is good and works for you?
Regards
--
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Struts 2.3.18 ready for test
Posted by Volker Krebs <vo...@abas.de>.
Am 12.11.2014 um 13:40 schrieb Lukasz Lenart:
> 2014-11-12 13:25 GMT+01:00 Volker Krebs <vo...@abas.de>:
>> Am 12.11.2014 um 10:07 schrieb Lukasz Lenart:
>>>
>>> 2014-11-10 16:30 GMT+01:00 Volker Krebs <vo...@abas.de>:
>>>>
>>>> https://github.com/VolkerK/struts-examples/
>>>> branch develop
>>>
>>>
>>> Thanks a lot for the example, it was very helpful! Btw. you can
>>> prepare a PR to push it to the struts-example project :-)
>>>
>>> One remark, you cannot use such configuration:
>>>
>>> <interceptor-ref name="params">
>>> <param name="params">someParameter</param>
>>> </interceptor-ref>
>>> <interceptor-ref name="basicStack"/>
>>>
>>> as in such case params interceptor will run two times - first as a
>>> part of defaultStack and second time as a part of basicStack, you must
>>> use it that way
>>>
>>
>> Actually this is what I wanted to do. A couple of years ago I read somewhere
>> about the params - prepare - params approach.
>>
>> First set some paras that are required in the prepare method, and then after
>> prepare is finished set the some more params (and don't overwrite the ones
>> from the first params call).
>>
>> Ok that's probably too much of the domain (back-end) logic pressed into the
>> struts framework (workflow), but thats how I did it years ago when
>> I was naive and unexperienced :)
>
> Good to know, at least you know what you doing :-)
>
> Can I prepare new release, what do you think?
>
>
For exclude pattern I would use addExcludedPatterns and for accept
patterns I would use setAcceptedPatterns.
IMO, just by setting (adding) an exclude pattern it shouldn't be
possible to overwrite security relevant excludes.
But I don't know exactly what the purpose of
DefaultAcceptedPatternsChecker.ACCEPTED_PATTERNS is. So I'm skating a
bit on thin ice here.
Regards
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Struts 2.3.18 ready for test
Posted by Lukasz Lenart <lu...@apache.org>.
2014-11-12 13:25 GMT+01:00 Volker Krebs <vo...@abas.de>:
> Am 12.11.2014 um 10:07 schrieb Lukasz Lenart:
>>
>> 2014-11-10 16:30 GMT+01:00 Volker Krebs <vo...@abas.de>:
>>>
>>> https://github.com/VolkerK/struts-examples/
>>> branch develop
>>
>>
>> Thanks a lot for the example, it was very helpful! Btw. you can
>> prepare a PR to push it to the struts-example project :-)
>>
>> One remark, you cannot use such configuration:
>>
>> <interceptor-ref name="params">
>> <param name="params">someParameter</param>
>> </interceptor-ref>
>> <interceptor-ref name="basicStack"/>
>>
>> as in such case params interceptor will run two times - first as a
>> part of defaultStack and second time as a part of basicStack, you must
>> use it that way
>>
>
> Actually this is what I wanted to do. A couple of years ago I read somewhere
> about the params - prepare - params approach.
>
> First set some paras that are required in the prepare method, and then after
> prepare is finished set the some more params (and don't overwrite the ones
> from the first params call).
>
> Ok that's probably too much of the domain (back-end) logic pressed into the
> struts framework (workflow), but thats how I did it years ago when
> I was naive and unexperienced :)
Good to know, at least you know what you doing :-)
Can I prepare new release, what do you think?
Regards
--
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Struts 2.3.18 ready for test
Posted by Volker Krebs <vo...@abas.de>.
Am 12.11.2014 um 10:07 schrieb Lukasz Lenart:
> 2014-11-10 16:30 GMT+01:00 Volker Krebs <vo...@abas.de>:
>> https://github.com/VolkerK/struts-examples/
>> branch develop
>
> Thanks a lot for the example, it was very helpful! Btw. you can
> prepare a PR to push it to the struts-example project :-)
>
> One remark, you cannot use such configuration:
>
> <interceptor-ref name="params">
> <param name="params">someParameter</param>
> </interceptor-ref>
> <interceptor-ref name="basicStack"/>
>
> as in such case params interceptor will run two times - first as a
> part of defaultStack and second time as a part of basicStack, you must
> use it that way
>
Actually this is what I wanted to do. A couple of years ago I read
somewhere about the params - prepare - params approach.
First set some paras that are required in the prepare method, and then
after prepare is finished set the some more params (and don't overwrite
the ones from the first params call).
Ok that's probably too much of the domain (back-end) logic pressed into
the struts framework (workflow), but thats how I did it years ago when
I was naive and unexperienced :)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Struts 2.3.18 ready for test
Posted by Lukasz Lenart <lu...@apache.org>.
2014-11-10 16:30 GMT+01:00 Volker Krebs <vo...@abas.de>:
> https://github.com/VolkerK/struts-examples/
> branch develop
Thanks a lot for the example, it was very helpful! Btw. you can
prepare a PR to push it to the struts-example project :-)
One remark, you cannot use such configuration:
<interceptor-ref name="params">
<param name="params">someParameter</param>
</interceptor-ref>
<interceptor-ref name="basicStack"/>
as in such case params interceptor will run two times - first as a
part of defaultStack and second time as a part of basicStack, you must
use it that way
<interceptor-ref name="basicStack">
<param name="params.acceptParamNames">someParameter</param>
</interceptor-ref>
in such case, action will be executed with basicStack with modified
acceptParamNames
Regards
--
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Struts 2.3.18 ready for test
Posted by Volker Krebs <vo...@abas.de>.
Am 10.11.2014 um 11:38 schrieb Lukasz Lenart:
> 2014-11-10 11:35 GMT+01:00 Volker Krebs <vo...@abas.de>:
>> Am 10.11.2014 um 08:50 schrieb Lukasz Lenart:
>>>
>>> I've reverted changes regarding "acceptParamNames" - can you check
>>> with the latest snapshot?
>>>
>>
>> Looks like something is broken, acceptParamNames is applied to every action,
>> not just to the one where it is defined.
>>
>> At the moment I'm trying to extend the exclude_parameters example.
>
> That would be osm! as I cannot reproduce the behaviour with my examples.
>
https://github.com/VolkerK/struts-examples/
branch develop
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Struts 2.3.18 ready for test
Posted by Lukasz Lenart <lu...@apache.org>.
2014-11-10 11:35 GMT+01:00 Volker Krebs <vo...@abas.de>:
> Am 10.11.2014 um 08:50 schrieb Lukasz Lenart:
>>
>> I've reverted changes regarding "acceptParamNames" - can you check
>> with the latest snapshot?
>>
>
> Looks like something is broken, acceptParamNames is applied to every action,
> not just to the one where it is defined.
>
> At the moment I'm trying to extend the exclude_parameters example.
That would be osm! as I cannot reproduce the behaviour with my examples.
Regards
--
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Struts 2.3.18 ready for test
Posted by Volker Krebs <vo...@abas.de>.
Am 10.11.2014 um 08:50 schrieb Lukasz Lenart:
> I've reverted changes regarding "acceptParamNames" - can you check
> with the latest snapshot?
>
Looks like something is broken, acceptParamNames is applied to every
action, not just to the one where it is defined.
At the moment I'm trying to extend the exclude_parameters example.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Struts 2.3.18 ready for test
Posted by Lukasz Lenart <lu...@apache.org>.
I've reverted changes regarding "acceptParamNames" - can you check
with the latest snapshot?
Thanks in advance
--
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/
2014-11-07 16:44 GMT+01:00 Volker Krebs <vo...@abas.de>:
> Am 07.11.2014 um 16:34 schrieb Lukasz Lenart:
>
>> 2014-11-07 16:27 GMT+01:00 Volker Krebs <vo...@abas.de>:
>>>
>>> Ok, it has to do with the acceptParamNames in ParametersInterceptor
>>> I'll have the following config for my action:
>>> <interceptor-ref name="params">
>>> <param name="acceptParamNames">orderTimeID</param>
>>> </interceptor-ref>
>>>
>>> In my action I have a property named "orderinfo".
>>> In 2.3.16.3 the ParametersInterceptor only set "orderTimeID".
>>> Calls to "orderinfo" were blocked. This is what I was expecting, a pure
>>> white list approach, block everything which is not "orderTimeID".
>>>
>>> In 2.3.18 the ParametersInterceptor tried to set orderinfo. Only when
>>> explicitly excluding it, everything worked as before.
>>> <interceptor-ref name="params">
>>> <param name="acceptParamNames">orderTimeID</param>
>>> <param name="excludeParams">ordertime\..*</param>
>>> </interceptor-ref>
>>
>>
>> Does it mean you have workaround but excluding params mechanism is
>> broken? As I understand you had to directly exclude orderinfo param?
>>
>
> Yes my workaround was to directly exclude orderinfo param.
>
> I don't know if it is broken. But when the behavior of
> <param name="acceptParamNames">param1</param>
> should be to ignore every parameter but param1, then it's not working as
> expected.
>
> I'll try to make a simple example on monday to test it.
>
> Have a nice weekend :)
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Struts 2.3.18 ready for test
Posted by Volker Krebs <vo...@abas.de>.
Am 08.11.2014 um 17:49 schrieb Lukasz Lenart:
> 2014-11-07 16:44 GMT+01:00 Volker Krebs <vo...@abas.de>:
>> Yes my workaround was to directly exclude orderinfo param.
>>
>> I don't know if it is broken. But when the behavior of
>> <param name="acceptParamNames">param1</param>
>> should be to ignore every parameter but param1, then it's not working as
>> expected.
>
> I found where the problem is. Right now "acceptParamNames" are added
> to existing ACCEPTED_PATTERNS defined in
> DefaultAcceptedPatternsChecker - previously "acceptParamNames" were
> overriding default patterns from ACCEPTED_PATTERNS.
>
> You can still override the default patterns with
> "struts.override.excludedPatterns" and then use "acceptParamNames" to
> relax the those global patterns. Or you can implement your own version
> of AcceptedPatternsChecker.
>
> Basically I have to update docs about that. It was introduced by that
> PR -> https://github.com/apache/struts/pull/11
>
> The question is if this is a better solution? You have a lot of
> options to check accepted params but maybe it's too complicated? Let
> me know what you think.
>
>
My application was relying that certain parameters were blocked.
So adding global accept pattern could break backwards compatibility.
I think when defining acceptParamNames only those should be passed
to the action. Everything else should be blocked. (white list approach)
When not defining any acceptParamNames all parameters should be passed
except the ones in the excludedPatterns. (black list approach)
The black list approach is difficult, because you
will definitely forget some patterns. But a pure white list approach
would break a lot of applications. Because everybody must define the
parameters he needs.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Struts 2.3.18 ready for test
Posted by Lukasz Lenart <lu...@apache.org>.
2014-11-07 16:44 GMT+01:00 Volker Krebs <vo...@abas.de>:
> Yes my workaround was to directly exclude orderinfo param.
>
> I don't know if it is broken. But when the behavior of
> <param name="acceptParamNames">param1</param>
> should be to ignore every parameter but param1, then it's not working as
> expected.
I found where the problem is. Right now "acceptParamNames" are added
to existing ACCEPTED_PATTERNS defined in
DefaultAcceptedPatternsChecker - previously "acceptParamNames" were
overriding default patterns from ACCEPTED_PATTERNS.
You can still override the default patterns with
"struts.override.excludedPatterns" and then use "acceptParamNames" to
relax the those global patterns. Or you can implement your own version
of AcceptedPatternsChecker.
Basically I have to update docs about that. It was introduced by that
PR -> https://github.com/apache/struts/pull/11
The question is if this is a better solution? You have a lot of
options to check accepted params but maybe it's too complicated? Let
me know what you think.
Regards
--
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Struts 2.3.18 ready for test
Posted by Volker Krebs <vo...@abas.de>.
Am 07.11.2014 um 16:34 schrieb Lukasz Lenart:
> 2014-11-07 16:27 GMT+01:00 Volker Krebs <vo...@abas.de>:
>> Ok, it has to do with the acceptParamNames in ParametersInterceptor
>> I'll have the following config for my action:
>> <interceptor-ref name="params">
>> <param name="acceptParamNames">orderTimeID</param>
>> </interceptor-ref>
>>
>> In my action I have a property named "orderinfo".
>> In 2.3.16.3 the ParametersInterceptor only set "orderTimeID".
>> Calls to "orderinfo" were blocked. This is what I was expecting, a pure
>> white list approach, block everything which is not "orderTimeID".
>>
>> In 2.3.18 the ParametersInterceptor tried to set orderinfo. Only when
>> explicitly excluding it, everything worked as before.
>> <interceptor-ref name="params">
>> <param name="acceptParamNames">orderTimeID</param>
>> <param name="excludeParams">ordertime\..*</param>
>> </interceptor-ref>
>
> Does it mean you have workaround but excluding params mechanism is
> broken? As I understand you had to directly exclude orderinfo param?
>
Yes my workaround was to directly exclude orderinfo param.
I don't know if it is broken. But when the behavior of
<param name="acceptParamNames">param1</param>
should be to ignore every parameter but param1, then it's not working as
expected.
I'll try to make a simple example on monday to test it.
Have a nice weekend :)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Struts 2.3.18 ready for test
Posted by Lukasz Lenart <lu...@apache.org>.
2014-11-07 16:27 GMT+01:00 Volker Krebs <vo...@abas.de>:
> Ok, it has to do with the acceptParamNames in ParametersInterceptor
> I'll have the following config for my action:
> <interceptor-ref name="params">
> <param name="acceptParamNames">orderTimeID</param>
> </interceptor-ref>
>
> In my action I have a property named "orderinfo".
> In 2.3.16.3 the ParametersInterceptor only set "orderTimeID".
> Calls to "orderinfo" were blocked. This is what I was expecting, a pure
> white list approach, block everything which is not "orderTimeID".
>
> In 2.3.18 the ParametersInterceptor tried to set orderinfo. Only when
> explicitly excluding it, everything worked as before.
> <interceptor-ref name="params">
> <param name="acceptParamNames">orderTimeID</param>
> <param name="excludeParams">ordertime\..*</param>
> </interceptor-ref>
Does it mean you have workaround but excluding params mechanism is
broken? As I understand you had to directly exclude orderinfo param?
Regards
--
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Struts 2.3.18 ready for test
Posted by Volker Krebs <vo...@abas.de>.
Am 06.11.2014 um 18:09 schrieb Lukasz Lenart:
> 2014-11-06 18:00 GMT+01:00 Lukasz Lenart <lu...@apache.org>:
>> 2014-11-06 17:02 GMT+01:00 Volker Krebs <vo...@abas.de>:
>>> I still have an odd behavior and can't figure out what has changed from
>>> 2.3.16.3 to 2.3.18
>>> We have an Action with an service interface as class member.
>>> Something like this pseudo Action:
>>>
>>> public class EditAction extends ActionSupport implements Preparable {
>>>
>>> protected MyService myService;
>>>
>>> public void prepare() throws Exception {
>>> myService = new MyServiceImpl();
>>> }
>>>
>>> public String execute() throws Exception {
>>> myService.doSomething();
>>> }
>>> }
>>>
>>> In 2.3.16.3 this works fine.
>>> In 2.3.18 I get the following exception.
>>> As you can see from the stack trace we're using spring integration plugin.
>>>
>>>
>>> 2014-11-06 03:14:05,040 ERROR [http-bio-60123-exec-5]
>>> com.opensymphony.xwork2.conversion.impl.InstantiatingNullHandler - Could not
>>> create and/or set value back on to object
>>> org.springframework.beans.factory.BeanCreationException: Error creating bean
>>> with name 'com.mycompany.interfaces.MyService': Could not resolve matching
>>> constructor
>>> at
>>> org.springframework.beans.factory.support.ConstructorResolver.autowireConstructor(ConstructorResolver.java:238)
>>> at
>>> org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.autowireConstructor(AbstractAutowireCapableBeanFactory.java:925)
>>> at
>>> org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.autowire(AbstractAutowireCapableBeanFactory.java:308)
>>> at
>>> com.opensymphony.xwork2.spring.SpringObjectFactory.buildBean(SpringObjectFactory.java:194)
>>> at
>>> com.opensymphony.xwork2.conversion.impl.InstantiatingNullHandler.createObject(InstantiatingNullHandler.java:163)
>>> at
>>> com.opensymphony.xwork2.conversion.impl.InstantiatingNullHandler.nullPropertyValue(InstantiatingNullHandler.java:137)
>>> at
>>> com.opensymphony.xwork2.ognl.OgnlNullHandlerWrapper.nullPropertyValue(OgnlNullHandlerWrapper.java:21)
>>> at ognl.ASTProperty.getValueBody(ASTProperty.java:118)
>>> at ognl.SimpleNode.evaluateGetValueBody(SimpleNode.java:212)
>>> at ognl.SimpleNode.getValue(SimpleNode.java:258)
>>> at ognl.ASTChain.setValueBody(ASTChain.java:222)
>>> at ognl.SimpleNode.evaluateSetValueBody(SimpleNode.java:220)
>>> at ognl.SimpleNode.setValue(SimpleNode.java:301)
>>> at ognl.Ognl.setValue(Ognl.java:737)
>>> at
>>> com.opensymphony.xwork2.ognl.OgnlUtil$1.execute(OgnlUtil.java:287)
>>> at
>>> com.opensymphony.xwork2.ognl.OgnlUtil$1.execute(OgnlUtil.java:282)
>>> at
>>> com.opensymphony.xwork2.ognl.OgnlUtil.compileAndExecute(OgnlUtil.java:340)
>>> at com.opensymphony.xwork2.ognl.OgnlUtil.setValue(OgnlUtil.java:282)
>>> at
>>> com.opensymphony.xwork2.ognl.OgnlValueStack.trySetValue(OgnlValueStack.java:185)
>>> at
>>> com.opensymphony.xwork2.ognl.OgnlValueStack.setValue(OgnlValueStack.java:172)
>>> at
>>> com.opensymphony.xwork2.ognl.OgnlValueStack.setParameter(OgnlValueStack.java:150)
>>> at
>>> com.opensymphony.xwork2.interceptor.ParametersInterceptor.setParameters(ParametersInterceptor.java:309)
>>> at
>>> com.opensymphony.xwork2.interceptor.ParametersInterceptor.doIntercept(ParametersInterceptor.java:227)
>>> at
>>> com.opensymphony.xwork2.interceptor.MethodFilterInterceptor.intercept(MethodFilterInterceptor.java:98)
>>> at
>>> com.opensymphony.xwork2.DefaultActionInvocation.invoke(DefaultActionInvocation.java:244)
>>> at
>>> org.apache.struts2.impl.StrutsActionProxy.execute(StrutsActionProxy.java:54)
>>> at
>>> org.apache.struts2.dispatcher.Dispatcher.serviceAction(Dispatcher.java:564)
>>> at
>>> org.apache.struts2.dispatcher.ng.ExecuteOperations.executeAction(ExecuteOperations.java:81)
>>> at
>>> org.apache.struts2.dispatcher.ng.filter.StrutsPrepareAndExecuteFilter.doFilter(StrutsPrepareAndExecuteFilter.java:99)
>>> at
>>> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:241)
>>> at
>>> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:208)
>>>
>>>
>>> Any Ideas ?
>>
>> Nope :( I was digging around but I don't see anything special. Can you
>> prepare a demo app or post more data?
>
> Just note that the exception is logged in InstantiatingNullHandler
> when it tries to create an object which is null and on which you want
> set a value
>
Ok, it has to do with the acceptParamNames in ParametersInterceptor
I'll have the following config for my action:
<interceptor-ref name="params">
<param name="acceptParamNames">orderTimeID</param>
</interceptor-ref>
In my action I have a property named "orderinfo".
In 2.3.16.3 the ParametersInterceptor only set "orderTimeID".
Calls to "orderinfo" were blocked. This is what I was expecting, a pure
white list approach, block everything which is not "orderTimeID".
In 2.3.18 the ParametersInterceptor tried to set orderinfo. Only when
explicitly excluding it, everything worked as before.
<interceptor-ref name="params">
<param name="acceptParamNames">orderTimeID</param>
<param name="excludeParams">ordertime\..*</param>
</interceptor-ref>
Regards
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Struts 2.3.18 ready for test
Posted by Lukasz Lenart <lu...@apache.org>.
2014-11-07 8:16 GMT+01:00 Volker Krebs <vo...@abas.de>:
> I'm using a params, prepare, params interceptor stack.
> The member "myService" (from the example above) is null
> and the parameter interceptor tries to initialize it.
> Trying to instantiate the Interface.
But it's using Spring to do that, does it mean that this service isn't
defined in Spring context? Also it means that the parameter's value is
set on the service?
> Is it possible to set ReflectionContextState#CREATE_NULL_OBJECTS to false
> via struts config ? This would help.
Rather no, I don't such possibility right now
> But I'm also trying to prepare a small example, since this might be an
> update issue from 2.3.16.3 to 2.3.18
The only change in that area is this and you already posted a comment
(I assumed it as confirmation that this works as expected)
https://issues.apache.org/jira/browse/WW-3603
Please prepare such demo app as I cannot reproduce it locally based on
your example code.
Regards
--
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Struts 2.3.18 ready for test
Posted by Volker Krebs <vo...@abas.de>.
Am 06.11.2014 um 18:09 schrieb Lukasz Lenart:
> 2014-11-06 18:00 GMT+01:00 Lukasz Lenart <lu...@apache.org>:
>> 2014-11-06 17:02 GMT+01:00 Volker Krebs <vo...@abas.de>:
>>> I still have an odd behavior and can't figure out what has changed from
>>> 2.3.16.3 to 2.3.18
>>> We have an Action with an service interface as class member.
>>> Something like this pseudo Action:
>>>
>>> public class EditAction extends ActionSupport implements Preparable {
>>>
>>> protected MyService myService;
>>>
>>> public void prepare() throws Exception {
>>> myService = new MyServiceImpl();
>>> }
>>>
>>> public String execute() throws Exception {
>>> myService.doSomething();
>>> }
>>> }
>>>
>>> In 2.3.16.3 this works fine.
>>> In 2.3.18 I get the following exception.
>>> As you can see from the stack trace we're using spring integration plugin.
>>>
>>>
>>> 2014-11-06 03:14:05,040 ERROR [http-bio-60123-exec-5]
>>> com.opensymphony.xwork2.conversion.impl.InstantiatingNullHandler - Could not
>>> create and/or set value back on to object
>>> org.springframework.beans.factory.BeanCreationException: Error creating bean
>>> with name 'com.mycompany.interfaces.MyService': Could not resolve matching
>>> constructor
>>> at
>>> org.springframework.beans.factory.support.ConstructorResolver.autowireConstructor(ConstructorResolver.java:238)
>>> at
>>> org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.autowireConstructor(AbstractAutowireCapableBeanFactory.java:925)
>>> at
>>> org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.autowire(AbstractAutowireCapableBeanFactory.java:308)
>>> at
>>> com.opensymphony.xwork2.spring.SpringObjectFactory.buildBean(SpringObjectFactory.java:194)
>>> at
>>> com.opensymphony.xwork2.conversion.impl.InstantiatingNullHandler.createObject(InstantiatingNullHandler.java:163)
>>> at
>>> com.opensymphony.xwork2.conversion.impl.InstantiatingNullHandler.nullPropertyValue(InstantiatingNullHandler.java:137)
>>> at
>>> com.opensymphony.xwork2.ognl.OgnlNullHandlerWrapper.nullPropertyValue(OgnlNullHandlerWrapper.java:21)
>>> at ognl.ASTProperty.getValueBody(ASTProperty.java:118)
>>> at ognl.SimpleNode.evaluateGetValueBody(SimpleNode.java:212)
>>> at ognl.SimpleNode.getValue(SimpleNode.java:258)
>>> at ognl.ASTChain.setValueBody(ASTChain.java:222)
>>> at ognl.SimpleNode.evaluateSetValueBody(SimpleNode.java:220)
>>> at ognl.SimpleNode.setValue(SimpleNode.java:301)
>>> at ognl.Ognl.setValue(Ognl.java:737)
>>> at
>>> com.opensymphony.xwork2.ognl.OgnlUtil$1.execute(OgnlUtil.java:287)
>>> at
>>> com.opensymphony.xwork2.ognl.OgnlUtil$1.execute(OgnlUtil.java:282)
>>> at
>>> com.opensymphony.xwork2.ognl.OgnlUtil.compileAndExecute(OgnlUtil.java:340)
>>> at com.opensymphony.xwork2.ognl.OgnlUtil.setValue(OgnlUtil.java:282)
>>> at
>>> com.opensymphony.xwork2.ognl.OgnlValueStack.trySetValue(OgnlValueStack.java:185)
>>> at
>>> com.opensymphony.xwork2.ognl.OgnlValueStack.setValue(OgnlValueStack.java:172)
>>> at
>>> com.opensymphony.xwork2.ognl.OgnlValueStack.setParameter(OgnlValueStack.java:150)
>>> at
>>> com.opensymphony.xwork2.interceptor.ParametersInterceptor.setParameters(ParametersInterceptor.java:309)
>>> at
>>> com.opensymphony.xwork2.interceptor.ParametersInterceptor.doIntercept(ParametersInterceptor.java:227)
>>> at
>>> com.opensymphony.xwork2.interceptor.MethodFilterInterceptor.intercept(MethodFilterInterceptor.java:98)
>>> at
>>> com.opensymphony.xwork2.DefaultActionInvocation.invoke(DefaultActionInvocation.java:244)
>>> at
>>> org.apache.struts2.impl.StrutsActionProxy.execute(StrutsActionProxy.java:54)
>>> at
>>> org.apache.struts2.dispatcher.Dispatcher.serviceAction(Dispatcher.java:564)
>>> at
>>> org.apache.struts2.dispatcher.ng.ExecuteOperations.executeAction(ExecuteOperations.java:81)
>>> at
>>> org.apache.struts2.dispatcher.ng.filter.StrutsPrepareAndExecuteFilter.doFilter(StrutsPrepareAndExecuteFilter.java:99)
>>> at
>>> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:241)
>>> at
>>> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:208)
>>>
>>>
>>> Any Ideas ?
>>
>> Nope :( I was digging around but I don't see anything special. Can you
>> prepare a demo app or post more data?
>
> Just note that the exception is logged in InstantiatingNullHandler
> when it tries to create an object which is null and on which you want
> set a value
I'm using a params, prepare, params interceptor stack.
The member "myService" (from the example above) is null
and the parameter interceptor tries to initialize it.
Trying to instantiate the Interface.
Is it possible to set ReflectionContextState#CREATE_NULL_OBJECTS to
false via struts config ? This would help.
But I'm also trying to prepare a small example, since this might be an
update issue from 2.3.16.3 to 2.3.18
Regards
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Struts 2.3.18 ready for test
Posted by Lukasz Lenart <lu...@apache.org>.
2014-11-06 18:00 GMT+01:00 Lukasz Lenart <lu...@apache.org>:
> 2014-11-06 17:02 GMT+01:00 Volker Krebs <vo...@abas.de>:
>> I still have an odd behavior and can't figure out what has changed from
>> 2.3.16.3 to 2.3.18
>> We have an Action with an service interface as class member.
>> Something like this pseudo Action:
>>
>> public class EditAction extends ActionSupport implements Preparable {
>>
>> protected MyService myService;
>>
>> public void prepare() throws Exception {
>> myService = new MyServiceImpl();
>> }
>>
>> public String execute() throws Exception {
>> myService.doSomething();
>> }
>> }
>>
>> In 2.3.16.3 this works fine.
>> In 2.3.18 I get the following exception.
>> As you can see from the stack trace we're using spring integration plugin.
>>
>>
>> 2014-11-06 03:14:05,040 ERROR [http-bio-60123-exec-5]
>> com.opensymphony.xwork2.conversion.impl.InstantiatingNullHandler - Could not
>> create and/or set value back on to object
>> org.springframework.beans.factory.BeanCreationException: Error creating bean
>> with name 'com.mycompany.interfaces.MyService': Could not resolve matching
>> constructor
>> at
>> org.springframework.beans.factory.support.ConstructorResolver.autowireConstructor(ConstructorResolver.java:238)
>> at
>> org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.autowireConstructor(AbstractAutowireCapableBeanFactory.java:925)
>> at
>> org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.autowire(AbstractAutowireCapableBeanFactory.java:308)
>> at
>> com.opensymphony.xwork2.spring.SpringObjectFactory.buildBean(SpringObjectFactory.java:194)
>> at
>> com.opensymphony.xwork2.conversion.impl.InstantiatingNullHandler.createObject(InstantiatingNullHandler.java:163)
>> at
>> com.opensymphony.xwork2.conversion.impl.InstantiatingNullHandler.nullPropertyValue(InstantiatingNullHandler.java:137)
>> at
>> com.opensymphony.xwork2.ognl.OgnlNullHandlerWrapper.nullPropertyValue(OgnlNullHandlerWrapper.java:21)
>> at ognl.ASTProperty.getValueBody(ASTProperty.java:118)
>> at ognl.SimpleNode.evaluateGetValueBody(SimpleNode.java:212)
>> at ognl.SimpleNode.getValue(SimpleNode.java:258)
>> at ognl.ASTChain.setValueBody(ASTChain.java:222)
>> at ognl.SimpleNode.evaluateSetValueBody(SimpleNode.java:220)
>> at ognl.SimpleNode.setValue(SimpleNode.java:301)
>> at ognl.Ognl.setValue(Ognl.java:737)
>> at
>> com.opensymphony.xwork2.ognl.OgnlUtil$1.execute(OgnlUtil.java:287)
>> at
>> com.opensymphony.xwork2.ognl.OgnlUtil$1.execute(OgnlUtil.java:282)
>> at
>> com.opensymphony.xwork2.ognl.OgnlUtil.compileAndExecute(OgnlUtil.java:340)
>> at com.opensymphony.xwork2.ognl.OgnlUtil.setValue(OgnlUtil.java:282)
>> at
>> com.opensymphony.xwork2.ognl.OgnlValueStack.trySetValue(OgnlValueStack.java:185)
>> at
>> com.opensymphony.xwork2.ognl.OgnlValueStack.setValue(OgnlValueStack.java:172)
>> at
>> com.opensymphony.xwork2.ognl.OgnlValueStack.setParameter(OgnlValueStack.java:150)
>> at
>> com.opensymphony.xwork2.interceptor.ParametersInterceptor.setParameters(ParametersInterceptor.java:309)
>> at
>> com.opensymphony.xwork2.interceptor.ParametersInterceptor.doIntercept(ParametersInterceptor.java:227)
>> at
>> com.opensymphony.xwork2.interceptor.MethodFilterInterceptor.intercept(MethodFilterInterceptor.java:98)
>> at
>> com.opensymphony.xwork2.DefaultActionInvocation.invoke(DefaultActionInvocation.java:244)
>> at
>> org.apache.struts2.impl.StrutsActionProxy.execute(StrutsActionProxy.java:54)
>> at
>> org.apache.struts2.dispatcher.Dispatcher.serviceAction(Dispatcher.java:564)
>> at
>> org.apache.struts2.dispatcher.ng.ExecuteOperations.executeAction(ExecuteOperations.java:81)
>> at
>> org.apache.struts2.dispatcher.ng.filter.StrutsPrepareAndExecuteFilter.doFilter(StrutsPrepareAndExecuteFilter.java:99)
>> at
>> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:241)
>> at
>> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:208)
>>
>>
>> Any Ideas ?
>
> Nope :( I was digging around but I don't see anything special. Can you
> prepare a demo app or post more data?
Just note that the exception is logged in InstantiatingNullHandler
when it tries to create an object which is null and on which you want
set a value
Regards
--
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Struts 2.3.18 ready for test
Posted by Lukasz Lenart <lu...@apache.org>.
2014-11-06 17:02 GMT+01:00 Volker Krebs <vo...@abas.de>:
> I still have an odd behavior and can't figure out what has changed from
> 2.3.16.3 to 2.3.18
> We have an Action with an service interface as class member.
> Something like this pseudo Action:
>
> public class EditAction extends ActionSupport implements Preparable {
>
> protected MyService myService;
>
> public void prepare() throws Exception {
> myService = new MyServiceImpl();
> }
>
> public String execute() throws Exception {
> myService.doSomething();
> }
> }
>
> In 2.3.16.3 this works fine.
> In 2.3.18 I get the following exception.
> As you can see from the stack trace we're using spring integration plugin.
>
>
> 2014-11-06 03:14:05,040 ERROR [http-bio-60123-exec-5]
> com.opensymphony.xwork2.conversion.impl.InstantiatingNullHandler - Could not
> create and/or set value back on to object
> org.springframework.beans.factory.BeanCreationException: Error creating bean
> with name 'com.mycompany.interfaces.MyService': Could not resolve matching
> constructor
> at
> org.springframework.beans.factory.support.ConstructorResolver.autowireConstructor(ConstructorResolver.java:238)
> at
> org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.autowireConstructor(AbstractAutowireCapableBeanFactory.java:925)
> at
> org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.autowire(AbstractAutowireCapableBeanFactory.java:308)
> at
> com.opensymphony.xwork2.spring.SpringObjectFactory.buildBean(SpringObjectFactory.java:194)
> at
> com.opensymphony.xwork2.conversion.impl.InstantiatingNullHandler.createObject(InstantiatingNullHandler.java:163)
> at
> com.opensymphony.xwork2.conversion.impl.InstantiatingNullHandler.nullPropertyValue(InstantiatingNullHandler.java:137)
> at
> com.opensymphony.xwork2.ognl.OgnlNullHandlerWrapper.nullPropertyValue(OgnlNullHandlerWrapper.java:21)
> at ognl.ASTProperty.getValueBody(ASTProperty.java:118)
> at ognl.SimpleNode.evaluateGetValueBody(SimpleNode.java:212)
> at ognl.SimpleNode.getValue(SimpleNode.java:258)
> at ognl.ASTChain.setValueBody(ASTChain.java:222)
> at ognl.SimpleNode.evaluateSetValueBody(SimpleNode.java:220)
> at ognl.SimpleNode.setValue(SimpleNode.java:301)
> at ognl.Ognl.setValue(Ognl.java:737)
> at
> com.opensymphony.xwork2.ognl.OgnlUtil$1.execute(OgnlUtil.java:287)
> at
> com.opensymphony.xwork2.ognl.OgnlUtil$1.execute(OgnlUtil.java:282)
> at
> com.opensymphony.xwork2.ognl.OgnlUtil.compileAndExecute(OgnlUtil.java:340)
> at com.opensymphony.xwork2.ognl.OgnlUtil.setValue(OgnlUtil.java:282)
> at
> com.opensymphony.xwork2.ognl.OgnlValueStack.trySetValue(OgnlValueStack.java:185)
> at
> com.opensymphony.xwork2.ognl.OgnlValueStack.setValue(OgnlValueStack.java:172)
> at
> com.opensymphony.xwork2.ognl.OgnlValueStack.setParameter(OgnlValueStack.java:150)
> at
> com.opensymphony.xwork2.interceptor.ParametersInterceptor.setParameters(ParametersInterceptor.java:309)
> at
> com.opensymphony.xwork2.interceptor.ParametersInterceptor.doIntercept(ParametersInterceptor.java:227)
> at
> com.opensymphony.xwork2.interceptor.MethodFilterInterceptor.intercept(MethodFilterInterceptor.java:98)
> at
> com.opensymphony.xwork2.DefaultActionInvocation.invoke(DefaultActionInvocation.java:244)
> at
> org.apache.struts2.impl.StrutsActionProxy.execute(StrutsActionProxy.java:54)
> at
> org.apache.struts2.dispatcher.Dispatcher.serviceAction(Dispatcher.java:564)
> at
> org.apache.struts2.dispatcher.ng.ExecuteOperations.executeAction(ExecuteOperations.java:81)
> at
> org.apache.struts2.dispatcher.ng.filter.StrutsPrepareAndExecuteFilter.doFilter(StrutsPrepareAndExecuteFilter.java:99)
> at
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:241)
> at
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:208)
>
>
> Any Ideas ?
Nope :( I was digging around but I don't see anything special. Can you
prepare a demo app or post more data?
Regards
--
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Struts 2.3.18 ready for test
Posted by Volker Krebs <vo...@abas.de>.
I still have an odd behavior and can't figure out what has changed from
2.3.16.3 to 2.3.18
We have an Action with an service interface as class member.
Something like this pseudo Action:
public class EditAction extends ActionSupport implements Preparable {
protected MyService myService;
public void prepare() throws Exception {
myService = new MyServiceImpl();
}
public String execute() throws Exception {
myService.doSomething();
}
}
In 2.3.16.3 this works fine.
In 2.3.18 I get the following exception.
As you can see from the stack trace we're using spring integration plugin.
2014-11-06 03:14:05,040 ERROR [http-bio-60123-exec-5]
com.opensymphony.xwork2.conversion.impl.InstantiatingNullHandler - Could
not create and/or set value back on to object
org.springframework.beans.factory.BeanCreationException: Error creating
bean with name 'com.mycompany.interfaces.MyService': Could not resolve
matching constructor
at
org.springframework.beans.factory.support.ConstructorResolver.autowireConstructor(ConstructorResolver.java:238)
at
org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.autowireConstructor(AbstractAutowireCapableBeanFactory.java:925)
at
org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.autowire(AbstractAutowireCapableBeanFactory.java:308)
at
com.opensymphony.xwork2.spring.SpringObjectFactory.buildBean(SpringObjectFactory.java:194)
at
com.opensymphony.xwork2.conversion.impl.InstantiatingNullHandler.createObject(InstantiatingNullHandler.java:163)
at
com.opensymphony.xwork2.conversion.impl.InstantiatingNullHandler.nullPropertyValue(InstantiatingNullHandler.java:137)
at
com.opensymphony.xwork2.ognl.OgnlNullHandlerWrapper.nullPropertyValue(OgnlNullHandlerWrapper.java:21)
at ognl.ASTProperty.getValueBody(ASTProperty.java:118)
at ognl.SimpleNode.evaluateGetValueBody(SimpleNode.java:212)
at ognl.SimpleNode.getValue(SimpleNode.java:258)
at ognl.ASTChain.setValueBody(ASTChain.java:222)
at ognl.SimpleNode.evaluateSetValueBody(SimpleNode.java:220)
at ognl.SimpleNode.setValue(SimpleNode.java:301)
at ognl.Ognl.setValue(Ognl.java:737)
at com.opensymphony.xwork2.ognl.OgnlUtil$1.execute(OgnlUtil.java:287)
at com.opensymphony.xwork2.ognl.OgnlUtil$1.execute(OgnlUtil.java:282)
at
com.opensymphony.xwork2.ognl.OgnlUtil.compileAndExecute(OgnlUtil.java:340)
at com.opensymphony.xwork2.ognl.OgnlUtil.setValue(OgnlUtil.java:282)
at
com.opensymphony.xwork2.ognl.OgnlValueStack.trySetValue(OgnlValueStack.java:185)
at
com.opensymphony.xwork2.ognl.OgnlValueStack.setValue(OgnlValueStack.java:172)
at
com.opensymphony.xwork2.ognl.OgnlValueStack.setParameter(OgnlValueStack.java:150)
at
com.opensymphony.xwork2.interceptor.ParametersInterceptor.setParameters(ParametersInterceptor.java:309)
at
com.opensymphony.xwork2.interceptor.ParametersInterceptor.doIntercept(ParametersInterceptor.java:227)
at
com.opensymphony.xwork2.interceptor.MethodFilterInterceptor.intercept(MethodFilterInterceptor.java:98)
at
com.opensymphony.xwork2.DefaultActionInvocation.invoke(DefaultActionInvocation.java:244)
at
org.apache.struts2.impl.StrutsActionProxy.execute(StrutsActionProxy.java:54)
at
org.apache.struts2.dispatcher.Dispatcher.serviceAction(Dispatcher.java:564)
at
org.apache.struts2.dispatcher.ng.ExecuteOperations.executeAction(ExecuteOperations.java:81)
at
org.apache.struts2.dispatcher.ng.filter.StrutsPrepareAndExecuteFilter.doFilter(StrutsPrepareAndExecuteFilter.java:99)
at
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:241)
at
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:208)
Any Ideas ?
Thanks
Volker
Am 21.09.2014 um 15:36 schrieb Lukasz Lenart:
> Hi,
>
> Please take a time and test the bits - any help is appreciated. Please
> report back any problems. I'll call for vote in a week if no problems
> will be spotted.
>
> Staging Maven repo
> https://repository.apache.org/content/groups/staging/
>
> Standalone artifacts
> http://people.apache.org/builds/struts/2.3.18/
>
> Release notes
> https://cwiki.apache.org/confluence/display/WW/Version+Notes+2.3.18
>
>
> Thanks in advance & regards
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org