You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@drill.apache.org by "Paul Rogers (JIRA)" <ji...@apache.org> on 2017/06/20 02:10:01 UTC

[jira] [Created] (DRILL-5597) Incorrect "bits" vector allocation in nullable vectors allocateNew()

Paul Rogers created DRILL-5597:
----------------------------------

             Summary: Incorrect "bits" vector allocation in nullable vectors allocateNew()
                 Key: DRILL-5597
                 URL: https://issues.apache.org/jira/browse/DRILL-5597
             Project: Apache Drill
          Issue Type: Bug
    Affects Versions: 1.10.0
            Reporter: Paul Rogers
            Assignee: Paul Rogers
            Priority: Minor
             Fix For: 1.11.0


Consider the following code in a generated nullable vector, such as {{NullableBigIntVector}}:

{code}
  public void allocateNew(int valueCount) {
    try {
      values.allocateNew(valueCount);
      bits.allocateNew(valueCount+1);
{code}

There are as may "bits" entries as data entries, no need to allocate an extra 1. When the {{valueCount}} is a power of two, the error will cause the allocation of twice as large a vector as necessary. (128K, say, instead of 64K, since 64K+1 power-of-two rounds to 128K.)

By contrast the +1 correction is needed for offset vectors, but the "bits" vector is not an offset vector.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)