You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "Copilot (via GitHub)" <gi...@apache.org> on 2026/06/01 03:57:02 UTC
Re: [PR] feat(mcp): add list_reports and get_report_info tools [superset]
Copilot commented on code in PR #40348:
URL: https://github.com/apache/superset/pull/40348#discussion_r3331578131
##########
superset/mcp_service/common/schema_discovery.py:
##########
@@ -714,3 +746,83 @@ def get_theme_columns() -> list[ColumnMetadata]:
THEME_DEFAULT_COLUMNS,
exclude_columns=set(USER_DIRECTORY_FIELDS),
)
+
+
+def get_report_columns() -> list[ColumnMetadata]:
+ """Get column metadata for ReportSchedule model dynamically."""
+ from superset.reports.models import ReportSchedule
+
+ return get_columns_from_model(
+ ReportSchedule,
+ REPORT_DEFAULT_COLUMNS,
+ REPORT_EXTRA_COLUMNS,
+ exclude_columns=set(USER_DIRECTORY_FIELDS),
+ )
Review Comment:
`get_report_columns()` is defined but not used anywhere in the codebase. The schema tool wires up `get_report_info_columns()` (the ReportInfo-derived variant) instead, and no other call site references this helper. Consider removing it to avoid dead code, or wire it into a caller that needs the ORM-derived column set.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org