You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Andrew Phillips <no...@github.com> on 2014/08/20 06:21:42 UTC
[jclouds-karaf] Using ServiceMix bundle for jsch-agentproxy-sshj
(#53)
This should work now that [SMX4-1749](https://issues.apache.org/jira/browse/SMX4-1749) is closed...
You can merge this Pull Request by running:
git pull https://github.com/jclouds/jclouds-karaf sshj-agentproxy-bundle
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds-karaf/pull/53
-- Commit Summary --
* Using ServiceMix bundle for jsch-agentproxy-sshj
-- File Changes --
M feature/src/main/resources/feature.xml (3)
M pom.xml (6)
-- Patch Links --
https://github.com/jclouds/jclouds-karaf/pull/53.patch
https://github.com/jclouds/jclouds-karaf/pull/53.diff
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/53
Re: [jclouds-karaf] Using ServiceMix bundle for jsch-agentproxy-sshj
(#53)
Posted by Andrew Phillips <no...@github.com>.
@ccustine: Quick ping to see if someone else can take a quick look..?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/53#issuecomment-52925276
Re: [jclouds-karaf] Using ServiceMix bundle for jsch-agentproxy-sshj
(#53)
Posted by Chris Custine <no...@github.com>.
> @@ -202,6 +202,7 @@ limitations under the License.
> <joda.version>2.1</joda.version>
> <jsch.bundle.version>0.1.44_2</jsch.bundle.version>
> <jsch.agentproxy.version>0.0.7</jsch.agentproxy.version>
> + <jsch.agentproxy.bundle.version>${jsch.agentproxy.version}_2</jsch.agentproxy.bundle.version>
...and I stand corrected, it IS used elsewhere so disregard my statement :-)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/53/files#r16561353
Re: [jclouds-karaf] Using ServiceMix bundle for jsch-agentproxy-sshj
(#53)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-karaf-pull-requests #85](https://jclouds.ci.cloudbees.com/job/jclouds-karaf-pull-requests/85/) UNSTABLE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/53#issuecomment-52736391
Re: [jclouds-karaf] Using ServiceMix bundle for jsch-agentproxy-sshj
(#53)
Posted by Andrew Phillips <no...@github.com>.
Reopened #53.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/53#event-155275317
Re: [jclouds-karaf] Using ServiceMix bundle for jsch-agentproxy-sshj
(#53)
Posted by Andrew Phillips <no...@github.com>.
> jclouds-karaf-pull-requests #85 UNSTABLE
Some real [test failures](https://jclouds.ci.cloudbees.com/job/jclouds-karaf-pull-requests/lastBuild/testReport/), but not sure how/if they're really related to the PR, especially since the BuildHive build was fine.
Let's bounce once and see...
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/53#issuecomment-52850819
Re: [jclouds-karaf] Using ServiceMix bundle for jsch-agentproxy-sshj
(#53)
Posted by Andrew Phillips <no...@github.com>.
Committed to [master](https://git-wip-us.apache.org/repos/asf?p=jclouds-karaf.git;a=commit;h=d5976d69b9719b6a1c1b96e267c10cb237c4080b)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/53#issuecomment-52987762
Re: [jclouds-karaf] Using ServiceMix bundle for jsch-agentproxy-sshj
(#53)
Posted by Chris Custine <no...@github.com>.
> @@ -202,6 +202,7 @@ limitations under the License.
> <joda.version>2.1</joda.version>
> <jsch.bundle.version>0.1.44_2</jsch.bundle.version>
> <jsch.agentproxy.version>0.0.7</jsch.agentproxy.version>
> + <jsch.agentproxy.bundle.version>${jsch.agentproxy.version}_2</jsch.agentproxy.bundle.version>
+1 with the following caveat: This could bite you later if someone doesn't understand the relationship between the version for the plain jar file and the servicemix repackaged osgi bundle. ie if they increment to 0.0.8 and wonder why the build suddenly fails on the org.apache.servicemix.bundles dependency 0.0.8_2. I see the precedent for doing this already existed, but I prefer to keep it straight forward like it is a few lines above with jsch.bundle.version since the bare 0.0.7 isn't even used for anything else after this patch. Not a big deal though, and maybe I can propose this during my cleanup of jclouds-cli and jclouds-karaf too.
btw, if you come across anything like this down the road, let me know and I can push fixes for servicemix.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/53/files#r16561237
Re: [jclouds-karaf] Using ServiceMix bundle for jsch-agentproxy-sshj
(#53)
Posted by Andrew Phillips <no...@github.com>.
Closed #53.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/53#event-155804364
Re: [jclouds-karaf] Using ServiceMix bundle for jsch-agentproxy-sshj
(#53)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-karaf-pull-requests #86](https://jclouds.ci.cloudbees.com/job/jclouds-karaf-pull-requests/86/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/53#issuecomment-52857442
Re: [jclouds-karaf] Using ServiceMix bundle for jsch-agentproxy-sshj
(#53)
Posted by Chris Custine <no...@github.com>.
:+1: and I'll repeat that if any servicemix bundle stuff comes up again let me know and I can get it in quickly.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/53#issuecomment-52969565
Re: [jclouds-karaf] Using ServiceMix bundle for jsch-agentproxy-sshj
(#53)
Posted by Andrew Phillips <no...@github.com>.
> comes up again let me know and I can get it in quickly.
Thanks, @ccustine! Freeman was pretty quick to jump on [SMX4-1749](https://issues.apache.org/jira/browse/SMX4-1749), which was helpful.
I'm not wild on the versioning, but I gather that's the way ServiceMix does things. And, as far as I understand, at least, it's less "evil" than using `wrap`...
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/53#issuecomment-52977771