You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2019/11/16 02:29:20 UTC

[kudu-CR](branch-1.11.x) [mini cluster] SetDaemonFlag for test minicluster 

Hello Kudu Jenkins, Adar Dembo,

I'd like you to do a code review. Please visit

    http://gerrit.cloudera.org:8080/14726

to review the following change.


Change subject: [mini_cluster] SetDaemonFlag for test minicluster
......................................................................

[mini_cluster] SetDaemonFlag for test minicluster

Added control knobs to call SetFlag() RPC on masters and tablet servers
via mini_cluster test interface.  Also, added a test to cover the
new functionality.

Change-Id: Ie05aa87bba1b709cbbab953b6b220cae0fc958bb
Reviewed-on: http://gerrit.cloudera.org:8080/14712
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
(cherry picked from commit 9b1ff304ca5f9f2e1ea08646c7307fcbe0486015)
---
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/MiniKuduCluster.java
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool.proto
M src/kudu/tools/tool_action_test.cc
4 files changed, 130 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/26/14726/1
-- 
To view, visit http://gerrit.cloudera.org:8080/14726
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.11.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie05aa87bba1b709cbbab953b6b220cae0fc958bb
Gerrit-Change-Number: 14726
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR](branch-1.11.x) [mini cluster] SetDaemonFlag for test minicluster

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14726 )

Change subject: [mini_cluster] SetDaemonFlag for test minicluster
......................................................................


Patch Set 1: Code-Review+2

https://gerrit.cloudera.org/#/c/14727/ needs this patch as a dependency.  The former is a useful bugfix.


-- 
To view, visit http://gerrit.cloudera.org:8080/14726
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.11.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie05aa87bba1b709cbbab953b6b220cae0fc958bb
Gerrit-Change-Number: 14726
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sat, 16 Nov 2019 03:19:45 +0000
Gerrit-HasComments: No

[kudu-CR](branch-1.11.x) [mini cluster] SetDaemonFlag for test minicluster

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14726 )

Change subject: [mini_cluster] SetDaemonFlag for test minicluster
......................................................................

[mini_cluster] SetDaemonFlag for test minicluster

Added control knobs to call SetFlag() RPC on masters and tablet servers
via mini_cluster test interface.  Also, added a test to cover the
new functionality.

Change-Id: Ie05aa87bba1b709cbbab953b6b220cae0fc958bb
Reviewed-on: http://gerrit.cloudera.org:8080/14712
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
(cherry picked from commit 9b1ff304ca5f9f2e1ea08646c7307fcbe0486015)
Reviewed-on: http://gerrit.cloudera.org:8080/14726
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/MiniKuduCluster.java
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool.proto
M src/kudu/tools/tool_action_test.cc
4 files changed, 130 insertions(+), 0 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  Alexey Serbin: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/14726
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.11.x
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie05aa87bba1b709cbbab953b6b220cae0fc958bb
Gerrit-Change-Number: 14726
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)