You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by GitBox <gi...@apache.org> on 2022/05/02 15:32:43 UTC
[GitHub] [wicket] astange1 opened a new pull request, #521: Reduce the Object creation in toString() calls to ComponentInfo
astange1 opened a new pull request, #521:
URL: https://github.com/apache/wicket/pull/521
The toString() methods use temporary StringBuilders when they are not needed. This produces additional garbage objects, requiring more GC work, and is also computationally slower. String concatenation has been indyfy'd in newer JDKs, so avoid using the classic idiom of allocating a StringBuffer in this simple case. (JEP 280 landed in JDK9).
These changes should incrementally reduce object creation and slightly improve application responsiveness.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [wicket] astange1 closed pull request #521: Reduce the Object creation in toString() calls to ComponentInfo
Posted by GitBox <gi...@apache.org>.
astange1 closed pull request #521: Reduce the Object creation in toString() calls to ComponentInfo
URL: https://github.com/apache/wicket/pull/521
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [wicket] astange1 commented on pull request #521: Reduce the Object creation in toString() calls to ComponentInfo
Posted by GitBox <gi...@apache.org>.
astange1 commented on PR #521:
URL: https://github.com/apache/wicket/pull/521#issuecomment-1115067057
I realize that I messed up the PageComponentInfo.java method. I need to give this some more thought.
I am closing this PR and will resubmit it after some more thought.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org