You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by ru...@apache.org on 2021/08/20 23:00:42 UTC
[superset] branch master updated: initial commit (#16380)
This is an automated email from the ASF dual-hosted git repository.
rusackas pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git
The following commit(s) were added to refs/heads/master by this push:
new c508199 initial commit (#16380)
c508199 is described below
commit c5081991fcf8b4fd747a15d6973c9d35dd5f35b1
Author: Phillip Kelley-Dotson <pk...@yahoo.com>
AuthorDate: Fri Aug 20 15:59:53 2021 -0700
initial commit (#16380)
---
superset-frontend/src/datasource/DatasourceEditor.jsx | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/superset-frontend/src/datasource/DatasourceEditor.jsx b/superset-frontend/src/datasource/DatasourceEditor.jsx
index 4bf2690..e11b831 100644
--- a/superset-frontend/src/datasource/DatasourceEditor.jsx
+++ b/superset-frontend/src/datasource/DatasourceEditor.jsx
@@ -325,14 +325,18 @@ class DatasourceEditor extends React.PureComponent {
...props.datasource,
metrics: props.datasource.metrics?.map(metric => {
const {
+ certified_by: certifiedByMetric,
+ certification_details: certificationDetails,
+ } = metric;
+ const {
certification: { details, certified_by: certifiedBy } = {},
warning_markdown: warningMarkdown,
} = JSON.parse(metric.extra || '{}') || {};
return {
...metric,
- certification_details: details || '',
+ certification_details: certificationDetails || details,
warning_markdown: warningMarkdown || '',
- certified_by: certifiedBy,
+ certified_by: certifiedBy || certifiedByMetric,
};
}),
},
@@ -935,7 +939,6 @@ class DatasourceEditor extends React.PureComponent {
const { datasource } = this.state;
const { metrics } = datasource;
const sortedMetrics = metrics?.length ? this.sortMetrics(metrics) : [];
-
return (
<CollectionTable
tableColumns={['metric_name', 'verbose_name', 'expression']}