You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomee.apache.org by Jonathan Gallimore <jo...@gmail.com> on 2016/11/17 13:15:55 UTC
MaxTotal vs MaxActive in Tomcat/DBCP db pools in TomEE 7
Hi
I discovered that in TomEE 7, when using DBCP as my data source creator, I
needed to use the "MaxTotal" property as opposed to the "MaxActive"
property, which the Tomcat creator would use.
Does it make sense for us to "map" MaxActive to MaxTotal so these are
consistent and save any confusion? If so, I'd like to make the change -
just wanted to gather some opinion before going ahead.
Many thanks
Jon
Re: MaxTotal vs MaxActive in Tomcat/DBCP db pools in TomEE 7
Posted by Romain Manni-Bucau <rm...@gmail.com>.
2016-11-17 14:25 GMT+01:00 Jonathan Gallimore <jo...@gmail.com>
:
> Thanks for the reply, and clarifying the design choice. I'll hold off
> changing anything, unless this discussion changes direction.
>
> I did update the documentation on the website which will hopefully help
> anyone else who might run into this issue. Hope that is ok with everyone.
>
>
You rock man!
Note on that: dbcp seems to have removed dbcp1 doc (tomee 1), not sure
where we can find it anymore.
> Regards
>
> Jon
>
>
>
> On Thu, Nov 17, 2016 at 1:21 PM, Romain Manni-Bucau <rmannibucau@gmail.com
> >
> wrote:
>
> > Hi Jon,
> >
> > when migrating and for 7.x the choice was to get rid of most of our
> > defaults and just ensure we map to the defaults of the underlying pool -
> > think I sent a mail months (years?) ago. Goal was really have the pool
> you
> > use config and not something vaguely defined or require the user which
> can
> > know the pool for other application to learn another way to use this pool
> > with tomee.
> >
> > Hope it makes sense.
> >
> >
> > Romain Manni-Bucau
> > @rmannibucau <https://twitter.com/rmannibucau> | Blog
> > <https://blog-rmannibucau.rhcloud.com> | Old Blog
> > <http://rmannibucau.wordpress.com> | Github <https://github.com/
> > rmannibucau> |
> > LinkedIn <https://www.linkedin.com/in/rmannibucau> | JavaEE Factory
> > <https://javaeefactory-rmannibucau.rhcloud.com>
> >
> > 2016-11-17 14:15 GMT+01:00 Jonathan Gallimore <
> > jonathan.gallimore@gmail.com>
> > :
> >
> > > Hi
> > >
> > > I discovered that in TomEE 7, when using DBCP as my data source
> creator,
> > I
> > > needed to use the "MaxTotal" property as opposed to the "MaxActive"
> > > property, which the Tomcat creator would use.
> > >
> > > Does it make sense for us to "map" MaxActive to MaxTotal so these are
> > > consistent and save any confusion? If so, I'd like to make the change -
> > > just wanted to gather some opinion before going ahead.
> > >
> > > Many thanks
> > >
> > > Jon
> > >
> >
>
Re: MaxTotal vs MaxActive in Tomcat/DBCP db pools in TomEE 7
Posted by Jonathan Gallimore <jo...@gmail.com>.
Thanks for the reply, and clarifying the design choice. I'll hold off
changing anything, unless this discussion changes direction.
I did update the documentation on the website which will hopefully help
anyone else who might run into this issue. Hope that is ok with everyone.
Regards
Jon
On Thu, Nov 17, 2016 at 1:21 PM, Romain Manni-Bucau <rm...@gmail.com>
wrote:
> Hi Jon,
>
> when migrating and for 7.x the choice was to get rid of most of our
> defaults and just ensure we map to the defaults of the underlying pool -
> think I sent a mail months (years?) ago. Goal was really have the pool you
> use config and not something vaguely defined or require the user which can
> know the pool for other application to learn another way to use this pool
> with tomee.
>
> Hope it makes sense.
>
>
> Romain Manni-Bucau
> @rmannibucau <https://twitter.com/rmannibucau> | Blog
> <https://blog-rmannibucau.rhcloud.com> | Old Blog
> <http://rmannibucau.wordpress.com> | Github <https://github.com/
> rmannibucau> |
> LinkedIn <https://www.linkedin.com/in/rmannibucau> | JavaEE Factory
> <https://javaeefactory-rmannibucau.rhcloud.com>
>
> 2016-11-17 14:15 GMT+01:00 Jonathan Gallimore <
> jonathan.gallimore@gmail.com>
> :
>
> > Hi
> >
> > I discovered that in TomEE 7, when using DBCP as my data source creator,
> I
> > needed to use the "MaxTotal" property as opposed to the "MaxActive"
> > property, which the Tomcat creator would use.
> >
> > Does it make sense for us to "map" MaxActive to MaxTotal so these are
> > consistent and save any confusion? If so, I'd like to make the change -
> > just wanted to gather some opinion before going ahead.
> >
> > Many thanks
> >
> > Jon
> >
>
Re: MaxTotal vs MaxActive in Tomcat/DBCP db pools in TomEE 7
Posted by Romain Manni-Bucau <rm...@gmail.com>.
Hi Jon,
when migrating and for 7.x the choice was to get rid of most of our
defaults and just ensure we map to the defaults of the underlying pool -
think I sent a mail months (years?) ago. Goal was really have the pool you
use config and not something vaguely defined or require the user which can
know the pool for other application to learn another way to use this pool
with tomee.
Hope it makes sense.
Romain Manni-Bucau
@rmannibucau <https://twitter.com/rmannibucau> | Blog
<https://blog-rmannibucau.rhcloud.com> | Old Blog
<http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> |
LinkedIn <https://www.linkedin.com/in/rmannibucau> | JavaEE Factory
<https://javaeefactory-rmannibucau.rhcloud.com>
2016-11-17 14:15 GMT+01:00 Jonathan Gallimore <jo...@gmail.com>
:
> Hi
>
> I discovered that in TomEE 7, when using DBCP as my data source creator, I
> needed to use the "MaxTotal" property as opposed to the "MaxActive"
> property, which the Tomcat creator would use.
>
> Does it make sense for us to "map" MaxActive to MaxTotal so these are
> consistent and save any confusion? If so, I'd like to make the change -
> just wanted to gather some opinion before going ahead.
>
> Many thanks
>
> Jon
>