You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@shindig.apache.org by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org> on 2011/08/12 16:45:29 UTC

[jira] [Commented] (SHINDIG-1569) Change osapi._registerMethods to 'last one in wins'

    [ https://issues.apache.org/jira/browse/SHINDIG-1569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13084159#comment-13084159 ] 

jiraposter@reviews.apache.org commented on SHINDIG-1569:
--------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1211/
-----------------------------------------------------------

(Updated 2011-08-12 14:44:17.063813)


Review request for shindig.


Summary
-------

While debugging using a container cross-site from where shindig is hosted, I ran into trouble using:
  config[osapi.container.ServiceConfig.API_PATH] = '/rpc';
  config[osapi.container.ServiceConfig.API_HOST] = // A url to a proxy on the host server that points to the shindig server.

I found that the osapi.container.Service.prototype.registerOsapiServices function was defining methods that never ended up sticking, because other methods would beat it to the punch.
This resulted in the above settings never taking hold.


This addresses bug SHINDIG-1569.
    https://issues.apache.org/jira/browse/SHINDIG-1569


Diffs
-----

  http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/osapi.base/osapi.js 1151610 

Diff: https://reviews.apache.org/r/1211/diff


Testing
-------

Tested navigate gadget in a cross-hosted container environment (vanilla web host loading CC from shindig server).
Tested navigate gadget in SampleContainer (same host).


Thanks,

Dan



> Change osapi._registerMethods to 'last one in wins'
> ---------------------------------------------------
>
>                 Key: SHINDIG-1569
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1569
>             Project: Shindig
>          Issue Type: Bug
>          Components: Javascript 
>            Reporter: Dan Dumont
>            Priority: Minor
>
> While debugging using a container cross-site from where shindig is hosted, I ran into trouble using:
>   config[osapi.container.ServiceConfig.API_PATH] = '/rpc';
>   config[osapi.container.ServiceConfig.API_HOST] = // A url to a proxy on the host server that points to the shindig server.
> I found that the osapi.container.Service.prototype.registerOsapiServices function was defining methods that never ended up sticking, because other methods would beat it to the punch.
> This resulted in the above settings never taking hold.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira