You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by "lahodaj (via GitHub)" <gi...@apache.org> on 2024/01/18 18:34:04 UTC
[PR] [NETBEANS-6970] Disabling the multi source handling by default. [netbeans]
lahodaj opened a new pull request, #6974:
URL: https://github.com/apache/netbeans/pull/6974
I think the caption says it all. Not only won't the source root be registered, they won't even be computed by default. Which should basically eliminate the effect of the multi source root feature.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] [NETBEANS-6970] Disabling the multi source handling by default. [netbeans]
Posted by "lahodaj (via GitHub)" <gi...@apache.org>.
lahodaj commented on PR #6974:
URL: https://github.com/apache/netbeans/pull/6974#issuecomment-1904257597
Changed to a system property. To disable the multi source file handling, use: `-J-Djava.disable.multi.source.root=false`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] [NETBEANS-6970] Disabling the multi source handling by default. [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on code in PR #6974:
URL: https://github.com/apache/netbeans/pull/6974#discussion_r1457857082
##########
java/java.file.launcher/src/org/netbeans/modules/java/file/launcher/queries/MultiSourceRootProvider.java:
##########
@@ -67,9 +67,12 @@
@ServiceProvider(service=ClassPathProvider.class, position=9_999),
@ServiceProvider(service=MultiSourceRootProvider.class)
})
+@Messages({
+ "SETTING_EnableMultiSourceRoot=false"
+})
public class MultiSourceRootProvider implements ClassPathProvider {
- public static boolean DISABLE_MULTI_SOURCE_ROOT = false;
+ public static boolean DISABLE_MULTI_SOURCE_ROOT = !"true".equals(Bundle.SETTING_EnableMultiSourceRoot());
Review Comment:
@matthiasblaesing this is the NB default which is inverted false -> disable is set to true.
the property is the branding for the LSP server which I suppose is for the VSCode use case (which enables it by default).
this is how I understand this at least - I could be wrong.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] [NETBEANS-6970] Disabling the multi source handling by default. [netbeans]
Posted by "neilcsmith-net (via GitHub)" <gi...@apache.org>.
neilcsmith-net commented on PR #6974:
URL: https://github.com/apache/netbeans/pull/6974#issuecomment-1903638083
Am inclined to agree with @mbien to have a kill switch via system property. Less inclined to agree with merging later - would be better in rc2 IMO.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] [NETBEANS-6970] Disabling the multi source handling by default. [netbeans]
Posted by "junichi11 (via GitHub)" <gi...@apache.org>.
junichi11 commented on code in PR #6974:
URL: https://github.com/apache/netbeans/pull/6974#discussion_r1458106248
##########
java/java.file.launcher/src/org/netbeans/modules/java/file/launcher/queries/MultiSourceRootProvider.java:
##########
@@ -67,9 +67,12 @@
@ServiceProvider(service=ClassPathProvider.class, position=9_999),
@ServiceProvider(service=MultiSourceRootProvider.class)
})
+@Messages({
+ "SETTING_EnableMultiSourceRoot=false"
+})
public class MultiSourceRootProvider implements ClassPathProvider {
- public static boolean DISABLE_MULTI_SOURCE_ROOT = false;
+ public static boolean DISABLE_MULTI_SOURCE_ROOT = !"true".equals(Bundle.SETTING_EnableMultiSourceRoot());
Review Comment:
Does this work correctly if someone translates the messages?
Should we also add `"true"` to `@Messages`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] [NETBEANS-6970] Disabling the multi source handling by default. [netbeans]
Posted by "neilcsmith-net (via GitHub)" <gi...@apache.org>.
neilcsmith-net commented on PR #6974:
URL: https://github.com/apache/netbeans/pull/6974#issuecomment-1904268770
Assuming you meant `-J-Djava.disable.multi.source.root=true`?! Looks good to me. Will wait for tests and to see if anyone else has any comments. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] [NETBEANS-6970] Disabling the multi source handling by default. [netbeans]
Posted by "matthiasblaesing (via GitHub)" <gi...@apache.org>.
matthiasblaesing commented on PR #6974:
URL: https://github.com/apache/netbeans/pull/6974#issuecomment-1899016038
If I'm not missing something obvious, this will enable the multi source handling by default.
Property is set to true:
```properties
SETTING_EnableMultiSourceRoot=true
```
that value is compared to the string `"true"`, which yields the boolean `true`. That is then inverted yielding boolean `false`.
```java
public static boolean DISABLE_MULTI_SOURCE_ROOT = !"true".equals(Bundle.SETTING_EnableMultiSourceRoot());
```
So effectively nothing changed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] [NETBEANS-6970] Disabling the multi source handling by default. [netbeans]
Posted by "lahodaj (via GitHub)" <gi...@apache.org>.
lahodaj commented on PR #6974:
URL: https://github.com/apache/netbeans/pull/6974#issuecomment-1904271775
> Assuming you meant `-J-Djava.disable.multi.source.root=true`?! Looks good to me. Will wait for tests and to see if anyone else has any comments. Thanks!
Right. Copied from the wrong command line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] [NETBEANS-6970] Disabling the multi source handling by default. [netbeans]
Posted by "matthiasblaesing (via GitHub)" <gi...@apache.org>.
matthiasblaesing commented on PR #6974:
URL: https://github.com/apache/netbeans/pull/6974#issuecomment-1899016652
Less radical suggestion: https://github.com/apache/netbeans/pull/6975
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] [NETBEANS-6970] Disabling the multi source handling by default. [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #6974:
URL: https://github.com/apache/netbeans/pull/6974#issuecomment-1902596057
even if this isn't merged as-is, a slightly modified version of this could be useful as additional safety net to #6975
feature would be enabled by default but could be disabled via flag if something shows up post-release. No need to hurry since this can be merged later IMO due to the fact that its trivial to move a constant into a property.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] [NETBEANS-6970] Disabling the multi source handling by default. [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on code in PR #6974:
URL: https://github.com/apache/netbeans/pull/6974#discussion_r1459003746
##########
java/java.file.launcher/src/org/netbeans/modules/java/file/launcher/queries/MultiSourceRootProvider.java:
##########
@@ -67,9 +67,12 @@
@ServiceProvider(service=ClassPathProvider.class, position=9_999),
@ServiceProvider(service=MultiSourceRootProvider.class)
})
+@Messages({
+ "SETTING_EnableMultiSourceRoot=false"
+})
public class MultiSourceRootProvider implements ClassPathProvider {
- public static boolean DISABLE_MULTI_SOURCE_ROOT = false;
+ public static boolean DISABLE_MULTI_SOURCE_ROOT = !"true".equals(Bundle.SETTING_EnableMultiSourceRoot());
Review Comment:
@junichi11 not everything which is in property files is a user facing String. This is just a field which can be `true` or `false` - thats it. This is not going to be translated.
`@Messages` is just a mechanism to pull some properties into the code, since maintaining property files can be error prone.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] [NETBEANS-6970] Disabling the multi source handling by default. [netbeans]
Posted by "lahodaj (via GitHub)" <gi...@apache.org>.
lahodaj commented on PR #6974:
URL: https://github.com/apache/netbeans/pull/6974#issuecomment-1903733830
Ok. I'll work on changing this to a system property. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] [GH-6970] Adding a system property to disable the multi source file handling. [netbeans]
Posted by "neilcsmith-net (via GitHub)" <gi...@apache.org>.
neilcsmith-net merged PR #6974:
URL: https://github.com/apache/netbeans/pull/6974
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] [NETBEANS-6970] Disabling the multi source handling by default. [netbeans]
Posted by "junichi11 (via GitHub)" <gi...@apache.org>.
junichi11 commented on PR #6974:
URL: https://github.com/apache/netbeans/pull/6974#issuecomment-1899388589
We should use [GITHUB-****] instead of [NETBEANS-****] like Matthias because [NETBEANS-****] means an issue of JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] [NETBEANS-6970] Disabling the multi source handling by default. [netbeans]
Posted by "neilcsmith-net (via GitHub)" <gi...@apache.org>.
neilcsmith-net commented on PR #6974:
URL: https://github.com/apache/netbeans/pull/6974#issuecomment-1900237804
> We should use [GITHUB-****] instead of [NETBEANS-****] like Matthias because [NETBEANS-****] means an issue of JIRA.
Most usage has been [GH-****] However, while this is being pointed out, the most useful thing is to make sure the issue is linked in the description. I've edited here. Issue references from titles don't work get automatically cross referenced.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] [NETBEANS-6970] Disabling the multi source handling by default. [netbeans]
Posted by "matthiasblaesing (via GitHub)" <gi...@apache.org>.
matthiasblaesing commented on code in PR #6974:
URL: https://github.com/apache/netbeans/pull/6974#discussion_r1457857956
##########
java/java.file.launcher/src/org/netbeans/modules/java/file/launcher/queries/MultiSourceRootProvider.java:
##########
@@ -67,9 +67,12 @@
@ServiceProvider(service=ClassPathProvider.class, position=9_999),
@ServiceProvider(service=MultiSourceRootProvider.class)
})
+@Messages({
+ "SETTING_EnableMultiSourceRoot=false"
+})
public class MultiSourceRootProvider implements ClassPathProvider {
- public static boolean DISABLE_MULTI_SOURCE_ROOT = false;
+ public static boolean DISABLE_MULTI_SOURCE_ROOT = !"true".equals(Bundle.SETTING_EnableMultiSourceRoot());
Review Comment:
Ah crap - yeah - overlooked that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists