[jira] [Commented] (OFBIZ-6923) Improve the decorator for manufacturing/order/facility component for re-use

["Kongrath Suankaewmanee (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-6923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15196893#comment-15196893 ] 

Kongrath Suankaewmanee commented on OFBIZ-6923:
-----------------------------------------------

Thanks Hans,

I just saw some code in my patch that's not correct in : 

{code:title=applications/product/widget/facility/ShipmentScreens.xml|borderStyle=solid}
    <screen name="CommonShipmentMainDecorator">
        <section>
            <actions>
                <set field="titleProperty" value="ProductFindShipment"/>
                <set field="headerItem" value="shipment"/>
                <script location="component://product/webapp/facility/WEB-INF/actions/shipment/FindShipment.groovy"/>
            </actions>
            <widgets>
                <decorator-screen name="CommonShipmentMainDecorator" location="${parameters.commonShipmentDecoratorLocation}">
                    <decorator-section name="body">
                        <section>
                            <condition>
                                <if-has-permission permission="FACILITY" action="_VIEW"/>
                            </condition>
                            <widgets>
                                <decorator-section-include name="body"/>
                            </widgets>
                            <fail-widgets>
                                <label style="h3">${uiLabelMap.ProductFacilityViewPermissionError}</label>
                            </fail-widgets>
                        </section>
                    </decorator-section>
                </decorator-screen>
            </widgets>
        </section>
    </screen>
{code}

It should be this :

{code:title=applications/product/widget/facility/ShipmentScreens.xml|borderStyle=solid}
    <screen name="CommonShipmentMainDecorator">
        <section>
            <actions>
                <set field="titleProperty" value="ProductFindShipment"/>
                <set field="headerItem" value="shipment"/>
                <script location="component://product/webapp/facility/WEB-INF/actions/shipment/FindShipment.groovy"/>
            </actions>
            <widgets>
                <decorator-screen name="main-decorator" location="${parameters.mainDecoratorLocation}">
                    <decorator-section name="body">
                        <section>
                            <condition>
                                <if-has-permission permission="FACILITY" action="_VIEW"/>
                            </condition>
                            <widgets>
                                <decorator-section-include name="body"/>
                            </widgets>
                            <fail-widgets>
                                <label style="h3">${uiLabelMap.ProductFacilityViewPermissionError}</label>
                            </fail-widgets>
                        </section>
                    </decorator-section>
                </decorator-screen>
            </widgets>
        </section>
    </screen>
{code}

I have attached file the new patch file in here.


> Improve the decorator for manufacturing/order/facility component for re-use
> ---------------------------------------------------------------------------
>
>                 Key: OFBIZ-6923
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-6923
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: manufacturing, order, product
>    Affects Versions: Trunk
>            Reporter: Kongrath Suankaewmanee
>            Assignee: Hans Bakker
>             Fix For: Upcoming Branch
>
>         Attachments: OFBIZ-6923.patch
>
>
> We have a problem on organize the existing decorator. In this case is manufacturing decorator and also in another decorator too. We cannot use the existing decorator with *main-decorator* that define on another component in *hot-deploy*.
> So, I thought we should make reorganization for decorator like in the partymgr component
> *applications/party/widget/partymgr/CommonScreens.xml*
> All screen should call the common decorator and each common decorator call *main-decorator* in each commonent, so if we have create the new component in *hot-deploy* and it should use the *main-decorator* in their.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)