You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "kennknowles (via GitHub)" <gi...@apache.org> on 2023/04/25 22:23:53 UTC
[GitHub] [beam] kennknowles opened a new pull request, #26422: [20507] Eliminate nullness and rawtype errors from java SDK Read class
kennknowles opened a new pull request, #26422:
URL: https://github.com/apache/beam/pull/26422
This eliminates outright nullness and rawtype errors where possible, and localizes some cases that are reasonable compromises or hacks that I don't want to mess with.
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [x] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [x] Update `CHANGES.md` with noteworthy changes.
- [x] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[![Build python source distribution and wheels](https://github.com/apache/beam/workflows/Build%20python%20source%20distribution%20and%20wheels/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[![Python tests](https://github.com/apache/beam/workflows/Python%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[![Java tests](https://github.com/apache/beam/workflows/Java%20Tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[![Go tests](https://github.com/apache/beam/workflows/Go%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #26422: Eliminate nullness and rawtype errors from java SDK Read class
Posted by "kennknowles (via GitHub)" <gi...@apache.org>.
kennknowles commented on PR #26422:
URL: https://github.com/apache/beam/pull/26422#issuecomment-1523815996
This is undoubtedly something I added because the thing looked like it was required to be non-null.
```
Caused by: java.lang.IllegalStateException
at org.apache.beam.sdk.util.Preconditions.checkStateNotNull(Preconditions.java:452)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #26422: Eliminate nullness and rawtype errors from java SDK Read class
Posted by "kennknowles (via GitHub)" <gi...@apache.org>.
kennknowles commented on PR #26422:
URL: https://github.com/apache/beam/pull/26422#issuecomment-1523907979
Run Java_Kinesis_IO_Direct PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #26422: Eliminate nullness and rawtype errors from java SDK Read class
Posted by "kennknowles (via GitHub)" <gi...@apache.org>.
kennknowles commented on PR #26422:
URL: https://github.com/apache/beam/pull/26422#issuecomment-1523888371
Run Java PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damondouglas commented on pull request #26422: Eliminate nullness and rawtype errors from java SDK Read class
Posted by "damondouglas (via GitHub)" <gi...@apache.org>.
damondouglas commented on PR #26422:
URL: https://github.com/apache/beam/pull/26422#issuecomment-1522791609
Run Java PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #26422: Eliminate nullness and rawtype errors from java SDK Read class
Posted by "kennknowles (via GitHub)" <gi...@apache.org>.
kennknowles commented on PR #26422:
URL: https://github.com/apache/beam/pull/26422#issuecomment-1523814873
huh, interestingly I failed to repro the failure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damondouglas merged pull request #26422: Eliminate nullness and rawtype errors from java SDK Read class
Posted by "damondouglas (via GitHub)" <gi...@apache.org>.
damondouglas merged PR #26422:
URL: https://github.com/apache/beam/pull/26422
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #26422: Eliminate nullness and rawtype errors from java SDK Read class
Posted by "kennknowles (via GitHub)" <gi...@apache.org>.
kennknowles commented on PR #26422:
URL: https://github.com/apache/beam/pull/26422#issuecomment-1523806698
I'll take a look. I actually just ensured it compiled before pushing out, since I wasn't intending to make functional changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #26422: Eliminate nullness and rawtype errors from java SDK Read class
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #26422:
URL: https://github.com/apache/beam/pull/26422#issuecomment-1522527352
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @Abacn for label java.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damondouglas commented on pull request #26422: Eliminate nullness and rawtype errors from java SDK Read class
Posted by "damondouglas (via GitHub)" <gi...@apache.org>.
damondouglas commented on PR #26422:
URL: https://github.com/apache/beam/pull/26422#issuecomment-1524803965
FYI Run Java_GCP_IO_Direct PreCommit shows success even though it has a yellow light.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #26422: Eliminate nullness and rawtype errors from java SDK Read class
Posted by "kennknowles (via GitHub)" <gi...@apache.org>.
kennknowles commented on PR #26422:
URL: https://github.com/apache/beam/pull/26422#issuecomment-1523907524
Run Java_IOs_Direct PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on a diff in pull request #26422: Eliminate nullness and rawtype errors from java SDK Read class
Posted by "kennknowles (via GitHub)" <gi...@apache.org>.
kennknowles commented on code in PR #26422:
URL: https://github.com/apache/beam/pull/26422#discussion_r1178212952
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/io/Read.java:
##########
@@ -839,16 +850,16 @@ public CheckpointMark getCheckpointMark() {
}
private Object createCacheKey(
- UnboundedSource<OutputT, CheckpointT> source, CheckpointT checkpoint) {
- checkNotNull(restrictionCoder);
+ UnboundedSource<OutputT, CheckpointT> source, @Nullable CheckpointT checkpoint) {
+ checkStateNotNull(restrictionCoder);
// For caching reader, we don't care about the watermark.
return restrictionCoder.structuralValue(
UnboundedSourceRestriction.create(
source, checkpoint, BoundedWindow.TIMESTAMP_MIN_VALUE));
}
private void initializeCurrentReader() throws IOException {
- Preconditions.checkState(currentReader == null);
+ checkStateNotNull(currentReader);
Review Comment:
oops
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #26422: Eliminate nullness and rawtype errors from java SDK Read class
Posted by "kennknowles (via GitHub)" <gi...@apache.org>.
kennknowles commented on PR #26422:
URL: https://github.com/apache/beam/pull/26422#issuecomment-1523907707
Run Java_GCP_IO_Direct PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #26422: Eliminate nullness and rawtype errors from java SDK Read class
Posted by "kennknowles (via GitHub)" <gi...@apache.org>.
kennknowles commented on PR #26422:
URL: https://github.com/apache/beam/pull/26422#issuecomment-1523906782
Run RAT PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org