You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/07/09 14:25:08 UTC
[GitHub] [incubator-doris] caiconghui opened a new pull request #4061: [Bug]Support get all rowset meta info in memory from tablet meta url
caiconghui opened a new pull request #4061:
URL: https://github.com/apache/incubator-doris/pull/4061
This PR is to fix bug that we cannot get the newest tablet meta info from tablet meta url.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] caiconghui edited a comment on pull request #4061: [Bug]Support get all rowset meta info in memory from tablet meta url
Posted by GitBox <gi...@apache.org>.
caiconghui edited a comment on pull request #4061:
URL: https://github.com/apache/incubator-doris/pull/4061#issuecomment-656159621
for #4059
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on a change in pull request #4061: [Bug]Support get all rowset meta info in memory from tablet meta url
Posted by GitBox <gi...@apache.org>.
morningman commented on a change in pull request #4061:
URL: https://github.com/apache/incubator-doris/pull/4061#discussion_r452577718
##########
File path: be/src/http/action/meta_action.cpp
##########
@@ -60,13 +60,11 @@ Status MetaAction::_handle_header(HttpRequest* req, std::string* json_meta) {
LOG(WARNING) << "no tablet for tablet_id:" << tablet_id << " schema hash:" << schema_hash;
return Status::InternalError("no tablet exist");
}
- OLAPStatus s =
- TabletMetaManager::get_json_meta(tablet->data_dir(), tablet_id, schema_hash, json_meta);
Review comment:
Why are some rowset meta not in rocksdb but only in memory?
Is this part of rowset meta not effective?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman merged pull request #4061: [Bug]Support get all rowset meta info in memory from tablet meta url
Posted by GitBox <gi...@apache.org>.
morningman merged pull request #4061:
URL: https://github.com/apache/incubator-doris/pull/4061
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] caiconghui commented on pull request #4061: [Bug]Support get all rowset meta info in memory from tablet meta url
Posted by GitBox <gi...@apache.org>.
caiconghui commented on pull request #4061:
URL: https://github.com/apache/incubator-doris/pull/4061#issuecomment-656159621
for #4061
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] caiconghui commented on a change in pull request #4061: [Bug]Support get all rowset meta info in memory from tablet meta url
Posted by GitBox <gi...@apache.org>.
caiconghui commented on a change in pull request #4061:
URL: https://github.com/apache/incubator-doris/pull/4061#discussion_r452589021
##########
File path: be/src/http/action/meta_action.cpp
##########
@@ -60,13 +60,11 @@ Status MetaAction::_handle_header(HttpRequest* req, std::string* json_meta) {
LOG(WARNING) << "no tablet for tablet_id:" << tablet_id << " schema hash:" << schema_hash;
return Status::InternalError("no tablet exist");
}
- OLAPStatus s =
- TabletMetaManager::get_json_meta(tablet->data_dir(), tablet_id, schema_hash, json_meta);
Review comment:
this problem is introduced by #1946 , tablet will do meta checkpoint periodly
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org