[GitHub] [airflow] vandonr-amz commented on pull request #28039: Migrate amazon provider hooks tests from `unittests` to `pytest`

[GitBox <gi...@apache.org>]

vandonr-amz commented on PR #28039:
URL: https://github.com/apache/airflow/pull/28039#issuecomment-1334671366

   > > nice. I noticed that on some `setup_method`s you added the optional `method` parameter without using it, while you skipped it on others. I think it'd be best to omit it wherever possible (i.e. probably everywhere in this case)
   > 
   > That's funny but if `setup_method` or `teardown_method` decorated by `@mock.patсh` then method signature (self, method) should use
   
   Ah yes I imagine because of the order of arguments, but I imagine in test_datasync it's not needed ?
   Is it also needed for mocks that "generate" no arguments, like the `@mock.patch.dict` ?
   
   and nit: I like using `_` as name for the arguments that are unused, it's a clear way to mark them as "only here for the compiler to be happy"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org