You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@royale.apache.org by Yishay Weiss <yi...@hotmail.com> on 2017/11/21 11:29:11 UTC
RE: [royale-asjs] branch develop updated: isHeightSizedToContent is a
method, not a prop
Should there be a compiler warning when methods are implicitly converted to Booleans?
________________________________
From: yishayw@apache.org <yi...@apache.org>
Sent: Tuesday, November 21, 2017 1:24:31 PM
To: commits@royale.apache.org
Subject: [royale-asjs] branch develop updated: isHeightSizedToContent is a method, not a prop
This is an automated email from the ASF dual-hosted git repository.
yishayw pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/royale-asjs.git
The following commit(s) were added to refs/heads/develop by this push:
new 6dd1416 isHeightSizedToContent is a method, not a prop
new 93febf1 Merge branch 'develop' of https://github.com/apache/royale-asjs into develop
6dd1416 is described below
commit 6dd1416ed790c99604ed4d0e96edbfb630354ecf
Author: DESKTOP-RH4S838\Yishay <yi...@hotmail.com>
AuthorDate: Tue Nov 21 13:19:12 2017 +0200
isHeightSizedToContent is a method, not a prop
---
.../main/royale/org/apache/royale/html/beads/layouts/TileLayout.as | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/frameworks/projects/Basic/src/main/royale/org/apache/royale/html/beads/layouts/TileLayout.as b/frameworks/projects/Basic/src/main/royale/org/apache/royale/html/beads/layouts/TileLayout.as
index ce06f4e..63182bb 100644
--- a/frameworks/projects/Basic/src/main/royale/org/apache/royale/html/beads/layouts/TileLayout.as
+++ b/frameworks/projects/Basic/src/main/royale/org/apache/royale/html/beads/layouts/TileLayout.as
@@ -152,7 +152,7 @@ package org.apache.royale.html.beads.layouts
if (isNaN(useHeight)) {
// given the width and total number of items, how many rows?
var numRows:Number = Math.floor(realN/numColumns);
- if (host.isHeightSizedToContent) useHeight = 30; // default height
+ if (host.isHeightSizedToContent()) useHeight = 30; // default height
else useHeight = Math.floor(adjustedHeight / numRows);
}
@@ -229,7 +229,7 @@ package org.apache.royale.html.beads.layouts
if (isNaN(useHeight)) {
// given the width and total number of items, how many rows?
var numRows:Number = Math.floor(realN / numColumns);
- if (host.isHeightSizedToContent) useHeight = 30; // default height
+ if (host.isHeightSizedToContent()) useHeight = 30; // default height
else useHeight = Math.floor(adjustedHeight / numRows);
}
--
To stop receiving notification emails like this one, please contact
['"commits@royale.apache.org" <co...@royale.apache.org>'].
Re: [royale-asjs] branch develop updated: isHeightSizedToContent is a
method, not a prop
Posted by Piotr Zarzycki <pi...@gmail.com>.
I'm sorry in Flex you will get an warning and in that case it could also be
the same. In the opposite situation Flex is throwing an error.
Piotr
2017-11-22 18:27 GMT+01:00 Piotr Zarzycki <pi...@gmail.com>:
> Hi Yishay,
>
> I think it could be even an error throwing by the compiler. If Flex you
> would got an error.
>
> Piotr
>
>
> 2017-11-21 12:29 GMT+01:00 Yishay Weiss <yi...@hotmail.com>:
>
>> Should there be a compiler warning when methods are implicitly converted
>> to Booleans?
>>
>>
>>
>> ________________________________
>> From: yishayw@apache.org <yi...@apache.org>
>> Sent: Tuesday, November 21, 2017 1:24:31 PM
>> To: commits@royale.apache.org
>> Subject: [royale-asjs] branch develop updated: isHeightSizedToContent is
>> a method, not a prop
>>
>> This is an automated email from the ASF dual-hosted git repository.
>>
>> yishayw pushed a commit to branch develop
>> in repository https://gitbox.apache.org/repos/asf/royale-asjs.git
>>
>>
>> The following commit(s) were added to refs/heads/develop by this push:
>> new 6dd1416 isHeightSizedToContent is a method, not a prop
>> new 93febf1 Merge branch 'develop' of
>> https://github.com/apache/royale-asjs into develop
>> 6dd1416 is described below
>>
>> commit 6dd1416ed790c99604ed4d0e96edbfb630354ecf
>> Author: DESKTOP-RH4S838\Yishay <yi...@hotmail.com>
>> AuthorDate: Tue Nov 21 13:19:12 2017 +0200
>>
>> isHeightSizedToContent is a method, not a prop
>> ---
>> .../main/royale/org/apache/royale/html/beads/layouts/TileLayout.as |
>> 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/frameworks/projects/Basic/src/main/royale/org/apache/royal
>> e/html/beads/layouts/TileLayout.as b/frameworks/projects/Basic/sr
>> c/main/royale/org/apache/royale/html/beads/layouts/TileLayout.as
>> index ce06f4e..63182bb 100644
>> --- a/frameworks/projects/Basic/src/main/royale/org/apache/royal
>> e/html/beads/layouts/TileLayout.as
>> +++ b/frameworks/projects/Basic/src/main/royale/org/apache/royal
>> e/html/beads/layouts/TileLayout.as
>> @@ -152,7 +152,7 @@ package org.apache.royale.html.beads.layouts
>> if (isNaN(useHeight)) {
>> // given the width and total
>> number of items, how many rows?
>> var numRows:Number =
>> Math.floor(realN/numColumns);
>> - if (host.isHeightSizedToContent)
>> useHeight = 30; // default height
>> + if (host.isHeightSizedToContent())
>> useHeight = 30; // default height
>> else useHeight =
>> Math.floor(adjustedHeight / numRows);
>> }
>>
>> @@ -229,7 +229,7 @@ package org.apache.royale.html.beads.layouts
>> if (isNaN(useHeight)) {
>> // given the width and total
>> number of items, how many rows?
>> var numRows:Number =
>> Math.floor(realN / numColumns);
>> - if (host.isHeightSizedToContent)
>> useHeight = 30; // default height
>> + if (host.isHeightSizedToContent())
>> useHeight = 30; // default height
>> else useHeight =
>> Math.floor(adjustedHeight / numRows);
>> }
>>
>>
>> --
>> To stop receiving notification emails like this one, please contact
>> ['"commits@royale.apache.org" <co...@royale.apache.org>'].
>>
>
>
>
> --
>
> Piotr Zarzycki
>
> Patreon: *https://www.patreon.com/piotrzarzycki
> <https://www.patreon.com/piotrzarzycki>*
>
--
Piotr Zarzycki
Patreon: *https://www.patreon.com/piotrzarzycki
<https://www.patreon.com/piotrzarzycki>*
Re: [royale-asjs] branch develop updated: isHeightSizedToContent is a
method, not a prop
Posted by Piotr Zarzycki <pi...@gmail.com>.
Hi Yishay,
I think it could be even an error throwing by the compiler. If Flex you
would got an error.
Piotr
2017-11-21 12:29 GMT+01:00 Yishay Weiss <yi...@hotmail.com>:
> Should there be a compiler warning when methods are implicitly converted
> to Booleans?
>
>
>
> ________________________________
> From: yishayw@apache.org <yi...@apache.org>
> Sent: Tuesday, November 21, 2017 1:24:31 PM
> To: commits@royale.apache.org
> Subject: [royale-asjs] branch develop updated: isHeightSizedToContent is a
> method, not a prop
>
> This is an automated email from the ASF dual-hosted git repository.
>
> yishayw pushed a commit to branch develop
> in repository https://gitbox.apache.org/repos/asf/royale-asjs.git
>
>
> The following commit(s) were added to refs/heads/develop by this push:
> new 6dd1416 isHeightSizedToContent is a method, not a prop
> new 93febf1 Merge branch 'develop' of https://github.com/apache/
> royale-asjs into develop
> 6dd1416 is described below
>
> commit 6dd1416ed790c99604ed4d0e96edbfb630354ecf
> Author: DESKTOP-RH4S838\Yishay <yi...@hotmail.com>
> AuthorDate: Tue Nov 21 13:19:12 2017 +0200
>
> isHeightSizedToContent is a method, not a prop
> ---
> .../main/royale/org/apache/royale/html/beads/layouts/TileLayout.as |
> 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/frameworks/projects/Basic/src/main/royale/org/apache/
> royale/html/beads/layouts/TileLayout.as b/frameworks/projects/Basic/
> src/main/royale/org/apache/royale/html/beads/layouts/TileLayout.as
> index ce06f4e..63182bb 100644
> --- a/frameworks/projects/Basic/src/main/royale/org/apache/
> royale/html/beads/layouts/TileLayout.as
> +++ b/frameworks/projects/Basic/src/main/royale/org/apache/
> royale/html/beads/layouts/TileLayout.as
> @@ -152,7 +152,7 @@ package org.apache.royale.html.beads.layouts
> if (isNaN(useHeight)) {
> // given the width and total
> number of items, how many rows?
> var numRows:Number =
> Math.floor(realN/numColumns);
> - if (host.isHeightSizedToContent)
> useHeight = 30; // default height
> + if (host.isHeightSizedToContent())
> useHeight = 30; // default height
> else useHeight =
> Math.floor(adjustedHeight / numRows);
> }
>
> @@ -229,7 +229,7 @@ package org.apache.royale.html.beads.layouts
> if (isNaN(useHeight)) {
> // given the width and total
> number of items, how many rows?
> var numRows:Number =
> Math.floor(realN / numColumns);
> - if (host.isHeightSizedToContent)
> useHeight = 30; // default height
> + if (host.isHeightSizedToContent())
> useHeight = 30; // default height
> else useHeight =
> Math.floor(adjustedHeight / numRows);
> }
>
>
> --
> To stop receiving notification emails like this one, please contact
> ['"commits@royale.apache.org" <co...@royale.apache.org>'].
>
--
Piotr Zarzycki
Patreon: *https://www.patreon.com/piotrzarzycki
<https://www.patreon.com/piotrzarzycki>*