You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by GitBox <gi...@apache.org> on 2020/01/09 18:01:55 UTC
[GitHub] [myfaces] volosied opened a new pull request #77: Myfaces 4311 Unit
Tests
volosied opened a new pull request #77: Myfaces 4311 Unit Tests
URL: https://github.com/apache/myfaces/pull/77
Added two unit tests to ensure that the generic converter & validator work as expected.
Please ignore EntityBean.java, I removed it in the second commit.
And let me know if there are any issues. Particularly, I'm not sure if I should implement testValidator another way. I kept it simple with the try catch, but I can use some JUnit feature to expect a FacesException if recommended.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [myfaces] wtlucy merged pull request #77: Myfaces 4311 Unit Tests
Posted by GitBox <gi...@apache.org>.
wtlucy merged pull request #77: Myfaces 4311 Unit Tests
URL: https://github.com/apache/myfaces/pull/77
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [myfaces] wtlucy commented on issue #77: Myfaces 4311 Unit Tests
Posted by GitBox <gi...@apache.org>.
wtlucy commented on issue #77: Myfaces 4311 Unit Tests
URL: https://github.com/apache/myfaces/pull/77#issuecomment-572703463
This looks good @volosied, thanks for circling back to add these tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services