You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by JoshRosen <gi...@git.apache.org> on 2015/10/20 19:41:52 UTC

[GitHub] spark pull request: [SPARK-10447][SPARK-3842][PYSPARK] upgrade pys...

Github user JoshRosen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/8615#discussion_r42528185
  
    --- Diff: python/pyspark/streaming/tests.py ---
    @@ -61,9 +61,12 @@ def setUpClass(cls):
         def tearDownClass(cls):
             cls.sc.stop()
             # Clean up in the JVM just in case there has been some issues in Python API
    -        jSparkContextOption = SparkContext._jvm.SparkContext.get()
    -        if jSparkContextOption.nonEmpty():
    -            jSparkContextOption.get().stop()
    +        try:
    --- End diff --
    
    Fair enough. Let's skip the exception for now, since this is only test code anyways.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org