[GitHub] [superset] kasiazjc commented on pull request #23547: feat: Shows user charts by default when editing a dashboard

["kasiazjc (via GitHub)" <gi...@apache.org>]

kasiazjc commented on PR #23547:
URL: https://github.com/apache/superset/pull/23547#issuecomment-1493894561

   > @kasiazjc Can you please review the proposed control? My thinking was to treat it as another filter, hence the checkbox. Any improvements are welcome 🙂
   
   Thanks @michael-s-molina ❤️ 
   
   I agree this is a good change! In general I think that for now the checkbox makes sense - I was thinking that at some point we could have full on filters that would be hidden in a button (like "more filters" in horizontal navbar), so that you could filter by owner, dataset etc. But it's a long way to go. 
   
   In terms of styling:
   - let's align the checkbox to the left
   - (I think) let's bump the spacings between search and checkbox and thumbnails to 16px to give it more breathing space
   
   In terms of behavior: 
   I am wondering if having a control that would say "Show my charts only" wouldn't be a better /more intuitive approach as we would start with the big list with all the possibilities, that you just narrow with the filter checkbox. We could also add a tooltip with information about this whole thing "By default, the chart list displays all charts that you have access to in the workspace. You can filter the list to show only charts that you own."
   
   Curious to hear your thoughts @michael-s-molina @villebro 😌 
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org