You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2021/04/29 18:48:52 UTC
[GitHub] [accumulo] himanshu007-creator opened a new pull request #2055: Renamed fields
himanshu007-creator opened a new pull request #2055:
URL: https://github.com/apache/accumulo/pull/2055
#2053
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] himanshu007-creator commented on pull request #2055: Renamed fields
Posted by GitBox <gi...@apache.org>.
himanshu007-creator commented on pull request #2055:
URL: https://github.com/apache/accumulo/pull/2055#issuecomment-830820281
> > As suggested from @brianloss on another issue: If you have or can install Docker, then you could try building from a Docker container. Something like [maven](https://hub.docker.com/_/maven) probably work if you volume mount your source directory. Either that or a linux vm (either local or hosted) are options.
>
> I played around a little bit on a Windows VM, and discovered that WSL 2 works quite well if that's an option for you. I installed the Ubuntu 20.04 distro and had to install JDK, Maven, make, and g++ and I was able to do a build w/o tests. Docker for Windows made me install WSL (there is a hyper-v option too, but didn't work for me since I was already in a VM I think), so no benefit to Docker in that case. If you want Docker for other reasons (e.g., not installing tools), unfortunately the maven images don't quite work since they don't include the necessary tools to build the native libs. It's pretty easy to build an image on top of the maven ones, though. For example, I had the following Dockerfile to build an image:
>
> ```dockerfile
> FROM maven:3-jdk-11-slim
> RUN apt-get update && apt install -y g++ make && rm -rf /var/lib/apt/lists/*
> ```
>
> With my custom image, I was able to do a full build (again, skipping test execution). I just followed the instructions on the [maven](https://hub.docker.com/_/maven) image page for running and also to reuse the m2 repository (you don't want to have to download all of the dependencies every time).
i am sorry, but i wont be able to do that, i would appreciate if you can make the required changes in this PR, ill commit the changes and then its all settled
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] EdColeman commented on pull request #2055: Renamed fields
Posted by GitBox <gi...@apache.org>.
EdColeman commented on pull request #2055:
URL: https://github.com/apache/accumulo/pull/2055#issuecomment-829512224
There looks to be additional references that you missed. Please fix and then run
`mvn clean verify -DskipITs`
To build locally - once you have a clean build you can push your changes and we can try the QA tests again. (See: https://accumulo.apache.org/how-to-contribute/#example-contribution-workflow) for more information.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] EdColeman commented on pull request #2055: Renamed fields
Posted by GitBox <gi...@apache.org>.
EdColeman commented on pull request #2055:
URL: https://github.com/apache/accumulo/pull/2055#issuecomment-830077886
As suggested from @brianloss on another issue: If you have or can install Docker, then you could try building from a Docker container. Something like [maven](https://hub.docker.com/_/maven) probably work if you volume mount your source directory. Either that or a linux vm (either local or hosted) are options.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] himanshu007-creator commented on pull request #2055: Renamed fields
Posted by GitBox <gi...@apache.org>.
himanshu007-creator commented on pull request #2055:
URL: https://github.com/apache/accumulo/pull/2055#issuecomment-830074907
@EdColeman HI, i dont have system requirements for setting up the project, can you suggest a way out? I thought of it to be an issue just related to renaming fields , nothing else.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] EdColeman commented on pull request #2055: Renamed fields
Posted by GitBox <gi...@apache.org>.
EdColeman commented on pull request #2055:
URL: https://github.com/apache/accumulo/pull/2055#issuecomment-830824055
The lines that need changed are:
[line 366](https://github.com/apache/accumulo/blob/4f35e6aff1763d4b19d1e93036260094b47cc589/server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServerResourceManager.java#L366)
[line 370](https://github.com/apache/accumulo/blob/4f35e6aff1763d4b19d1e93036260094b47cc589/server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServerResourceManager.java#L370)
[line 862](https://github.com/apache/accumulo/blob/4f35e6aff1763d4b19d1e93036260094b47cc589/server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServerResourceManager.java#L862)
You should at least be able to compile in your ide without errors. Please make the changes on your branch and the push the changes to github.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] EdColeman commented on pull request #2055: Renamed fields
Posted by GitBox <gi...@apache.org>.
EdColeman commented on pull request #2055:
URL: https://github.com/apache/accumulo/pull/2055#issuecomment-830843875
Thanks for the contribution @himanshu007-creator and welcome to the Apache Accumulo community. If you would like to be listed as a contributor on Accumulo's people page please make a website PR for people.md. https://github.com/apache/accumulo-website/edit/main/pages/people.md
If you intend to make more contributions, please consider subscribing to the dev list and introducing yourself. Also, you can use the dev list or slack to reach out if you have questions about anything. https://accumulo.apache.org/contact-us/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] EdColeman edited a comment on pull request #2055: Renamed fields
Posted by GitBox <gi...@apache.org>.
EdColeman edited a comment on pull request #2055:
URL: https://github.com/apache/accumulo/pull/2055#issuecomment-830824055
The lines that need changed are:
[line 366](https://github.com/apache/accumulo/blob/4f35e6aff1763d4b19d1e93036260094b47cc589/server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServerResourceManager.java#L366)
[line 370](https://github.com/apache/accumulo/blob/4f35e6aff1763d4b19d1e93036260094b47cc589/server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServerResourceManager.java#L370)
[line 862](https://github.com/apache/accumulo/blob/4f35e6aff1763d4b19d1e93036260094b47cc589/server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServerResourceManager.java#L862)
The output from running a maven build looks like:
<details>
<summary>Click to expand!</summary>
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.1:compile (default-compile) on project accumulo-tserver: Compilation failure: Compilation failure:
[ERROR] /home/auser/workspace/accumulo/server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServerResourceManager.java:[366,5] cannot find symbol
[ERROR] symbol: variable summaryPartitionPool
[ERROR] location: class org.apache.accumulo.tserver.TabletServerResourceManager
[ERROR] /home/auser/workspace/accumulo/server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServerResourceManager.java:[370,51] cannot find symbol
[ERROR] symbol: variable summaryParitionPool
[ERROR] location: class org.apache.accumulo.tserver.TabletServerResourceManager
[ERROR] /home/auser/workspace/accumulo/server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServerResourceManager.java:[862,12] cannot find symbol
[ERROR] symbol: variable summaryParitionPool
[ERROR] location: class org.apache.accumulo.tserver.TabletServerResourceManager
</details>
You should at least be able to compile in your ide without errors. Please make the changes on your branch and the push the changes to github.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] EdColeman commented on pull request #2055: Renamed fields
Posted by GitBox <gi...@apache.org>.
EdColeman commented on pull request #2055:
URL: https://github.com/apache/accumulo/pull/2055#issuecomment-830843478
Fix #2053 Fix typo - rename summaryParitionPool to summaryPartitionPool
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] EdColeman edited a comment on pull request #2055: Renamed fields
Posted by GitBox <gi...@apache.org>.
EdColeman edited a comment on pull request #2055:
URL: https://github.com/apache/accumulo/pull/2055#issuecomment-830843875
Thanks for the contribution @himanshu007-creator and welcome to the Apache Accumulo community. If you would like to be listed as a contributor on Accumulo's people page please make a website PR for people.md. https://github.com/apache/accumulo-website/edit/main/pages/people.md
If you intend to make more contributions, please consider subscribing to the dev list and introducing yourself. Also, you can use the dev list or slack to reach out if you have questions about anything. https://accumulo.apache.org/contact-us/
To update the website:
1. Checkout the accumulo-website project
2. Update the (./accumulo-website/pages/people.md )[https://github.com/apache/accumulo-website/blob/main/pages/people.md]
- add your name and other information if you want under, the Contributors section.
- names should be in alphabetical order
- include a reference to your original contribution.
3, Submit the changes as PR to the accumulo-website project.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] EdColeman merged pull request #2055: Renamed fields
Posted by GitBox <gi...@apache.org>.
EdColeman merged pull request #2055:
URL: https://github.com/apache/accumulo/pull/2055
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] himanshu007-creator commented on a change in pull request #2055: Renamed fields
Posted by GitBox <gi...@apache.org>.
himanshu007-creator commented on a change in pull request #2055:
URL: https://github.com/apache/accumulo/pull/2055#discussion_r624722941
##########
File path: server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServerResourceManager.java
##########
@@ -98,7 +98,7 @@
private final ExecutorService assignmentPool;
private final ExecutorService assignMetaDataPool;
private final ExecutorService summaryRetrievalPool;
- private final ExecutorService summaryParitionPool;
+ private final ExecutorService summaryParititionPool;
Review comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] EdColeman commented on a change in pull request #2055: Renamed fields
Posted by GitBox <gi...@apache.org>.
EdColeman commented on a change in pull request #2055:
URL: https://github.com/apache/accumulo/pull/2055#discussion_r624721775
##########
File path: server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServerResourceManager.java
##########
@@ -98,7 +98,7 @@
private final ExecutorService assignmentPool;
private final ExecutorService assignMetaDataPool;
private final ExecutorService summaryRetrievalPool;
- private final ExecutorService summaryParitionPool;
+ private final ExecutorService summaryParititionPool;
Review comment:
This should be summaryPartitionPool
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] brianloss commented on pull request #2055: Renamed fields
Posted by GitBox <gi...@apache.org>.
brianloss commented on pull request #2055:
URL: https://github.com/apache/accumulo/pull/2055#issuecomment-830194140
> As suggested from @brianloss on another issue: If you have or can install Docker, then you could try building from a Docker container. Something like [maven](https://hub.docker.com/_/maven) probably work if you volume mount your source directory. Either that or a linux vm (either local or hosted) are options.
I played around a little bit on a Windows VM, and discovered that WSL 2 works quite well if that's an option for you. I installed the Ubuntu 20.04 distro and had to install JDK, Maven, make, and g++ and I was able to do a build w/o tests. Docker for Windows made me install WSL (there is a hyper-v option too, but didn't work for me since I was already in a VM I think), so no benefit to Docker in that case. If you want Docker for other reasons (e.g., not installing tools), unfortunately the maven images don't quite work since they don't include the necessary tools to build the native libs. It's pretty easy to build an image on top of the maven ones, though. For example, I had the following Dockerfile to build an image:
```dockerfile
FROM maven:3-jdk-11-slim
RUN apt-get update && apt install -y g++ make && rm -rf /var/lib/apt/lists/*
```
With my custom image, I was able to do a full build (again, skipping test execution). I just followed the instructions on the [maven](https://hub.docker.com/_/maven) image page for running and also to reuse the m2 repository (you don't want to have to download all of the dependencies every time).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org