You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2019/03/17 03:15:59 UTC

[GitHub] [incubator-skywalking] BFergerson edited a comment on issue #2353: USE_QUALIFIED_NAME_AS_ENDPOINT_NAME configuration

BFergerson edited a comment on issue #2353: USE_QUALIFIED_NAME_AS_ENDPOINT_NAME configuration
URL: https://github.com/apache/incubator-skywalking/pull/2353#issuecomment-473612097
 
 
   @wu-sheng, before reading your suggestions I came up with `spring-with-request-method-op-name-scenario`. How does that sound? I've pushed that here: https://github.com/SkyAPMTest/agent-auto-integration-testcases/pull/55
   
   Also, an unforeseen side effect with the way the `PathMappingCache` works (I believe) is that I ended up with endpoint names like:
    - `/requestmethod/{GET}/acceptGetExplicit`
    - `/requestmethod/{GET,HEAD,POST,PUT,PATCH,DELETE,OPTIONS,TRACE}/acceptAllExplicit`
   
   I think these might be a bit confusing. Suggestions?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services