[jira] [Commented] (SPARK-7200) Tungsten test suites should fail if memory leak is detected

["Josh Rosen (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SPARK-7200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14538674#comment-14538674 ] 

Josh Rosen commented on SPARK-7200:
-----------------------------------

We should consider how we want to handle memory leaks from failed tests.  While working on a recent patch, I had a test that called some protected internal methods that were exposed for testing (via {{@VisibleForTesting}}).  When these methods are called internally, they're called in try-finally blocks that ensure proper resource cleanup.  When we call these from a test suite, we may end up skipping cleanup if our tests fail with an exception.  As a result, we might want our test fixture to always clean up leaked memory but to only fail the test if it would have otherwise passed in order to ensure that actual test failure messages aren't masked by memory leak error messages that were triggered by the test failure.

> Tungsten test suites should fail if memory leak is detected
> -----------------------------------------------------------
>
>                 Key: SPARK-7200
>                 URL: https://issues.apache.org/jira/browse/SPARK-7200
>             Project: Spark
>          Issue Type: New Feature
>          Components: SQL
>            Reporter: Reynold Xin
>
> We should be able to detect whether there are unreturned memory after each suite and fail the suite.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org