You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/12/15 01:29:53 UTC
[GitHub] [incubator-superset] betodealmeida opened a new pull request #12049: feat: show missing parameters in query
betodealmeida opened a new pull request #12049:
URL: https://github.com/apache/incubator-superset/pull/12049
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
This PR makes SQL Lab discriminate errors that happen because of missing parameters in the query, showing them as "Parameter Error" instead of "Database Error".
The error component in SQL Lab seems to be outdated, but I didn't want to change it now since we would like to include this fix before 1.0. Since I'm using [SIP-40](https://github.com/apache/incubator-superset/issues/9194) for the error in the backend, hopefully we can migrate SQL Lab to use something like `<DatabaseErrorMessage />` and it will Just Work™.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
Tested manually (see screenshot) and also added a unit test.
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] robdiciuccio commented on a change in pull request #12049: feat: show missing parameters in query
Posted by GitBox <gi...@apache.org>.
robdiciuccio commented on a change in pull request #12049:
URL: https://github.com/apache/incubator-superset/pull/12049#discussion_r546044463
##########
File path: superset/views/core.py
##########
@@ -2506,6 +2514,28 @@ def sql_json_exec( # pylint: disable=too-many-statements,too-many-locals
f"Query {query_id}: Template syntax error: {error_msg}"
)
+ # pylint: disable=protected-access
+ if is_feature_enabled("ENABLE_TEMPLATE_PROCESSING"):
+ ast = template_processor._env.parse(rendered_query)
+ undefined = find_undeclared_variables(ast) # type: ignore
Review comment:
It's not guaranteed that the template processor with be Jinja-based, due to how `CUSTOM_TEMPLATE_PROCESSORS` operates. I suggest checking that `template_processor` is an instance of `JinjaTemplateProcessor` here instead of checking `ENABLE_TEMPLATE_PROCESSING`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] eschutho commented on a change in pull request #12049: feat: show missing parameters in query
Posted by GitBox <gi...@apache.org>.
eschutho commented on a change in pull request #12049:
URL: https://github.com/apache/incubator-superset/pull/12049#discussion_r543752535
##########
File path: superset/views/core.py
##########
@@ -2506,6 +2509,32 @@ def sql_json_exec( # pylint: disable=too-many-statements,too-many-locals
f"Query {query_id}: Template syntax error: {error_msg}"
)
+ # pylint: disable=protected-access
+ if is_feature_enabled("ENABLE_TEMPLATE_PROCESSING"):
+ ast = template_processor._env.parse(rendered_query)
+ undefined = find_undeclared_variables(ast) # type: ignore
+ if undefined:
+ error = SupersetError(
+ message=ngettext(
+ "There's an error with the parameter %(parameters)s. Please check "
+ "your template parameters for syntax errors and make sure they "
+ "match across your SQL query and Set Parameters. Then, try "
+ "running your query again.",
+ "There's an error with the parameters %(parameters)s. Please check "
+ "your template parameters for syntax errors and make sure they "
+ "match across your SQL query and Set Parameters. Then, try "
+ "running your query again.",
Review comment:
can we dry up this duplicated string?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] robdiciuccio commented on a change in pull request #12049: feat: show missing parameters in query
Posted by GitBox <gi...@apache.org>.
robdiciuccio commented on a change in pull request #12049:
URL: https://github.com/apache/incubator-superset/pull/12049#discussion_r546047041
##########
File path: superset/views/core.py
##########
@@ -2506,6 +2514,28 @@ def sql_json_exec( # pylint: disable=too-many-statements,too-many-locals
f"Query {query_id}: Template syntax error: {error_msg}"
)
+ # pylint: disable=protected-access
+ if is_feature_enabled("ENABLE_TEMPLATE_PROCESSING"):
+ ast = template_processor._env.parse(rendered_query)
Review comment:
Nit: accessing a private property from outside the class
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12049: feat: show missing parameters in query
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12049:
URL: https://github.com/apache/incubator-superset/pull/12049#issuecomment-745003381
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12049?src=pr&el=h1) Report
> Merging [#12049](https://codecov.io/gh/apache/incubator-superset/pull/12049?src=pr&el=desc) (29e27eb) into [master](https://codecov.io/gh/apache/incubator-superset/commit/3d56f58ef53e21912dac425cb49ae7610915b608?el=desc) (3d56f58) will **decrease** coverage by `3.09%`.
> The diff coverage is `84.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/12049?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12049 +/- ##
==========================================
- Coverage 66.58% 63.48% -3.10%
==========================================
Files 952 957 +5
Lines 46703 47008 +305
Branches 4578 4594 +16
==========================================
- Hits 31096 29843 -1253
- Misses 15458 16980 +1522
- Partials 149 185 +36
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `62.54% <55.55%> (-0.16%)` | :arrow_down: |
| python | `64.05% <100.00%> (-0.54%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12049?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rset-frontend/src/components/ErrorMessage/types.ts](https://codecov.io/gh/apache/incubator-superset/pull/12049/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL3R5cGVzLnRz) | `100.00% <ø> (ø)` | |
| [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12049/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `49.41% <25.00%> (-2.35%)` | :arrow_down: |
| [...erset-frontend/src/SqlLab/components/ResultSet.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12049/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1Jlc3VsdFNldC50c3g=) | `66.97% <75.00%> (+0.15%)` | :arrow_up: |
| [superset-frontend/src/featureFlags.ts](https://codecov.io/gh/apache/incubator-superset/pull/12049/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZlYXR1cmVGbGFncy50cw==) | `87.50% <100.00%> (-12.50%)` | :arrow_down: |
| [superset/errors.py](https://codecov.io/gh/apache/incubator-superset/pull/12049/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/jinja\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/12049/diff?src=pr&el=tree#diff-c3VwZXJzZXQvamluamFfY29udGV4dC5weQ==) | `87.57% <100.00%> (+0.07%)` | :arrow_up: |
| [superset/utils/core.py](https://codecov.io/gh/apache/incubator-superset/pull/12049/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `89.26% <100.00%> (+0.04%)` | :arrow_up: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/12049/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `72.93% <100.00%> (-2.30%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12049/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12049/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [190 more](https://codecov.io/gh/apache/incubator-superset/pull/12049/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12049?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12049?src=pr&el=footer). Last update [3d56f58...29e27eb](https://codecov.io/gh/apache/incubator-superset/pull/12049?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] robdiciuccio commented on a change in pull request #12049: feat: show missing parameters in query
Posted by GitBox <gi...@apache.org>.
robdiciuccio commented on a change in pull request #12049:
URL: https://github.com/apache/incubator-superset/pull/12049#discussion_r546041615
##########
File path: superset/jinja_context.py
##########
@@ -296,7 +297,7 @@ def __init__(
self._schema = table.schema
self._extra_cache_keys = extra_cache_keys
self._context: Dict[str, Any] = {}
- self._env = SandboxedEnvironment()
+ self._env = SandboxedEnvironment(undefined=DebugUndefined)
Review comment:
Is `DebugUndefined` required to make `find_undeclared_variables` function? Doesn't seem to be a requirement in the docs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] betodealmeida commented on a change in pull request #12049: feat: show missing parameters in query
Posted by GitBox <gi...@apache.org>.
betodealmeida commented on a change in pull request #12049:
URL: https://github.com/apache/incubator-superset/pull/12049#discussion_r546019040
##########
File path: superset/views/core.py
##########
@@ -2506,6 +2514,28 @@ def sql_json_exec( # pylint: disable=too-many-statements,too-many-locals
f"Query {query_id}: Template syntax error: {error_msg}"
)
+ # pylint: disable=protected-access
+ if is_feature_enabled("ENABLE_TEMPLATE_PROCESSING"):
+ ast = template_processor._env.parse(rendered_query)
+ undefined = find_undeclared_variables(ast) # type: ignore
Review comment:
@robdiciuccio want to confirm that this is ok?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] etr2460 commented on a change in pull request #12049: feat: show missing parameters in query
Posted by GitBox <gi...@apache.org>.
etr2460 commented on a change in pull request #12049:
URL: https://github.com/apache/incubator-superset/pull/12049#discussion_r543527197
##########
File path: superset/errors.py
##########
@@ -100,6 +103,15 @@ class SupersetErrorType(str, Enum):
),
},
],
+ SupersetErrorType.MISSING_TEMPLATE_PARAMS_ERROR: [
Review comment:
wanna update the docs file with the issue codes too?
##########
File path: superset-frontend/src/SqlLab/components/ResultSet.tsx
##########
@@ -489,10 +490,15 @@ export default class ResultSet extends React.PureComponent<
return <Alert bsStyle="warning">Query was stopped</Alert>;
}
if (query.state === 'failed') {
+ const title =
+ query?.errors?.[0].error_type ===
+ ErrorTypeEnum.MISSING_TEMPLATE_PARAMS_ERROR
+ ? t('Parameter Error')
+ : t('Database Error');
Review comment:
yeah, ideally this logic would be handled by the error component registry, but since we're not using the new error format for all SQL Lab errors, that's not possible yet. Maybe add a todo comment to clean this up?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io commented on pull request #12049: feat: show missing parameters in query
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #12049:
URL: https://github.com/apache/incubator-superset/pull/12049#issuecomment-745003381
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12049?src=pr&el=h1) Report
> Merging [#12049](https://codecov.io/gh/apache/incubator-superset/pull/12049?src=pr&el=desc) (792fede) into [master](https://codecov.io/gh/apache/incubator-superset/commit/3d56f58ef53e21912dac425cb49ae7610915b608?el=desc) (3d56f58) will **decrease** coverage by `13.89%`.
> The diff coverage is `37.50%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/12049?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12049 +/- ##
===========================================
- Coverage 66.58% 52.68% -13.90%
===========================================
Files 952 436 -516
Lines 46703 15697 -31006
Branches 4578 4060 -518
===========================================
- Hits 31096 8270 -22826
+ Misses 15458 7427 -8031
+ Partials 149 0 -149
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `52.68% <37.50%> (+9.87%)` | :arrow_up: |
| javascript | `?` | |
| python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12049?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...erset-frontend/src/SqlLab/components/ResultSet.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12049/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1Jlc3VsdFNldC50c3g=) | `4.10% <0.00%> (-62.72%)` | :arrow_down: |
| [...rset-frontend/src/components/ErrorMessage/types.ts](https://codecov.io/gh/apache/incubator-superset/pull/12049/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL3R5cGVzLnRz) | `100.00% <ø> (ø)` | |
| [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12049/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `46.74% <50.00%> (-5.02%)` | :arrow_down: |
| [superset-frontend/src/featureFlags.ts](https://codecov.io/gh/apache/incubator-superset/pull/12049/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZlYXR1cmVGbGFncy50cw==) | `100.00% <100.00%> (ø)` | |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/incubator-superset/pull/12049/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/incubator-superset/pull/12049/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12049/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/incubator-superset/pull/12049/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.48%)` | :arrow_down: |
| [...set-frontend/src/views/CRUD/alert/ExecutionLog.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12049/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvRXhlY3V0aW9uTG9nLnRzeA==) | `11.76% <0.00%> (-88.24%)` | :arrow_down: |
| [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12049/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `10.52% <0.00%> (-86.85%)` | :arrow_down: |
| ... and [825 more](https://codecov.io/gh/apache/incubator-superset/pull/12049/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12049?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12049?src=pr&el=footer). Last update [3d56f58...792fede](https://codecov.io/gh/apache/incubator-superset/pull/12049?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12049: feat: show missing parameters in query
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12049:
URL: https://github.com/apache/incubator-superset/pull/12049#issuecomment-745003381
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12049?src=pr&el=h1) Report
> Merging [#12049](https://codecov.io/gh/apache/incubator-superset/pull/12049?src=pr&el=desc) (b00b609) into [master](https://codecov.io/gh/apache/incubator-superset/commit/3d56f58ef53e21912dac425cb49ae7610915b608?el=desc) (3d56f58) will **decrease** coverage by `3.18%`.
> The diff coverage is `83.33%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/12049?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12049 +/- ##
==========================================
- Coverage 66.58% 63.39% -3.19%
==========================================
Files 952 956 +4
Lines 46703 46866 +163
Branches 4578 4595 +17
==========================================
- Hits 31096 29710 -1386
- Misses 15458 16971 +1513
- Partials 149 185 +36
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `62.53% <55.55%> (-0.17%)` | :arrow_down: |
| python | `63.91% <100.00%> (-0.68%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12049?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rset-frontend/src/components/ErrorMessage/types.ts](https://codecov.io/gh/apache/incubator-superset/pull/12049/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL3R5cGVzLnRz) | `100.00% <ø> (ø)` | |
| [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12049/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `49.41% <25.00%> (-2.35%)` | :arrow_down: |
| [...erset-frontend/src/SqlLab/components/ResultSet.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12049/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1Jlc3VsdFNldC50c3g=) | `66.97% <75.00%> (+0.15%)` | :arrow_up: |
| [superset-frontend/src/featureFlags.ts](https://codecov.io/gh/apache/incubator-superset/pull/12049/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZlYXR1cmVGbGFncy50cw==) | `87.50% <100.00%> (-12.50%)` | :arrow_down: |
| [superset/errors.py](https://codecov.io/gh/apache/incubator-superset/pull/12049/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/jinja\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/12049/diff?src=pr&el=tree#diff-c3VwZXJzZXQvamluamFfY29udGV4dC5weQ==) | `87.57% <100.00%> (+0.07%)` | :arrow_up: |
| [superset/utils/core.py](https://codecov.io/gh/apache/incubator-superset/pull/12049/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `89.26% <100.00%> (+0.04%)` | :arrow_up: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/12049/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.39% <100.00%> (+0.16%)` | :arrow_up: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12049/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12049/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [175 more](https://codecov.io/gh/apache/incubator-superset/pull/12049/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12049?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12049?src=pr&el=footer). Last update [3d56f58...b00b609](https://codecov.io/gh/apache/incubator-superset/pull/12049?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12049: feat: show missing parameters in query
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12049:
URL: https://github.com/apache/incubator-superset/pull/12049#issuecomment-745003381
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12049?src=pr&el=h1) Report
> Merging [#12049](https://codecov.io/gh/apache/incubator-superset/pull/12049?src=pr&el=desc) (29e27eb) into [master](https://codecov.io/gh/apache/incubator-superset/commit/3d56f58ef53e21912dac425cb49ae7610915b608?el=desc) (3d56f58) will **decrease** coverage by `3.09%`.
> The diff coverage is `84.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/12049?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12049 +/- ##
==========================================
- Coverage 66.58% 63.48% -3.10%
==========================================
Files 952 957 +5
Lines 46703 47010 +307
Branches 4578 4594 +16
==========================================
- Hits 31096 29845 -1251
- Misses 15458 16980 +1522
- Partials 149 185 +36
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `62.54% <55.55%> (-0.16%)` | :arrow_down: |
| python | `64.05% <100.00%> (-0.54%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12049?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rset-frontend/src/components/ErrorMessage/types.ts](https://codecov.io/gh/apache/incubator-superset/pull/12049/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL3R5cGVzLnRz) | `100.00% <ø> (ø)` | |
| [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12049/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `49.41% <25.00%> (-2.35%)` | :arrow_down: |
| [...erset-frontend/src/SqlLab/components/ResultSet.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12049/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1Jlc3VsdFNldC50c3g=) | `66.97% <75.00%> (+0.15%)` | :arrow_up: |
| [superset-frontend/src/featureFlags.ts](https://codecov.io/gh/apache/incubator-superset/pull/12049/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZlYXR1cmVGbGFncy50cw==) | `87.50% <100.00%> (-12.50%)` | :arrow_down: |
| [superset/errors.py](https://codecov.io/gh/apache/incubator-superset/pull/12049/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/jinja\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/12049/diff?src=pr&el=tree#diff-c3VwZXJzZXQvamluamFfY29udGV4dC5weQ==) | `87.57% <100.00%> (+0.07%)` | :arrow_up: |
| [superset/utils/core.py](https://codecov.io/gh/apache/incubator-superset/pull/12049/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `89.26% <100.00%> (+0.04%)` | :arrow_up: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/12049/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `72.93% <100.00%> (-2.30%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12049/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12049/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [188 more](https://codecov.io/gh/apache/incubator-superset/pull/12049/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12049?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12049?src=pr&el=footer). Last update [3d56f58...29e27eb](https://codecov.io/gh/apache/incubator-superset/pull/12049?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] etr2460 commented on a change in pull request #12049: feat: show missing parameters in query
Posted by GitBox <gi...@apache.org>.
etr2460 commented on a change in pull request #12049:
URL: https://github.com/apache/incubator-superset/pull/12049#discussion_r543576695
##########
File path: superset/errors.py
##########
@@ -100,6 +103,15 @@ class SupersetErrorType(str, Enum):
),
},
],
+ SupersetErrorType.MISSING_TEMPLATE_PARAMS_ERROR: [
Review comment:
If you wanted to add a comment in this file with those details too, that would be much appreciated!
It's the `issue_codes.mdx` file that should be updated
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] betodealmeida commented on a change in pull request #12049: feat: show missing parameters in query
Posted by GitBox <gi...@apache.org>.
betodealmeida commented on a change in pull request #12049:
URL: https://github.com/apache/incubator-superset/pull/12049#discussion_r543557031
##########
File path: superset/errors.py
##########
@@ -100,6 +103,15 @@ class SupersetErrorType(str, Enum):
),
},
],
+ SupersetErrorType.MISSING_TEMPLATE_PARAMS_ERROR: [
Review comment:
Will do, I wasn't aware we had a doc describing them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on a change in pull request #12049: feat: show missing parameters in query
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #12049:
URL: https://github.com/apache/incubator-superset/pull/12049#discussion_r543766325
##########
File path: superset/utils/core.py
##########
@@ -1669,3 +1669,10 @@ def get_time_filter_status( # pylint: disable=too-many-branches
)
return applied, rejected
+
+
+def format_list(items: Sequence[str], sep: str = ", ", quote: str = '"') -> str:
+ items = [
+ "".join((quote, item.replace(quote, "\\" + quote), quote)) for item in items
Review comment:
Nit: can probably use a formatted string instead of join here to make it easier to read.
```python
def format_list(items: Sequence[str], sep: str = ", ", quote: str = '"') -> str:
return sep.join(f'{quote}{x.replace(quote, "\\" + quote)}{quote}' for x in items)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] betodealmeida commented on a change in pull request #12049: feat: show missing parameters in query
Posted by GitBox <gi...@apache.org>.
betodealmeida commented on a change in pull request #12049:
URL: https://github.com/apache/incubator-superset/pull/12049#discussion_r543805324
##########
File path: superset/utils/core.py
##########
@@ -1669,3 +1669,10 @@ def get_time_filter_status( # pylint: disable=too-many-branches
)
return applied, rejected
+
+
+def format_list(items: Sequence[str], sep: str = ", ", quote: str = '"') -> str:
+ items = [
+ "".join((quote, item.replace(quote, "\\" + quote), quote)) for item in items
Review comment:
Cool, let me change it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12049: feat: show missing parameters in query
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12049:
URL: https://github.com/apache/incubator-superset/pull/12049#issuecomment-745003381
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12049?src=pr&el=h1) Report
> Merging [#12049](https://codecov.io/gh/apache/incubator-superset/pull/12049?src=pr&el=desc) (b00b609) into [master](https://codecov.io/gh/apache/incubator-superset/commit/3d56f58ef53e21912dac425cb49ae7610915b608?el=desc) (3d56f58) will **increase** coverage by `0.97%`.
> The diff coverage is `87.50%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/12049?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12049 +/- ##
==========================================
+ Coverage 66.58% 67.56% +0.97%
==========================================
Files 952 956 +4
Lines 46703 46880 +177
Branches 4578 4595 +17
==========================================
+ Hits 31096 31673 +577
+ Misses 15458 15090 -368
+ Partials 149 117 -32
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `52.64% <37.50%> (+9.83%)` | :arrow_up: |
| javascript | `62.53% <55.55%> (-0.17%)` | :arrow_down: |
| python | `64.49% <100.00%> (-0.10%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12049?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rset-frontend/src/components/ErrorMessage/types.ts](https://codecov.io/gh/apache/incubator-superset/pull/12049/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL3R5cGVzLnRz) | `100.00% <ø> (ø)` | |
| [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12049/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `51.16% <50.00%> (-0.61%)` | :arrow_down: |
| [...erset-frontend/src/SqlLab/components/ResultSet.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12049/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1Jlc3VsdFNldC50c3g=) | `66.97% <75.00%> (+0.15%)` | :arrow_up: |
| [superset-frontend/src/featureFlags.ts](https://codecov.io/gh/apache/incubator-superset/pull/12049/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZlYXR1cmVGbGFncy50cw==) | `100.00% <100.00%> (ø)` | |
| [superset/errors.py](https://codecov.io/gh/apache/incubator-superset/pull/12049/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/jinja\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/12049/diff?src=pr&el=tree#diff-c3VwZXJzZXQvamluamFfY29udGV4dC5weQ==) | `87.57% <100.00%> (+0.07%)` | :arrow_up: |
| [superset/utils/core.py](https://codecov.io/gh/apache/incubator-superset/pull/12049/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `89.26% <100.00%> (+0.04%)` | :arrow_up: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/12049/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.39% <100.00%> (+0.16%)` | :arrow_up: |
| [...et-frontend/src/SqlLab/reducers/getInitialState.js](https://codecov.io/gh/apache/incubator-superset/pull/12049/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `33.33% <0.00%> (-16.67%)` | :arrow_down: |
| [...perset-frontend/src/views/CRUD/alert/AlertList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12049/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvQWxlcnRMaXN0LnRzeA==) | `63.95% <0.00%> (-11.96%)` | :arrow_down: |
| ... and [105 more](https://codecov.io/gh/apache/incubator-superset/pull/12049/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12049?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12049?src=pr&el=footer). Last update [3d56f58...b00b609](https://codecov.io/gh/apache/incubator-superset/pull/12049?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12049: feat: show missing parameters in query
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12049:
URL: https://github.com/apache/incubator-superset/pull/12049#issuecomment-745003381
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12049?src=pr&el=h1) Report
> Merging [#12049](https://codecov.io/gh/apache/incubator-superset/pull/12049?src=pr&el=desc) (8057439) into [master](https://codecov.io/gh/apache/incubator-superset/commit/3d56f58ef53e21912dac425cb49ae7610915b608?el=desc) (3d56f58) will **decrease** coverage by `13.47%`.
> The diff coverage is `62.50%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/12049?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12049 +/- ##
===========================================
- Coverage 66.58% 53.11% -13.48%
===========================================
Files 952 438 -514
Lines 46703 15718 -30985
Branches 4578 4063 -515
===========================================
- Hits 31096 8348 -22748
+ Misses 15458 7370 -8088
+ Partials 149 0 -149
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `53.11% <62.50%> (+10.29%)` | :arrow_up: |
| javascript | `?` | |
| python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12049?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...erset-frontend/src/SqlLab/components/ResultSet.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12049/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1Jlc3VsdFNldC50c3g=) | `4.10% <0.00%> (-62.72%)` | :arrow_down: |
| [...rset-frontend/src/components/ErrorMessage/types.ts](https://codecov.io/gh/apache/incubator-superset/pull/12049/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL3R5cGVzLnRz) | `100.00% <ø> (ø)` | |
| [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12049/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `47.92% <100.00%> (-3.84%)` | :arrow_down: |
| [superset-frontend/src/featureFlags.ts](https://codecov.io/gh/apache/incubator-superset/pull/12049/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZlYXR1cmVGbGFncy50cw==) | `100.00% <100.00%> (ø)` | |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/incubator-superset/pull/12049/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/incubator-superset/pull/12049/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12049/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/incubator-superset/pull/12049/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.48%)` | :arrow_down: |
| [...set-frontend/src/views/CRUD/alert/ExecutionLog.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12049/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvRXhlY3V0aW9uTG9nLnRzeA==) | `11.76% <0.00%> (-88.24%)` | :arrow_down: |
| [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12049/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `10.52% <0.00%> (-86.85%)` | :arrow_down: |
| ... and [828 more](https://codecov.io/gh/apache/incubator-superset/pull/12049/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12049?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12049?src=pr&el=footer). Last update [3d56f58...29e27eb](https://codecov.io/gh/apache/incubator-superset/pull/12049?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on a change in pull request #12049: feat: show missing parameters in query
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #12049:
URL: https://github.com/apache/incubator-superset/pull/12049#discussion_r543792192
##########
File path: superset/utils/core.py
##########
@@ -1669,3 +1669,10 @@ def get_time_filter_status( # pylint: disable=too-many-branches
)
return applied, rejected
+
+
+def format_list(items: Sequence[str], sep: str = ", ", quote: str = '"') -> str:
+ items = [
+ "".join((quote, item.replace(quote, "\\" + quote), quote)) for item in items
Review comment:
```python
def format_list(items: Sequence[str], sep: str = ", ", quote: str = '"') -> str:
quote_escaped = "\\" + quote
return sep.join(f'{quote}{x.replace(quote, quote_escaped)}{quote}' for x in items)
```
How about this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12049: feat: show missing parameters in query
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12049:
URL: https://github.com/apache/incubator-superset/pull/12049#issuecomment-745003381
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] betodealmeida commented on a change in pull request #12049: feat: show missing parameters in query
Posted by GitBox <gi...@apache.org>.
betodealmeida commented on a change in pull request #12049:
URL: https://github.com/apache/incubator-superset/pull/12049#discussion_r543787543
##########
File path: superset/utils/core.py
##########
@@ -1669,3 +1669,10 @@ def get_time_filter_status( # pylint: disable=too-many-branches
)
return applied, rejected
+
+
+def format_list(items: Sequence[str], sep: str = ", ", quote: str = '"') -> str:
+ items = [
+ "".join((quote, item.replace(quote, "\\" + quote), quote)) for item in items
Review comment:
That was my original approach, but then I discovered that you cannot use backslashes inside an f-string.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] betodealmeida merged pull request #12049: feat: show missing parameters in query
Posted by GitBox <gi...@apache.org>.
betodealmeida merged pull request #12049:
URL: https://github.com/apache/incubator-superset/pull/12049
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] betodealmeida commented on a change in pull request #12049: feat: show missing parameters in query
Posted by GitBox <gi...@apache.org>.
betodealmeida commented on a change in pull request #12049:
URL: https://github.com/apache/incubator-superset/pull/12049#discussion_r543781832
##########
File path: superset/views/core.py
##########
@@ -2506,6 +2509,32 @@ def sql_json_exec( # pylint: disable=too-many-statements,too-many-locals
f"Query {query_id}: Template syntax error: {error_msg}"
)
+ # pylint: disable=protected-access
+ if is_feature_enabled("ENABLE_TEMPLATE_PROCESSING"):
+ ast = template_processor._env.parse(rendered_query)
+ undefined = find_undeclared_variables(ast) # type: ignore
+ if undefined:
+ error = SupersetError(
+ message=ngettext(
+ "There's an error with the parameter %(parameters)s. Please check "
+ "your template parameters for syntax errors and make sure they "
+ "match across your SQL query and Set Parameters. Then, try "
+ "running your query again.",
+ "There's an error with the parameters %(parameters)s. Please check "
+ "your template parameters for syntax errors and make sure they "
+ "match across your SQL query and Set Parameters. Then, try "
+ "running your query again.",
Review comment:
Yet, let me fix this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12049: feat: show missing parameters in query
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12049:
URL: https://github.com/apache/incubator-superset/pull/12049#issuecomment-745003381
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12049?src=pr&el=h1) Report
> Merging [#12049](https://codecov.io/gh/apache/incubator-superset/pull/12049?src=pr&el=desc) (29e27eb) into [master](https://codecov.io/gh/apache/incubator-superset/commit/3d56f58ef53e21912dac425cb49ae7610915b608?el=desc) (3d56f58) will **decrease** coverage by `2.52%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/12049?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12049 +/- ##
==========================================
- Coverage 66.58% 64.05% -2.53%
==========================================
Files 952 474 -478
Lines 46703 29282 -17421
Branches 4578 0 -4578
==========================================
- Hits 31096 18757 -12339
+ Misses 15458 10525 -4933
+ Partials 149 0 -149
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `64.05% <100.00%> (-0.54%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12049?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/errors.py](https://codecov.io/gh/apache/incubator-superset/pull/12049/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/jinja\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/12049/diff?src=pr&el=tree#diff-c3VwZXJzZXQvamluamFfY29udGV4dC5weQ==) | `87.57% <100.00%> (+0.07%)` | :arrow_up: |
| [superset/utils/core.py](https://codecov.io/gh/apache/incubator-superset/pull/12049/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `89.26% <100.00%> (+0.04%)` | :arrow_up: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/12049/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `72.93% <100.00%> (-2.30%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/12049/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/datasets/commands/importers/v1/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/12049/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL3V0aWxzLnB5) | `58.62% <0.00%> (-34.24%)` | :arrow_down: |
| [superset/datasets/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/12049/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvZXhwb3J0LnB5) | `78.72% <0.00%> (-15.40%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/12049/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/12049/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/12049/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
| ... and [512 more](https://codecov.io/gh/apache/incubator-superset/pull/12049/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12049?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12049?src=pr&el=footer). Last update [3d56f58...29e27eb](https://codecov.io/gh/apache/incubator-superset/pull/12049?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] betodealmeida commented on a change in pull request #12049: feat: show missing parameters in query
Posted by GitBox <gi...@apache.org>.
betodealmeida commented on a change in pull request #12049:
URL: https://github.com/apache/incubator-superset/pull/12049#discussion_r543596021
##########
File path: superset/errors.py
##########
@@ -100,6 +103,15 @@ class SupersetErrorType(str, Enum):
),
},
],
+ SupersetErrorType.MISSING_TEMPLATE_PARAMS_ERROR: [
Review comment:
Will do, thanks! :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] robdiciuccio commented on a change in pull request #12049: feat: show missing parameters in query
Posted by GitBox <gi...@apache.org>.
robdiciuccio commented on a change in pull request #12049:
URL: https://github.com/apache/incubator-superset/pull/12049#discussion_r546046686
##########
File path: superset/views/core.py
##########
@@ -2506,6 +2514,28 @@ def sql_json_exec( # pylint: disable=too-many-statements,too-many-locals
f"Query {query_id}: Template syntax error: {error_msg}"
)
+ # pylint: disable=protected-access
+ if is_feature_enabled("ENABLE_TEMPLATE_PROCESSING"):
+ ast = template_processor._env.parse(rendered_query)
+ undefined = find_undeclared_variables(ast) # type: ignore
Review comment:
Other than that, I don't see any security issues with using `find_undeclared_variables` in this context. I'm assuming that undefined variables don't raise an error during `process_template`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12049: feat: show missing parameters in query
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12049:
URL: https://github.com/apache/incubator-superset/pull/12049#issuecomment-745003381
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12049?src=pr&el=h1) Report
> Merging [#12049](https://codecov.io/gh/apache/incubator-superset/pull/12049?src=pr&el=desc) (8057439) into [master](https://codecov.io/gh/apache/incubator-superset/commit/3d56f58ef53e21912dac425cb49ae7610915b608?el=desc) (3d56f58) will **decrease** coverage by `13.94%`.
> The diff coverage is `37.50%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/12049?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12049 +/- ##
===========================================
- Coverage 66.58% 52.63% -13.95%
===========================================
Files 952 438 -514
Lines 46703 15718 -30985
Branches 4578 4063 -515
===========================================
- Hits 31096 8273 -22823
+ Misses 15458 7445 -8013
+ Partials 149 0 -149
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `52.63% <37.50%> (+9.82%)` | :arrow_up: |
| javascript | `?` | |
| python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12049?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...erset-frontend/src/SqlLab/components/ResultSet.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12049/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1Jlc3VsdFNldC50c3g=) | `4.10% <0.00%> (-62.72%)` | :arrow_down: |
| [...rset-frontend/src/components/ErrorMessage/types.ts](https://codecov.io/gh/apache/incubator-superset/pull/12049/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL3R5cGVzLnRz) | `100.00% <ø> (ø)` | |
| [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12049/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `46.74% <50.00%> (-5.02%)` | :arrow_down: |
| [superset-frontend/src/featureFlags.ts](https://codecov.io/gh/apache/incubator-superset/pull/12049/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZlYXR1cmVGbGFncy50cw==) | `100.00% <100.00%> (ø)` | |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/incubator-superset/pull/12049/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/incubator-superset/pull/12049/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12049/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/incubator-superset/pull/12049/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.48%)` | :arrow_down: |
| [...set-frontend/src/views/CRUD/alert/ExecutionLog.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12049/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvRXhlY3V0aW9uTG9nLnRzeA==) | `11.76% <0.00%> (-88.24%)` | :arrow_down: |
| [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12049/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `10.52% <0.00%> (-86.85%)` | :arrow_down: |
| ... and [829 more](https://codecov.io/gh/apache/incubator-superset/pull/12049/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12049?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12049?src=pr&el=footer). Last update [3d56f58...29e27eb](https://codecov.io/gh/apache/incubator-superset/pull/12049?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12049: feat: show missing parameters in query
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12049:
URL: https://github.com/apache/incubator-superset/pull/12049#issuecomment-745003381
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12049?src=pr&el=h1) Report
> Merging [#12049](https://codecov.io/gh/apache/incubator-superset/pull/12049?src=pr&el=desc) (29e27eb) into [master](https://codecov.io/gh/apache/incubator-superset/commit/3d56f58ef53e21912dac425cb49ae7610915b608?el=desc) (3d56f58) will **decrease** coverage by `2.53%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/12049?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12049 +/- ##
==========================================
- Coverage 66.58% 64.04% -2.54%
==========================================
Files 952 474 -478
Lines 46703 29282 -17421
Branches 4578 0 -4578
==========================================
- Hits 31096 18754 -12342
+ Misses 15458 10528 -4930
+ Partials 149 0 -149
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `64.04% <100.00%> (-0.56%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12049?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/errors.py](https://codecov.io/gh/apache/incubator-superset/pull/12049/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/jinja\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/12049/diff?src=pr&el=tree#diff-c3VwZXJzZXQvamluamFfY29udGV4dC5weQ==) | `87.57% <100.00%> (+0.07%)` | :arrow_up: |
| [superset/utils/core.py](https://codecov.io/gh/apache/incubator-superset/pull/12049/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `89.26% <100.00%> (+0.04%)` | :arrow_up: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/12049/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `72.93% <100.00%> (-2.30%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/12049/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/datasets/commands/importers/v1/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/12049/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL3V0aWxzLnB5) | `58.62% <0.00%> (-34.24%)` | :arrow_down: |
| [superset/datasets/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/12049/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvZXhwb3J0LnB5) | `78.72% <0.00%> (-15.40%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/12049/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/12049/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/12049/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
| ... and [513 more](https://codecov.io/gh/apache/incubator-superset/pull/12049/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12049?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12049?src=pr&el=footer). Last update [3d56f58...29e27eb](https://codecov.io/gh/apache/incubator-superset/pull/12049?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] betodealmeida commented on a change in pull request #12049: feat: show missing parameters in query
Posted by GitBox <gi...@apache.org>.
betodealmeida commented on a change in pull request #12049:
URL: https://github.com/apache/incubator-superset/pull/12049#discussion_r542975832
##########
File path: superset-frontend/src/SqlLab/components/SqlEditor.jsx
##########
@@ -566,13 +566,15 @@ class SqlEditor extends React.PureComponent {
<Checkbox checked={this.state.autocompleteEnabled} />{' '}
{t('Autocomplete')}
</Button>{' '}
- <TemplateParamsEditor
- language="json"
- onChange={params => {
- this.props.actions.queryEditorSetTemplateParams(qe, params);
- }}
- code={qe.templateParams}
- />
+ {isFeatureEnabled(FeatureFlag.ENABLE_TEMPLATE_PROCESSING) && (
Review comment:
We are showing "Parameters" in SQL Lab even though the functionality is now behind a feature flag in the backend. I turned it off here if the functionality is not enabled.
cc: @hughhhh
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12049: feat: show missing parameters in query
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12049:
URL: https://github.com/apache/incubator-superset/pull/12049#issuecomment-745003381
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12049?src=pr&el=h1) Report
> Merging [#12049](https://codecov.io/gh/apache/incubator-superset/pull/12049?src=pr&el=desc) (792fede) into [master](https://codecov.io/gh/apache/incubator-superset/commit/3d56f58ef53e21912dac425cb49ae7610915b608?el=desc) (3d56f58) will **decrease** coverage by `13.41%`.
> The diff coverage is `62.50%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/12049?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12049 +/- ##
===========================================
- Coverage 66.58% 53.16% -13.42%
===========================================
Files 952 436 -516
Lines 46703 15697 -31006
Branches 4578 4060 -518
===========================================
- Hits 31096 8345 -22751
+ Misses 15458 7352 -8106
+ Partials 149 0 -149
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `53.16% <62.50%> (+10.35%)` | :arrow_up: |
| javascript | `?` | |
| python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12049?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...erset-frontend/src/SqlLab/components/ResultSet.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12049/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1Jlc3VsdFNldC50c3g=) | `4.10% <0.00%> (-62.72%)` | :arrow_down: |
| [...rset-frontend/src/components/ErrorMessage/types.ts](https://codecov.io/gh/apache/incubator-superset/pull/12049/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL3R5cGVzLnRz) | `100.00% <ø> (ø)` | |
| [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12049/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `47.92% <100.00%> (-3.84%)` | :arrow_down: |
| [superset-frontend/src/featureFlags.ts](https://codecov.io/gh/apache/incubator-superset/pull/12049/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZlYXR1cmVGbGFncy50cw==) | `100.00% <100.00%> (ø)` | |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/incubator-superset/pull/12049/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/incubator-superset/pull/12049/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12049/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/incubator-superset/pull/12049/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.48%)` | :arrow_down: |
| [...set-frontend/src/views/CRUD/alert/ExecutionLog.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12049/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvRXhlY3V0aW9uTG9nLnRzeA==) | `11.76% <0.00%> (-88.24%)` | :arrow_down: |
| [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12049/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `10.52% <0.00%> (-86.85%)` | :arrow_down: |
| ... and [824 more](https://codecov.io/gh/apache/incubator-superset/pull/12049/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12049?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12049?src=pr&el=footer). Last update [3d56f58...792fede](https://codecov.io/gh/apache/incubator-superset/pull/12049?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12049: feat: show missing parameters in query
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12049:
URL: https://github.com/apache/incubator-superset/pull/12049#issuecomment-745003381
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12049?src=pr&el=h1) Report
> Merging [#12049](https://codecov.io/gh/apache/incubator-superset/pull/12049?src=pr&el=desc) (b00b609) into [master](https://codecov.io/gh/apache/incubator-superset/commit/3d56f58ef53e21912dac425cb49ae7610915b608?el=desc) (3d56f58) will **increase** coverage by `1.08%`.
> The diff coverage is `95.83%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/12049?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12049 +/- ##
==========================================
+ Coverage 66.58% 67.66% +1.08%
==========================================
Files 952 956 +4
Lines 46703 46880 +177
Branches 4578 4595 +17
==========================================
+ Hits 31096 31721 +625
+ Misses 15458 15046 -412
+ Partials 149 113 -36
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `53.12% <62.50%> (+10.31%)` | :arrow_up: |
| javascript | `62.53% <55.55%> (-0.17%)` | :arrow_down: |
| python | `64.49% <100.00%> (-0.10%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12049?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rset-frontend/src/components/ErrorMessage/types.ts](https://codecov.io/gh/apache/incubator-superset/pull/12049/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL3R5cGVzLnRz) | `100.00% <ø> (ø)` | |
| [...erset-frontend/src/SqlLab/components/ResultSet.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12049/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1Jlc3VsdFNldC50c3g=) | `66.97% <75.00%> (+0.15%)` | :arrow_up: |
| [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12049/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `52.32% <100.00%> (+0.56%)` | :arrow_up: |
| [superset-frontend/src/featureFlags.ts](https://codecov.io/gh/apache/incubator-superset/pull/12049/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZlYXR1cmVGbGFncy50cw==) | `100.00% <100.00%> (ø)` | |
| [superset/errors.py](https://codecov.io/gh/apache/incubator-superset/pull/12049/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/jinja\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/12049/diff?src=pr&el=tree#diff-c3VwZXJzZXQvamluamFfY29udGV4dC5weQ==) | `87.57% <100.00%> (+0.07%)` | :arrow_up: |
| [superset/utils/core.py](https://codecov.io/gh/apache/incubator-superset/pull/12049/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `89.26% <100.00%> (+0.04%)` | :arrow_up: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/12049/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.39% <100.00%> (+0.16%)` | :arrow_up: |
| [...perset-frontend/src/views/CRUD/alert/AlertList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12049/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvQWxlcnRMaXN0LnRzeA==) | `63.95% <0.00%> (-11.96%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/12049/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| ... and [99 more](https://codecov.io/gh/apache/incubator-superset/pull/12049/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12049?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12049?src=pr&el=footer). Last update [3d56f58...b00b609](https://codecov.io/gh/apache/incubator-superset/pull/12049?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] betodealmeida commented on a change in pull request #12049: feat: show missing parameters in query
Posted by GitBox <gi...@apache.org>.
betodealmeida commented on a change in pull request #12049:
URL: https://github.com/apache/incubator-superset/pull/12049#discussion_r543557216
##########
File path: superset-frontend/src/SqlLab/components/ResultSet.tsx
##########
@@ -489,10 +490,15 @@ export default class ResultSet extends React.PureComponent<
return <Alert bsStyle="warning">Query was stopped</Alert>;
}
if (query.state === 'failed') {
+ const title =
+ query?.errors?.[0].error_type ===
+ ErrorTypeEnum.MISSING_TEMPLATE_PARAMS_ERROR
+ ? t('Parameter Error')
+ : t('Database Error');
Review comment:
Yeah, I'll leave a TODO here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12049: feat: show missing parameters in query
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12049:
URL: https://github.com/apache/incubator-superset/pull/12049#issuecomment-745003381
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12049?src=pr&el=h1) Report
> Merging [#12049](https://codecov.io/gh/apache/incubator-superset/pull/12049?src=pr&el=desc) (29e27eb) into [master](https://codecov.io/gh/apache/incubator-superset/commit/3d56f58ef53e21912dac425cb49ae7610915b608?el=desc) (3d56f58) will **decrease** coverage by `2.98%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/12049?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12049 +/- ##
==========================================
- Coverage 66.58% 63.60% -2.99%
==========================================
Files 952 474 -478
Lines 46703 29282 -17421
Branches 4578 0 -4578
==========================================
- Hits 31096 18624 -12472
+ Misses 15458 10658 -4800
+ Partials 149 0 -149
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.60% <100.00%> (-1.00%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12049?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/errors.py](https://codecov.io/gh/apache/incubator-superset/pull/12049/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/jinja\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/12049/diff?src=pr&el=tree#diff-c3VwZXJzZXQvamluamFfY29udGV4dC5weQ==) | `87.57% <100.00%> (+0.07%)` | :arrow_up: |
| [superset/utils/core.py](https://codecov.io/gh/apache/incubator-superset/pull/12049/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `89.26% <100.00%> (+0.04%)` | :arrow_up: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/12049/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `71.80% <100.00%> (-3.43%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/12049/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/datasets/commands/importers/v1/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/12049/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL3V0aWxzLnB5) | `58.62% <0.00%> (-34.24%)` | :arrow_down: |
| [superset/views/database/views.py](https://codecov.io/gh/apache/incubator-superset/pull/12049/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `62.10% <0.00%> (-25.33%)` | :arrow_down: |
| [superset/datasets/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/12049/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvZXhwb3J0LnB5) | `78.72% <0.00%> (-15.40%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/12049/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/12049/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| ... and [517 more](https://codecov.io/gh/apache/incubator-superset/pull/12049/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12049?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12049?src=pr&el=footer). Last update [3d56f58...29e27eb](https://codecov.io/gh/apache/incubator-superset/pull/12049?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12049: feat: show missing parameters in query
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12049:
URL: https://github.com/apache/incubator-superset/pull/12049#issuecomment-745003381
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12049?src=pr&el=h1) Report
> Merging [#12049](https://codecov.io/gh/apache/incubator-superset/pull/12049?src=pr&el=desc) (b00b609) into [master](https://codecov.io/gh/apache/incubator-superset/commit/3d56f58ef53e21912dac425cb49ae7610915b608?el=desc) (3d56f58) will **decrease** coverage by `3.18%`.
> The diff coverage is `83.33%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/12049?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12049 +/- ##
==========================================
- Coverage 66.58% 63.39% -3.19%
==========================================
Files 952 956 +4
Lines 46703 46851 +148
Branches 4578 4595 +17
==========================================
- Hits 31096 29703 -1393
- Misses 15458 16963 +1505
- Partials 149 185 +36
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `62.53% <55.55%> (-0.17%)` | :arrow_down: |
| python | `63.92% <100.00%> (-0.68%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12049?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rset-frontend/src/components/ErrorMessage/types.ts](https://codecov.io/gh/apache/incubator-superset/pull/12049/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL3R5cGVzLnRz) | `100.00% <ø> (ø)` | |
| [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12049/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `49.41% <25.00%> (-2.35%)` | :arrow_down: |
| [...erset-frontend/src/SqlLab/components/ResultSet.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12049/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1Jlc3VsdFNldC50c3g=) | `66.97% <75.00%> (+0.15%)` | :arrow_up: |
| [superset-frontend/src/featureFlags.ts](https://codecov.io/gh/apache/incubator-superset/pull/12049/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZlYXR1cmVGbGFncy50cw==) | `87.50% <100.00%> (-12.50%)` | :arrow_down: |
| [superset/errors.py](https://codecov.io/gh/apache/incubator-superset/pull/12049/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/jinja\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/12049/diff?src=pr&el=tree#diff-c3VwZXJzZXQvamluamFfY29udGV4dC5weQ==) | `87.57% <100.00%> (+0.07%)` | :arrow_up: |
| [superset/utils/core.py](https://codecov.io/gh/apache/incubator-superset/pull/12049/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `89.26% <100.00%> (+0.04%)` | :arrow_up: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/12049/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.39% <100.00%> (+0.16%)` | :arrow_up: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12049/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12049/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [182 more](https://codecov.io/gh/apache/incubator-superset/pull/12049/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12049?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12049?src=pr&el=footer). Last update [3d56f58...b00b609](https://codecov.io/gh/apache/incubator-superset/pull/12049?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12049: feat: show missing parameters in query
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12049:
URL: https://github.com/apache/incubator-superset/pull/12049#issuecomment-745003381
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org