You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2020/10/14 12:45:57 UTC

[GitHub] [trafficcontrol] smalenfant opened a new pull request #5148: Removing ORT ntpd checks

smalenfant opened a new pull request #5148:
URL: https://github.com/apache/trafficcontrol/pull/5148


   Disabled check_ntpd as it was running at all time. Wasn't not doing anything bad but the checks are just simply not working in most scenarios. traffic_ort_goland still install ntp configuration so no change there. The ntpd failure never gave back much feedback to users anyway and should be tracked outside of ORT.
   
   - ntpd is deprecated in Centos 7 and removed in Centos 8
   - Doesn't work when ntpd is using DNS
   
   ## What does this PR (Pull Request) do?
   
   Simply disabled ntpd checks
   
   ## Which Traffic Control components are affected by this PR?
   
   - Traffic Ops ORT
   - CI tests
   
   ## What is the best way to verify this PR?
   N/A
   
   ## The following criteria are ALL met by this PR
   
   - [ ] This PR includes tests OR I have explained why tests are unnecessary
   - [ ] This PR includes documentation OR I have explained why documentation is unnecessary
   - [X] This PR includes an update to CHANGELOG.md OR such an update is not necessary
   - [ ] This PR includes any and all required license headers
   - [ ] This PR ensures that database migration sequence is correct OR this PR does not include a database migration
   - [X] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the Apache Software Foundation's security guidelines](https://www.apache.org/security/) for details)
   
   
   ## Additional Information
   N/A


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficcontrol] smalenfant commented on pull request #5148: Removing ORT ntpd checks

Posted by GitBox <gi...@apache.org>.
smalenfant commented on pull request #5148:
URL: https://github.com/apache/trafficcontrol/pull/5148#issuecomment-708378381


   Before: 
   
   ```
   ERROR trafficserver is running.
   readline() on closed filehandle $fh at /opt/ort/traffic_ops_ort.pl line 1378.
   Can't exec "/usr/sbin/ntpq": No such file or directory at /opt/ort/traffic_ops_ort.pl line 1392.
   Use of uninitialized value $ntpq_output in split at /opt/ort/traffic_ops_ort.pl line 1395.
   ERROR No NTP server peer found!
   ```
   
   After:
   
   ```
   No Errors
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #5148: Removing ORT ntpd checks

Posted by GitBox <gi...@apache.org>.
ocket8888 commented on a change in pull request #5148:
URL: https://github.com/apache/trafficcontrol/pull/5148#discussion_r504717449



##########
File path: traffic_ops_ort/traffic_ops_ort.pl
##########
@@ -263,7 +263,7 @@
 	&run_sysctl_p();
 }
 
-&check_ntp();
+#&check_ntp();

Review comment:
       Did you wanna remove the function, too?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficcontrol] ocket8888 merged pull request #5148: Removing ORT ntpd checks

Posted by GitBox <gi...@apache.org>.
ocket8888 merged pull request #5148:
URL: https://github.com/apache/trafficcontrol/pull/5148


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org