[GitHub] [ignite] ptupitsyn commented on a diff in pull request #10069: IGNITE-17063 .NET: Improve Java detection on Linux

[GitBox <gi...@apache.org>]

ptupitsyn commented on code in PR #10069:
URL: https://github.com/apache/ignite/pull/10069#discussion_r890799871


##########
modules/platforms/dotnet/Apache.Ignite.Core.Tests/ShellTests.cs:
##########
@@ -17,38 +17,82 @@
 
 namespace Apache.Ignite.Core.Tests
 {
+    using System;
+    using System.Linq;
     using Apache.Ignite.Core.Impl;
-    using Apache.Ignite.Core.Impl.Unmanaged;
+    using Apache.Ignite.Core.Log;
+    using Apache.Ignite.Core.Tests.Client.Cache;
     using NUnit.Framework;
 
     /// <summary>
     /// Tests for <see cref="Shell"/> class.
     /// </summary>
+    [Platform("Linux")]
+    [Order(1)] // Execute first to avoid zombie processes (see https://issues.apache.org/jira/browse/IGNITE-13536).
     public class ShellTests
     {
         /// <summary>
         /// Tests <see cref="Shell.ExecuteSafe"/> method.
         /// </summary>
         [Test]
-        public void TestExecuteSafe()
+        public void TestExecuteSafeReturnsStdout()

Review Comment:
   It means that `ExecuteSafe` method returns whatever the executed command writes to [Standard output (stdout)](https://en.wikipedia.org/wiki/Standard_streams#Standard_output_(stdout)) as a string.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org