You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Robert Burrell Donkin (JIRA)" <ji...@codehaus.org> on 2011/07/02 12:22:42 UTC
[jira] Created: (MSHADE-101) ApacheNoticeResourceTransformer
NullPointerException for some licenses when no parameters set.
ApacheNoticeResourceTransformer NullPointerException for some licenses when no parameters set.
----------------------------------------------------------------------------------------------
Key: MSHADE-101
URL: https://jira.codehaus.org/browse/MSHADE-101
Project: Maven 2.x Shade Plugin
Issue Type: Bug
Affects Versions: 1.5
Reporter: Robert Burrell Donkin
Attachments: ApacheNoticeResourceTransformer-NullPointerException.patch
For some dependencies, ApacheNoticeResourceTransformer throws a NullPointerException when no parameters are set.
Included in the patch are
* an integration test case which demonstrates the problem,
* a unit test case (including tests around this problem) and
* my proposed (narrow) fix for ApacheNoticeResourceTransformer.
ATM no parameter is mandatory. This may indicate an intention to support a basic use case without parameters. So this patch opts for a reasonable default.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Issue Comment Edited: (MSHADE-101)
ApacheNoticeResourceTransformer NullPointerException for some licenses when
no parameters set.
Posted by "Benson Margulies (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MSHADE-101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=272127#comment-272127 ]
Benson Margulies edited comment on MSHADE-101 at 7/2/11 6:27 AM:
-----------------------------------------------------------------
Robert, We don't check in files with personal copyrights at Apache. Since you have an ICLA on file, you have in general granted permission for your work to be incorporated with the standard notice. And you did use a standard notice on the java file, just not on the POM. So I'm going to go ahead and fix the notice and commit. If this is a problem we'll cope.
was (Author: bmargulies):
Robert, We don't check in files with personal copyrights at Apache. Since you have an ICLA on file, you have in general granted permission for your work to be incorporated with the standard notice. However, in an abundance of caution, I'm holding off committing the repaired notices until I hear from you that you did indeed intend to submit this under the terms of your icla with Apache.
> ApacheNoticeResourceTransformer NullPointerException for some licenses when no parameters set.
> ----------------------------------------------------------------------------------------------
>
> Key: MSHADE-101
> URL: https://jira.codehaus.org/browse/MSHADE-101
> Project: Maven 2.x Shade Plugin
> Issue Type: Bug
> Affects Versions: 1.5
> Reporter: Robert Burrell Donkin
> Assignee: Benson Margulies
> Attachments: ApacheNoticeResourceTransformer-NullPointerException.patch
>
>
> For some dependencies, ApacheNoticeResourceTransformer throws a NullPointerException when no parameters are set.
> Included in the patch are
> * an integration test case which demonstrates the problem,
> * a unit test case (including tests around this problem) and
> * my proposed (narrow) fix for ApacheNoticeResourceTransformer.
> ATM no parameter is mandatory. This may indicate an intention to support a basic use case without parameters. So this patch opts for a reasonable default.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (MSHADE-101) ApacheNoticeResourceTransformer
NullPointerException for some licenses when no parameters set.
Posted by "Benson Margulies (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MSHADE-101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benson Margulies closed MSHADE-101.
-----------------------------------
Resolution: Fixed
r1142204 | bimargulies | 2011-07-02 07:29:03 -0400 (Sat, 02 Jul 2011) | 3 lines
[MSHADE-101] ApacheNoticeResourceTransformer NullPointerException for some licenses when no parameters set.
Submitted by: Robert Robert Burrell Donkin
> ApacheNoticeResourceTransformer NullPointerException for some licenses when no parameters set.
> ----------------------------------------------------------------------------------------------
>
> Key: MSHADE-101
> URL: https://jira.codehaus.org/browse/MSHADE-101
> Project: Maven 2.x Shade Plugin
> Issue Type: Bug
> Affects Versions: 1.4
> Reporter: Robert Burrell Donkin
> Assignee: Benson Margulies
> Fix For: 1.5
>
> Attachments: ApacheNoticeResourceTransformer-NullPointerException.patch
>
>
> For some dependencies, ApacheNoticeResourceTransformer throws a NullPointerException when no parameters are set.
> Included in the patch are
> * an integration test case which demonstrates the problem,
> * a unit test case (including tests around this problem) and
> * my proposed (narrow) fix for ApacheNoticeResourceTransformer.
> ATM no parameter is mandatory. This may indicate an intention to support a basic use case without parameters. So this patch opts for a reasonable default.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MSHADE-101) ApacheNoticeResourceTransformer
NullPointerException for some licenses when no parameters set.
Posted by "Benson Margulies (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MSHADE-101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=272127#comment-272127 ]
Benson Margulies commented on MSHADE-101:
-----------------------------------------
Robert, We don't check in files with personal copyrights at Apache. Since you have an ICLA on file, you have in general granted permission for your work to be incorporated with the standard notice. However, in an abundance of caution, I'm holding off committing the repaired notices until I hear from you that you did indeed intend to submit this under the terms of your icla with Apache.
> ApacheNoticeResourceTransformer NullPointerException for some licenses when no parameters set.
> ----------------------------------------------------------------------------------------------
>
> Key: MSHADE-101
> URL: https://jira.codehaus.org/browse/MSHADE-101
> Project: Maven 2.x Shade Plugin
> Issue Type: Bug
> Affects Versions: 1.5
> Reporter: Robert Burrell Donkin
> Attachments: ApacheNoticeResourceTransformer-NullPointerException.patch
>
>
> For some dependencies, ApacheNoticeResourceTransformer throws a NullPointerException when no parameters are set.
> Included in the patch are
> * an integration test case which demonstrates the problem,
> * a unit test case (including tests around this problem) and
> * my proposed (narrow) fix for ApacheNoticeResourceTransformer.
> ATM no parameter is mandatory. This may indicate an intention to support a basic use case without parameters. So this patch opts for a reasonable default.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MSHADE-101) ApacheNoticeResourceTransformer
NullPointerException for some licenses when no parameters set.
Posted by "Benson Margulies (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MSHADE-101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benson Margulies updated MSHADE-101:
------------------------------------
Affects Version/s: (was: 1.5)
1.4
Fix Version/s: 1.5
> ApacheNoticeResourceTransformer NullPointerException for some licenses when no parameters set.
> ----------------------------------------------------------------------------------------------
>
> Key: MSHADE-101
> URL: https://jira.codehaus.org/browse/MSHADE-101
> Project: Maven 2.x Shade Plugin
> Issue Type: Bug
> Affects Versions: 1.4
> Reporter: Robert Burrell Donkin
> Assignee: Benson Margulies
> Fix For: 1.5
>
> Attachments: ApacheNoticeResourceTransformer-NullPointerException.patch
>
>
> For some dependencies, ApacheNoticeResourceTransformer throws a NullPointerException when no parameters are set.
> Included in the patch are
> * an integration test case which demonstrates the problem,
> * a unit test case (including tests around this problem) and
> * my proposed (narrow) fix for ApacheNoticeResourceTransformer.
> ATM no parameter is mandatory. This may indicate an intention to support a basic use case without parameters. So this patch opts for a reasonable default.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira