[GitHub] [arrow] jonkeane commented on a change in pull request #11690: ARROW-13371 [R] binding for make_struct -> StructArray$create()

[GitBox <gi...@apache.org>]

jonkeane commented on a change in pull request #11690:
URL: https://github.com/apache/arrow/pull/11690#discussion_r754678039



##########
File path: r/R/dplyr-functions.R
##########
@@ -250,6 +250,39 @@ nse_funcs$is_logical <- function(x, n = NULL) {
   nse_funcs$is.logical(x)
 }
 
+# Create a data frame/tibble/struct column
+nse_funcs$tibble <- function(..., .rows = NULL, .name_repair = NULL) {
+  if (!is.null(.rows)) arrow_not_supported(".rows")
+  if (!is.null(.name_repair)) arrow_not_supported(".name_repair")

Review comment:
       Would it be possible (and desirable) to have these warn + ignore them instead of erroring? Most of them are checking processes and don't change the contents of the data.frame/tibble drastically anyway.

##########
File path: r/R/dplyr-functions.R
##########
@@ -250,6 +250,39 @@ nse_funcs$is_logical <- function(x, n = NULL) {
   nse_funcs$is.logical(x)
 }
 
+# Create a data frame/tibble/struct column
+nse_funcs$tibble <- function(..., .rows = NULL, .name_repair = NULL) {
+  if (!is.null(.rows)) arrow_not_supported(".rows")
+  if (!is.null(.name_repair)) arrow_not_supported(".name_repair")
+
+  # use dots_list() because this is what tibble() uses to allow the
+  # useful shorthand of tibble(col1, col2) -> tibble(col1 = col1, col2 = col2_)

Review comment:
       ```suggestion
     # useful shorthand of tibble(col1, col2) -> tibble(col1 = col1, col2 = col2)
   ```
   
   Is this `_` a typo? I think yes, but not 100% certain it's meaningful 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org