You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org> on 2012/05/02 22:36:50 UTC
[jira] [Created] (HDFS-3350) findbugs warning:
INodeFileUnderConstruction doesn't override INodeFile.equals(Object)
Tsz Wo (Nicholas), SZE created HDFS-3350:
--------------------------------------------
Summary: findbugs warning: INodeFileUnderConstruction doesn't override INodeFile.equals(Object)
Key: HDFS-3350
URL: https://issues.apache.org/jira/browse/HDFS-3350
Project: Hadoop HDFS
Issue Type: Bug
Reporter: Tsz Wo (Nicholas), SZE
Assignee: Tsz Wo (Nicholas), SZE
Somehow this findbugs warning got triggered in the recent builds, e.g. [build #2361|https://builds.apache.org/job/PreCommit-HDFS-Build/2361/artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html]. It probably was triggered by HDFS-3339 although HDFS-3339 did not introduce the bug.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-3350) findbugs warning:
INodeFileUnderConstruction doesn't override INodeFile.equals(Object)
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HDFS-3350:
-----------------------------------------
Attachment: h3350_20120502b.patch
h3350_20120502b.patch:
- handles null names;
- removes synchronized from updatePermissionStatus(..); see HDFS-566.
> findbugs warning: INodeFileUnderConstruction doesn't override INodeFile.equals(Object)
> --------------------------------------------------------------------------------------
>
> Key: HDFS-3350
> URL: https://issues.apache.org/jira/browse/HDFS-3350
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Attachments: h3350_20120502.patch, h3350_20120502b.patch
>
>
> Somehow this findbugs warning got triggered in the recent builds, e.g. [build #2361|https://builds.apache.org/job/PreCommit-HDFS-Build/2361/artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html]. It probably was triggered by HDFS-3339 although HDFS-3339 did not introduce the bug.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3350) findbugs warning:
INodeFileUnderConstruction doesn't override INodeFile.equals(Object)
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13266948#comment-13266948 ]
Hadoop QA commented on HDFS-3350:
---------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12525346/h3350_20120502.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
-1 javadoc. The javadoc tool appears to have generated 2 warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs:
org.apache.hadoop.hdfs.server.datanode.TestBlockReport
org.apache.hadoop.hdfs.TestParallelRead
org.apache.hadoop.hdfs.TestLeaseRecovery2
org.apache.hadoop.hdfs.TestInjectionForSimulatedStorage
org.apache.hadoop.hdfs.TestWriteConfigurationToDFS
org.apache.hadoop.fs.TestGlobPaths
org.apache.hadoop.hdfs.TestCrcCorruption
org.apache.hadoop.hdfs.TestFileAppend
org.apache.hadoop.hdfs.TestReplication
org.apache.hadoop.hdfs.TestDFSUpgradeFromImage
org.apache.hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure
org.apache.hadoop.hdfs.server.namenode.TestParallelImageWrite
org.apache.hadoop.hdfs.server.namenode.TestBackupNode
org.apache.hadoop.hdfs.server.namenode.TestFsck
org.apache.hadoop.hdfs.server.namenode.TestStartup
org.apache.hadoop.hdfs.server.datanode.TestDatanodeJsp
org.apache.hadoop.hdfs.TestFileStatus
org.apache.hadoop.hdfs.server.datanode.TestBlockReplacement
org.apache.hadoop.hdfs.server.datanode.TestDataNodeMetrics
org.apache.hadoop.hdfs.TestDFSClientExcludedNodes
org.apache.hadoop.hdfs.TestMultiThreadedHflush
org.apache.hadoop.hdfs.TestDFSPermission
org.apache.hadoop.hdfs.TestListPathServlet
org.apache.hadoop.hdfs.server.namenode.TestNameEditsConfigs
org.apache.hadoop.hdfs.server.namenode.TestProcessCorruptBlocks
org.apache.hadoop.hdfs.TestHFlush
org.apache.hadoop.hdfs.TestDFSRename
org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.TestDatanodeRestart
org.apache.hadoop.security.TestPermission
org.apache.hadoop.hdfs.TestFileCreationDelete
org.apache.hadoop.hdfs.TestLeaseRecovery
org.apache.hadoop.hdfs.server.namenode.TestMetaSave
org.apache.hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting
org.apache.hadoop.hdfs.server.namenode.ha.TestHAFsck
org.apache.hadoop.hdfs.server.namenode.TestNameNodeRecovery
org.apache.hadoop.hdfs.server.namenode.TestCorruptFilesJsp
org.apache.hadoop.hdfs.TestDFSMkdirs
org.apache.hadoop.hdfs.TestDFSUpgrade
org.apache.hadoop.hdfs.TestHDFSTrash
org.apache.hadoop.hdfs.server.datanode.TestTransferRbw
org.apache.hadoop.hdfs.TestFileCreation
org.apache.hadoop.hdfs.TestConnCache
org.apache.hadoop.hdfs.TestDFSStorageStateRecovery
org.apache.hadoop.hdfs.TestHftpFileSystem
org.apache.hadoop.hdfs.server.namenode.ha.TestStandbyIsHot
org.apache.hadoop.hdfs.TestFileAppend4
org.apache.hadoop.hdfs.server.blockmanagement.TestNodeCount
org.apache.hadoop.hdfs.server.namenode.TestCheckpoint
org.apache.hadoop.hdfs.TestClientBlockVerification
org.apache.hadoop.hdfs.server.namenode.TestFSEditLogLoader
org.apache.hadoop.hdfs.TestQuota
org.apache.hadoop.hdfs.TestAbandonBlock
org.apache.hadoop.hdfs.security.token.block.TestBlockToken
org.apache.hadoop.hdfs.TestFileAppend2
org.apache.hadoop.hdfs.TestFileAppendRestart
org.apache.hadoop.fs.TestHDFSFileContextMainOperations
org.apache.hadoop.tools.TestJMXGet
org.apache.hadoop.hdfs.TestDFSRollback
org.apache.hadoop.hdfs.TestFileCorruption
org.apache.hadoop.hdfs.TestShortCircuitLocalRead
org.apache.hadoop.hdfs.server.namenode.TestSaveNamespace
org.apache.hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureToleration
org.apache.hadoop.hdfs.TestPersistBlocks
org.apache.hadoop.hdfs.TestFileCreationEmpty
org.apache.hadoop.hdfs.TestSetTimes
org.apache.hadoop.hdfs.server.namenode.TestEditLog
org.apache.hadoop.fs.TestUrlStreamHandler
org.apache.hadoop.hdfs.server.blockmanagement.TestBlocksWithNotEnoughRacks
org.apache.hadoop.hdfs.server.namenode.ha.TestDNFencingWithReplication
org.apache.hadoop.hdfs.server.namenode.ha.TestHAMetrics
org.apache.hadoop.hdfs.TestBlockReaderLocal
org.apache.hadoop.hdfs.TestFileCreationNamenodeRestart
org.apache.hadoop.hdfs.TestDatanodeBlockScanner
org.apache.hadoop.hdfs.server.balancer.TestBalancerWithHANameNodes
org.apache.hadoop.hdfs.server.balancer.TestBalancerWithMultipleNameNodes
org.apache.hadoop.hdfs.server.namenode.ha.TestHASafeMode
org.apache.hadoop.hdfs.server.namenode.ha.TestPipelinesFailover
org.apache.hadoop.hdfs.TestDFSFinalize
org.apache.hadoop.hdfs.server.datanode.TestDiskError
org.apache.hadoop.hdfs.TestGetBlocks
org.apache.hadoop.hdfs.TestDFSStartupVersions
org.apache.hadoop.hdfs.TestDFSShell
org.apache.hadoop.hdfs.TestRestartDFS
org.apache.hadoop.hdfs.server.namenode.TestStorageRestore
org.apache.hadoop.hdfs.TestSafeMode
org.apache.hadoop.hdfs.web.TestFSMainOperationsWebHdfs
org.apache.hadoop.hdfs.server.datanode.TestDeleteBlockPool
org.apache.hadoop.hdfs.security.TestDelegationToken
org.apache.hadoop.hdfs.TestFileConcurrentReader
org.apache.hadoop.fs.TestFcHdfsSymlink
org.apache.hadoop.hdfs.server.namenode.ha.TestFailureToReadEdits
org.apache.hadoop.hdfs.web.TestWebHdfsFileSystemContract
org.apache.hadoop.hdfs.server.blockmanagement.TestBlockTokenWithDFS
org.apache.hadoop.hdfs.TestPipelines
org.apache.hadoop.hdfs.server.namenode.TestHDFSConcat
org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.TestInterDatanodeProtocol
org.apache.hadoop.hdfs.server.namenode.ha.TestDNFencing
org.apache.hadoop.hdfs.security.TestDelegationTokenForProxyUser
org.apache.hadoop.hdfs.server.namenode.TestFileLimit
org.apache.hadoop.cli.TestHDFSCLI
org.apache.hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks
org.apache.hadoop.hdfs.TestBlocksScheduledCounter
org.apache.hadoop.hdfs.tools.offlineEditsViewer.TestOfflineEditsViewer
org.apache.hadoop.hdfs.TestHDFSFileSystemContract
org.apache.hadoop.hdfs.TestDFSClientRetries
org.apache.hadoop.hdfs.server.balancer.TestBalancer
org.apache.hadoop.hdfs.TestAppendDifferentChecksum
org.apache.hadoop.hdfs.TestFetchImage
org.apache.hadoop.hdfs.server.blockmanagement.TestOverReplicatedBlocks
org.apache.hadoop.hdfs.TestClientReportBadBlock
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2362//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2362//console
This message is automatically generated.
> findbugs warning: INodeFileUnderConstruction doesn't override INodeFile.equals(Object)
> --------------------------------------------------------------------------------------
>
> Key: HDFS-3350
> URL: https://issues.apache.org/jira/browse/HDFS-3350
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Attachments: h3350_20120502.patch
>
>
> Somehow this findbugs warning got triggered in the recent builds, e.g. [build #2361|https://builds.apache.org/job/PreCommit-HDFS-Build/2361/artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html]. It probably was triggered by HDFS-3339 although HDFS-3339 did not introduce the bug.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-3350) findbugs warning:
INodeFileUnderConstruction doesn't override INodeFile.equals(Object)
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HDFS-3350:
-----------------------------------------
Component/s: name-node
> findbugs warning: INodeFileUnderConstruction doesn't override INodeFile.equals(Object)
> --------------------------------------------------------------------------------------
>
> Key: HDFS-3350
> URL: https://issues.apache.org/jira/browse/HDFS-3350
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
>
> Somehow this findbugs warning got triggered in the recent builds, e.g. [build #2361|https://builds.apache.org/job/PreCommit-HDFS-Build/2361/artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html]. It probably was triggered by HDFS-3339 although HDFS-3339 did not introduce the bug.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-3350) findbugs warning:
INodeFileUnderConstruction doesn't override INodeFile.equals(Object)
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HDFS-3350:
-----------------------------------------
Status: Patch Available (was: Open)
> findbugs warning: INodeFileUnderConstruction doesn't override INodeFile.equals(Object)
> --------------------------------------------------------------------------------------
>
> Key: HDFS-3350
> URL: https://issues.apache.org/jira/browse/HDFS-3350
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Attachments: h3350_20120502.patch
>
>
> Somehow this findbugs warning got triggered in the recent builds, e.g. [build #2361|https://builds.apache.org/job/PreCommit-HDFS-Build/2361/artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html]. It probably was triggered by HDFS-3339 although HDFS-3339 did not introduce the bug.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3350) findbugs warning:
INodeFileUnderConstruction doesn't override INodeFile.equals(Object)
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13267980#comment-13267980 ]
Hudson commented on HDFS-3350:
------------------------------
Integrated in Hadoop-Mapreduce-trunk-Commit #2202 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2202/])
HDFS-3350. In INode, add final to compareTo(..), equals(..) and hashCode(), and remove synchronized from updatePermissionStatus(..). (Revision 1333679)
Result = ABORTED
szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1333679
Files :
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/INode.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/INodeDirectory.java
> findbugs warning: INodeFileUnderConstruction doesn't override INodeFile.equals(Object)
> --------------------------------------------------------------------------------------
>
> Key: HDFS-3350
> URL: https://issues.apache.org/jira/browse/HDFS-3350
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Fix For: 2.0.0
>
> Attachments: h3350_20120502.patch, h3350_20120502b.patch
>
>
> Somehow this findbugs warning got triggered in the recent builds, e.g. [build #2361|https://builds.apache.org/job/PreCommit-HDFS-Build/2361/artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html]. It probably was triggered by HDFS-3339 although HDFS-3339 did not introduce the bug.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-3350) findbugs warning:
INodeFileUnderConstruction doesn't override INodeFile.equals(Object)
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HDFS-3350:
-----------------------------------------
Resolution: Fixed
Fix Version/s: 2.0.0
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
I have committed this.
> findbugs warning: INodeFileUnderConstruction doesn't override INodeFile.equals(Object)
> --------------------------------------------------------------------------------------
>
> Key: HDFS-3350
> URL: https://issues.apache.org/jira/browse/HDFS-3350
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Fix For: 2.0.0
>
> Attachments: h3350_20120502.patch, h3350_20120502b.patch
>
>
> Somehow this findbugs warning got triggered in the recent builds, e.g. [build #2361|https://builds.apache.org/job/PreCommit-HDFS-Build/2361/artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html]. It probably was triggered by HDFS-3339 although HDFS-3339 did not introduce the bug.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3350) findbugs warning:
INodeFileUnderConstruction doesn't override INodeFile.equals(Object)
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13268383#comment-13268383 ]
Hudson commented on HDFS-3350:
------------------------------
Integrated in Hadoop-Mapreduce-trunk #1069 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1069/])
HDFS-3350. In INode, add final to compareTo(..), equals(..) and hashCode(), and remove synchronized from updatePermissionStatus(..). (Revision 1333679)
Result = SUCCESS
szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1333679
Files :
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/INode.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/INodeDirectory.java
> findbugs warning: INodeFileUnderConstruction doesn't override INodeFile.equals(Object)
> --------------------------------------------------------------------------------------
>
> Key: HDFS-3350
> URL: https://issues.apache.org/jira/browse/HDFS-3350
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Fix For: 2.0.0
>
> Attachments: h3350_20120502.patch, h3350_20120502b.patch
>
>
> Somehow this findbugs warning got triggered in the recent builds, e.g. [build #2361|https://builds.apache.org/job/PreCommit-HDFS-Build/2361/artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html]. It probably was triggered by HDFS-3339 although HDFS-3339 did not introduce the bug.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3350) findbugs warning:
INodeFileUnderConstruction doesn't override INodeFile.equals(Object)
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13267950#comment-13267950 ]
Hudson commented on HDFS-3350:
------------------------------
Integrated in Hadoop-Hdfs-trunk-Commit #2258 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2258/])
HDFS-3350. In INode, add final to compareTo(..), equals(..) and hashCode(), and remove synchronized from updatePermissionStatus(..). (Revision 1333679)
Result = SUCCESS
szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1333679
Files :
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/INode.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/INodeDirectory.java
> findbugs warning: INodeFileUnderConstruction doesn't override INodeFile.equals(Object)
> --------------------------------------------------------------------------------------
>
> Key: HDFS-3350
> URL: https://issues.apache.org/jira/browse/HDFS-3350
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Fix For: 2.0.0
>
> Attachments: h3350_20120502.patch, h3350_20120502b.patch
>
>
> Somehow this findbugs warning got triggered in the recent builds, e.g. [build #2361|https://builds.apache.org/job/PreCommit-HDFS-Build/2361/artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html]. It probably was triggered by HDFS-3339 although HDFS-3339 did not introduce the bug.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3350) findbugs warning:
INodeFileUnderConstruction doesn't override INodeFile.equals(Object)
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13267824#comment-13267824 ]
Tsz Wo (Nicholas), SZE commented on HDFS-3350:
----------------------------------------------
Hi John, thanks for the review.
- The "synchronized" is useless and confusing since the fields are synchronized by the FSNamesystem write lock. See also HDFS-566.
- equals(..) and hashCode() should be changed together. Since we disallow over ridding equals(..), we do the same for hashCode().
> findbugs warning: INodeFileUnderConstruction doesn't override INodeFile.equals(Object)
> --------------------------------------------------------------------------------------
>
> Key: HDFS-3350
> URL: https://issues.apache.org/jira/browse/HDFS-3350
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Attachments: h3350_20120502.patch, h3350_20120502b.patch
>
>
> Somehow this findbugs warning got triggered in the recent builds, e.g. [build #2361|https://builds.apache.org/job/PreCommit-HDFS-Build/2361/artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html]. It probably was triggered by HDFS-3339 although HDFS-3339 did not introduce the bug.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3350) findbugs warning:
INodeFileUnderConstruction doesn't override INodeFile.equals(Object)
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13267952#comment-13267952 ]
Hudson commented on HDFS-3350:
------------------------------
Integrated in Hadoop-Common-trunk-Commit #2184 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2184/])
HDFS-3350. In INode, add final to compareTo(..), equals(..) and hashCode(), and remove synchronized from updatePermissionStatus(..). (Revision 1333679)
Result = SUCCESS
szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1333679
Files :
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/INode.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/INodeDirectory.java
> findbugs warning: INodeFileUnderConstruction doesn't override INodeFile.equals(Object)
> --------------------------------------------------------------------------------------
>
> Key: HDFS-3350
> URL: https://issues.apache.org/jira/browse/HDFS-3350
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Fix For: 2.0.0
>
> Attachments: h3350_20120502.patch, h3350_20120502b.patch
>
>
> Somehow this findbugs warning got triggered in the recent builds, e.g. [build #2361|https://builds.apache.org/job/PreCommit-HDFS-Build/2361/artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html]. It probably was triggered by HDFS-3339 although HDFS-3339 did not introduce the bug.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3350) findbugs warning:
INodeFileUnderConstruction doesn't override INodeFile.equals(Object)
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13268328#comment-13268328 ]
Hudson commented on HDFS-3350:
------------------------------
Integrated in Hadoop-Hdfs-trunk #1034 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1034/])
HDFS-3350. In INode, add final to compareTo(..), equals(..) and hashCode(), and remove synchronized from updatePermissionStatus(..). (Revision 1333679)
Result = FAILURE
szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1333679
Files :
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/INode.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/INodeDirectory.java
> findbugs warning: INodeFileUnderConstruction doesn't override INodeFile.equals(Object)
> --------------------------------------------------------------------------------------
>
> Key: HDFS-3350
> URL: https://issues.apache.org/jira/browse/HDFS-3350
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Fix For: 2.0.0
>
> Attachments: h3350_20120502.patch, h3350_20120502b.patch
>
>
> Somehow this findbugs warning got triggered in the recent builds, e.g. [build #2361|https://builds.apache.org/job/PreCommit-HDFS-Build/2361/artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html]. It probably was triggered by HDFS-3339 although HDFS-3339 did not introduce the bug.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3350) findbugs warning:
INodeFileUnderConstruction doesn't override INodeFile.equals(Object)
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13267080#comment-13267080 ]
Tsz Wo (Nicholas), SZE commented on HDFS-3350:
----------------------------------------------
The failure of TestHFlush does not seem related to this. Filed HADOOP-8348.
> findbugs warning: INodeFileUnderConstruction doesn't override INodeFile.equals(Object)
> --------------------------------------------------------------------------------------
>
> Key: HDFS-3350
> URL: https://issues.apache.org/jira/browse/HDFS-3350
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Attachments: h3350_20120502.patch, h3350_20120502b.patch
>
>
> Somehow this findbugs warning got triggered in the recent builds, e.g. [build #2361|https://builds.apache.org/job/PreCommit-HDFS-Build/2361/artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html]. It probably was triggered by HDFS-3339 although HDFS-3339 did not introduce the bug.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3350) findbugs warning:
INodeFileUnderConstruction doesn't override INodeFile.equals(Object)
Posted by "John George (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13267817#comment-13267817 ]
John George commented on HDFS-3350:
-----------------------------------
+1 The changes specifically related to this JIRA seem good to me. I just want to understand the cleanups made a little better. Hence, could you explain why the following changes were made?
{code}
- private synchronized void updatePermissionStatus(
- PermissionStatusFormat f, long n) {
+ private void updatePermissionStatus(PermissionStatusFormat f, long n) {
permission = f.combine(n, permission);
}
{code}
and
{code}
- public int hashCode() {
+ @Override
+ public final int hashCode() {
return Arrays.hashCode(this.name);
}
{code}
> findbugs warning: INodeFileUnderConstruction doesn't override INodeFile.equals(Object)
> --------------------------------------------------------------------------------------
>
> Key: HDFS-3350
> URL: https://issues.apache.org/jira/browse/HDFS-3350
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Attachments: h3350_20120502.patch, h3350_20120502b.patch
>
>
> Somehow this findbugs warning got triggered in the recent builds, e.g. [build #2361|https://builds.apache.org/job/PreCommit-HDFS-Build/2361/artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html]. It probably was triggered by HDFS-3339 although HDFS-3339 did not introduce the bug.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-3350) findbugs warning:
INodeFileUnderConstruction doesn't override INodeFile.equals(Object)
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HDFS-3350:
-----------------------------------------
Attachment: h3350_20120502.patch
h3350_20120502.patch: declare equals(..) and some other methods as final and clean up some code.
> findbugs warning: INodeFileUnderConstruction doesn't override INodeFile.equals(Object)
> --------------------------------------------------------------------------------------
>
> Key: HDFS-3350
> URL: https://issues.apache.org/jira/browse/HDFS-3350
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Attachments: h3350_20120502.patch, h3350_20120502.patch
>
>
> Somehow this findbugs warning got triggered in the recent builds, e.g. [build #2361|https://builds.apache.org/job/PreCommit-HDFS-Build/2361/artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html]. It probably was triggered by HDFS-3339 although HDFS-3339 did not introduce the bug.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-3350) findbugs warning:
INodeFileUnderConstruction doesn't override INodeFile.equals(Object)
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HDFS-3350:
-----------------------------------------
Attachment: h3350_20120502.patch
> findbugs warning: INodeFileUnderConstruction doesn't override INodeFile.equals(Object)
> --------------------------------------------------------------------------------------
>
> Key: HDFS-3350
> URL: https://issues.apache.org/jira/browse/HDFS-3350
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Attachments: h3350_20120502.patch, h3350_20120502.patch
>
>
> Somehow this findbugs warning got triggered in the recent builds, e.g. [build #2361|https://builds.apache.org/job/PreCommit-HDFS-Build/2361/artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html]. It probably was triggered by HDFS-3339 although HDFS-3339 did not introduce the bug.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-3350) findbugs warning:
INodeFileUnderConstruction doesn't override INodeFile.equals(Object)
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HDFS-3350:
-----------------------------------------
Attachment: (was: h3350_20120502.patch)
> findbugs warning: INodeFileUnderConstruction doesn't override INodeFile.equals(Object)
> --------------------------------------------------------------------------------------
>
> Key: HDFS-3350
> URL: https://issues.apache.org/jira/browse/HDFS-3350
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Attachments: h3350_20120502.patch
>
>
> Somehow this findbugs warning got triggered in the recent builds, e.g. [build #2361|https://builds.apache.org/job/PreCommit-HDFS-Build/2361/artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html]. It probably was triggered by HDFS-3339 although HDFS-3339 did not introduce the bug.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3350) findbugs warning:
INodeFileUnderConstruction doesn't override INodeFile.equals(Object)
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13267063#comment-13267063 ]
Hadoop QA commented on HDFS-3350:
---------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12525359/h3350_20120502b.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
-1 javadoc. The javadoc tool appears to have generated 2 warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs:
org.apache.hadoop.hdfs.TestHFlush
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2365//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2365//console
This message is automatically generated.
> findbugs warning: INodeFileUnderConstruction doesn't override INodeFile.equals(Object)
> --------------------------------------------------------------------------------------
>
> Key: HDFS-3350
> URL: https://issues.apache.org/jira/browse/HDFS-3350
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Attachments: h3350_20120502.patch, h3350_20120502b.patch
>
>
> Somehow this findbugs warning got triggered in the recent builds, e.g. [build #2361|https://builds.apache.org/job/PreCommit-HDFS-Build/2361/artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html]. It probably was triggered by HDFS-3339 although HDFS-3339 did not introduce the bug.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira