[GitHub] [arrow-datafusion] jackwener commented on a diff in pull request #5363: Minor: add tests for subquery to join

["jackwener (via GitHub)" <gi...@apache.org>]

jackwener commented on code in PR #5363:
URL: https://github.com/apache/arrow-datafusion/pull/5363#discussion_r1115436086


##########
datafusion/core/tests/sql/subqueries.rs:
##########
@@ -116,3 +116,69 @@ where o_orderstatus in (
 
     Ok(())
 }
+
+#[tokio::test]
+async fn exists_subquery_with_same_table() -> Result<()> {
+    let test_repartition_joins = vec![true, false];
+    for repartition_joins in test_repartition_joins {
+        let ctx = create_join_context("t1_id", "t2_id", repartition_joins)?;
+
+        // this query will not be rewritten to join

Review Comment:
   It would be better that add the reason of it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org