Re: OPENEJB-974 & OPENEJB-858

[David Blevins <da...@visi.com>]

Excellent change!

Just a note, I think we might want to change this to not be remote  
specific:

   ejbDeployment.getJndi().add(new Jndi(mappedName, "Remote"));

That way if someone set their mappedName to something as simple as  
"{interfaceClass}" it could apply to all jndi names we generate for  
the bean.

-David

On Jan 31, 2009, at 11:33 AM, Jonathan Gallimore wrote:

> I've committed this in r739588. Many thanks for your guidance David,  
> I think this is a neat solution (much better than my first attempt!).
>
> Jon
>
>
> Jonathan Gallimore wrote:
>> I've attached a patch to OPENEJB-974. I've done a quick test with  
>> the standalone server and it seems to work. I'll add some unit  
>> tests tomorrow too.
>>
>> Any comments would be much appreciated.
>>
>> Jon
>>
>> David Blevins wrote:
>>>
>>> On Jan 27, 2009, at 1:42 PM, David Blevins wrote:
>>>
>>>>
>>>> On Jan 27, 2009, at 1:11 PM, Jonathan Gallimore wrote:
>>>>
>>>>> Is anyone working on these issues? I've had a bit of a play  
>>>>> around with this, and think I have something working, I'm happy  
>>>>> to test what I've done more thoroughly and commit it if no one  
>>>>> is working on it at the moment.
>>>>
>>>> Go for it.
>>>
>>> Seems if we just move the supplied mappedName info into an openejb- 
>>> jar.xml <jndi> tag, that would do the trick.
>>>
>>> -David
>>>
>>
>
>