You are viewing a plain text version of this content. The canonical link for it is here.
Posted to npanday-dev@incubator.apache.org by Adrián Boimvaser <ad...@gmail.com> on 2011/12/21 12:35:17 UTC
Contributing to wix-maven-plugin
Hi, I'd like to make a contribution to wix-maven-plugin. Where should I
send the patch?
Thanks.
Adrián Boimvaser
Re: Contributing to wix-maven-plugin
Posted by Lars Corneliussen <me...@lcorneliussen.de>.
Hi Adrián,
I'm a little bit christmas-offline now. So Sit and wait can happen sometimes :)
There is a way to become an NPanday developer, but it'll require a couple of good patches that drive the project in the right direction. It also usually takes some time until patches are available in a new release.
When I originally had a series of patches for NPanday, I had a private git repository based on https://github.com/apache/npanday to keep a fork for a while.
I also then wrote a utility that helped me creating SVN-compatible patches from git feature branches here: http://lcorneliussen.de/utils/git-svn/github.com
_
Lars
Am 22.12.2011 um 15:53 schrieb Adrián Boimvaser:
> Hi Lars?
>
> What's next? Sit and wait?
> I made some refactorings and improvements to wix-maven plugin I would also
> like to contribute.
> Is there a way I can become a NPanday developer?
>
> Thanks.
> Adrián.
>
> 2011/12/21 Adrián Boimvaser <ad...@gmail.com>
>
>> Thanks Lars,
>>
>> I created the issue and attached the patch.
>>
>> https://issues.apache.org/jira/browse/NPANDAY-510
>>
>> Adrián.
>>
>> 2011/12/21 Lars Corneliussen <me...@lcorneliussen.de>
>>
>>> Hi Adrián,
>>>
>>> happy to hear that.
>>> The best is, if you create an issue and attach the patch here:
>>>
>>> https://issues.apache.org/jira/secure/CreateIssue.jspa?pid=12311182&issuetype=4&Create=Create
>>>
>>> Is that ok for you?
>>> _
>>> Lars
>>>
>>> Am 21.12.2011 um 13:35 schrieb Adrián Boimvaser:
>>>
>>>> Hi, I'd like to make a contribution to wix-maven-plugin. Where should I
>>>> send the patch?
>>>> Thanks.
>>>> Adrián Boimvaser
>>>
>>>
>>
Re: Contributing to wix-maven-plugin
Posted by Brett Porter <br...@apache.org>.
Yep, that would be great.
On 06/01/2012, at 2:35 AM, Adrián Boimvaser wrote:
> Hi Brett,
>
> Thanks. I'd like to contribute some refactorings I made to AbstractWixMojo,
> CandleMojo and LightMojo to remove some duplication. Should I file a JIRA
> issue and attach a patch like I did with NPANDAY-510?
>
> Adrián
>
> 2012/1/5 Brett Porter <br...@apache.org>
>
>> Hi Adrián,
>>
>> Sorry for the delay... I applied your patch. Since it was helpful in my
>> env., I made a few enhancements based on the comments in the issue (set a
>> default from the environment, and dealt with spaces in the wixHome
>> variable). Do those work for you?
>>
>> We'd be very happy if you're interested in contributing on a regular
>> basis. Are there other aspects that interest you, or do you need any
>> pointers?
>>
>> Regards,
>> Brett
>>
>> On 23/12/2011, at 1:53 AM, Adrián Boimvaser wrote:
>>
>>> Hi Lars?
>>>
>>> What's next? Sit and wait?
>>> I made some refactorings and improvements to wix-maven plugin I would
>> also
>>> like to contribute.
>>> Is there a way I can become a NPanday developer?
>>>
>>> Thanks.
>>> Adrián.
>>>
>>> 2011/12/21 Adrián Boimvaser <ad...@gmail.com>
>>>
>>>> Thanks Lars,
>>>>
>>>> I created the issue and attached the patch.
>>>>
>>>> https://issues.apache.org/jira/browse/NPANDAY-510
>>>>
>>>> Adrián.
>>>>
>>>> 2011/12/21 Lars Corneliussen <me...@lcorneliussen.de>
>>>>
>>>>> Hi Adrián,
>>>>>
>>>>> happy to hear that.
>>>>> The best is, if you create an issue and attach the patch here:
>>>>>
>>>>>
>> https://issues.apache.org/jira/secure/CreateIssue.jspa?pid=12311182&issuetype=4&Create=Create
>>>>>
>>>>> Is that ok for you?
>>>>> _
>>>>> Lars
>>>>>
>>>>> Am 21.12.2011 um 13:35 schrieb Adrián Boimvaser:
>>>>>
>>>>>> Hi, I'd like to make a contribution to wix-maven-plugin. Where should
>> I
>>>>>> send the patch?
>>>>>> Thanks.
>>>>>> Adrián Boimvaser
>>>>>
>>>>>
>>>>
>>
>> --
>> Brett Porter
>> brett@apache.org
>> http://brettporter.wordpress.com/
>> http://au.linkedin.com/in/brettporter
>> http://twitter.com/brettporter
>>
>>
>>
>>
>>
>>
--
Brett Porter
brett@apache.org
http://brettporter.wordpress.com/
http://au.linkedin.com/in/brettporter
http://twitter.com/brettporter
Re: Contributing to wix-maven-plugin
Posted by Adrián Boimvaser <ad...@gmail.com>.
Hi Brett,
Thanks. I'd like to contribute some refactorings I made to AbstractWixMojo,
CandleMojo and LightMojo to remove some duplication. Should I file a JIRA
issue and attach a patch like I did with NPANDAY-510?
Adrián
2012/1/5 Brett Porter <br...@apache.org>
> Hi Adrián,
>
> Sorry for the delay... I applied your patch. Since it was helpful in my
> env., I made a few enhancements based on the comments in the issue (set a
> default from the environment, and dealt with spaces in the wixHome
> variable). Do those work for you?
>
> We'd be very happy if you're interested in contributing on a regular
> basis. Are there other aspects that interest you, or do you need any
> pointers?
>
> Regards,
> Brett
>
> On 23/12/2011, at 1:53 AM, Adrián Boimvaser wrote:
>
> > Hi Lars?
> >
> > What's next? Sit and wait?
> > I made some refactorings and improvements to wix-maven plugin I would
> also
> > like to contribute.
> > Is there a way I can become a NPanday developer?
> >
> > Thanks.
> > Adrián.
> >
> > 2011/12/21 Adrián Boimvaser <ad...@gmail.com>
> >
> >> Thanks Lars,
> >>
> >> I created the issue and attached the patch.
> >>
> >> https://issues.apache.org/jira/browse/NPANDAY-510
> >>
> >> Adrián.
> >>
> >> 2011/12/21 Lars Corneliussen <me...@lcorneliussen.de>
> >>
> >>> Hi Adrián,
> >>>
> >>> happy to hear that.
> >>> The best is, if you create an issue and attach the patch here:
> >>>
> >>>
> https://issues.apache.org/jira/secure/CreateIssue.jspa?pid=12311182&issuetype=4&Create=Create
> >>>
> >>> Is that ok for you?
> >>> _
> >>> Lars
> >>>
> >>> Am 21.12.2011 um 13:35 schrieb Adrián Boimvaser:
> >>>
> >>>> Hi, I'd like to make a contribution to wix-maven-plugin. Where should
> I
> >>>> send the patch?
> >>>> Thanks.
> >>>> Adrián Boimvaser
> >>>
> >>>
> >>
>
> --
> Brett Porter
> brett@apache.org
> http://brettporter.wordpress.com/
> http://au.linkedin.com/in/brettporter
> http://twitter.com/brettporter
>
>
>
>
>
>
Re: Contributing to wix-maven-plugin
Posted by Brett Porter <br...@apache.org>.
Hi Adrián,
Sorry for the delay... I applied your patch. Since it was helpful in my env., I made a few enhancements based on the comments in the issue (set a default from the environment, and dealt with spaces in the wixHome variable). Do those work for you?
We'd be very happy if you're interested in contributing on a regular basis. Are there other aspects that interest you, or do you need any pointers?
Regards,
Brett
On 23/12/2011, at 1:53 AM, Adrián Boimvaser wrote:
> Hi Lars?
>
> What's next? Sit and wait?
> I made some refactorings and improvements to wix-maven plugin I would also
> like to contribute.
> Is there a way I can become a NPanday developer?
>
> Thanks.
> Adrián.
>
> 2011/12/21 Adrián Boimvaser <ad...@gmail.com>
>
>> Thanks Lars,
>>
>> I created the issue and attached the patch.
>>
>> https://issues.apache.org/jira/browse/NPANDAY-510
>>
>> Adrián.
>>
>> 2011/12/21 Lars Corneliussen <me...@lcorneliussen.de>
>>
>>> Hi Adrián,
>>>
>>> happy to hear that.
>>> The best is, if you create an issue and attach the patch here:
>>>
>>> https://issues.apache.org/jira/secure/CreateIssue.jspa?pid=12311182&issuetype=4&Create=Create
>>>
>>> Is that ok for you?
>>> _
>>> Lars
>>>
>>> Am 21.12.2011 um 13:35 schrieb Adrián Boimvaser:
>>>
>>>> Hi, I'd like to make a contribution to wix-maven-plugin. Where should I
>>>> send the patch?
>>>> Thanks.
>>>> Adrián Boimvaser
>>>
>>>
>>
--
Brett Porter
brett@apache.org
http://brettporter.wordpress.com/
http://au.linkedin.com/in/brettporter
http://twitter.com/brettporter
Re: Contributing to wix-maven-plugin
Posted by Adrián Boimvaser <ad...@gmail.com>.
Hi Lars?
What's next? Sit and wait?
I made some refactorings and improvements to wix-maven plugin I would also
like to contribute.
Is there a way I can become a NPanday developer?
Thanks.
Adrián.
2011/12/21 Adrián Boimvaser <ad...@gmail.com>
> Thanks Lars,
>
> I created the issue and attached the patch.
>
> https://issues.apache.org/jira/browse/NPANDAY-510
>
> Adrián.
>
> 2011/12/21 Lars Corneliussen <me...@lcorneliussen.de>
>
>> Hi Adrián,
>>
>> happy to hear that.
>> The best is, if you create an issue and attach the patch here:
>>
>> https://issues.apache.org/jira/secure/CreateIssue.jspa?pid=12311182&issuetype=4&Create=Create
>>
>> Is that ok for you?
>> _
>> Lars
>>
>> Am 21.12.2011 um 13:35 schrieb Adrián Boimvaser:
>>
>> > Hi, I'd like to make a contribution to wix-maven-plugin. Where should I
>> > send the patch?
>> > Thanks.
>> > Adrián Boimvaser
>>
>>
>
Re: Contributing to wix-maven-plugin
Posted by Adrián Boimvaser <ad...@gmail.com>.
Thanks Lars,
I created the issue and attached the patch.
https://issues.apache.org/jira/browse/NPANDAY-510
Adrián.
2011/12/21 Lars Corneliussen <me...@lcorneliussen.de>
> Hi Adrián,
>
> happy to hear that.
> The best is, if you create an issue and attach the patch here:
>
> https://issues.apache.org/jira/secure/CreateIssue.jspa?pid=12311182&issuetype=4&Create=Create
>
> Is that ok for you?
> _
> Lars
>
> Am 21.12.2011 um 13:35 schrieb Adrián Boimvaser:
>
> > Hi, I'd like to make a contribution to wix-maven-plugin. Where should I
> > send the patch?
> > Thanks.
> > Adrián Boimvaser
>
>
Re: Contributing to wix-maven-plugin
Posted by Lars Corneliussen <me...@lcorneliussen.de>.
Hi Adrián,
happy to hear that.
The best is, if you create an issue and attach the patch here:
https://issues.apache.org/jira/secure/CreateIssue.jspa?pid=12311182&issuetype=4&Create=Create
Is that ok for you?
_
Lars
Am 21.12.2011 um 13:35 schrieb Adrián Boimvaser:
> Hi, I'd like to make a contribution to wix-maven-plugin. Where should I
> send the patch?
> Thanks.
> Adrián Boimvaser