You are viewing a plain text version of this content. The canonical link for it is here.
Posted to log4cxx-user@logging.apache.org by Jing Zheng <ji...@inbox.com> on 2006/10/26 17:44:24 UTC
a proposed patch for DailyRollingFileAppender by Iwan Tomlow
Hi Curt, Iwan Tomlow suggested a patch for DailyRollingFileAppender in
http://comments.gmane.org/gmane.comp.apache.logging.log4cxx.user/842
dailyrollingfileappender.h, Ln 50:
class DailyRollingFileAppender : public log4cxx::helpers::ObjectImpl,
Appender {
DECLARE_LOG4CXX_OBJECT(DailyRollingFileAppender)
BEGIN_LOG4CXX_CAST_MAP()
LOG4CXX_CAST_ENTRY(DailyRollingFileAppender)
LOG4CXX_CAST_ENTRY(Appender)
+ LOG4CXX_CAST_ENTRY(spi::OptionHandler)
END_LOG4CXX_CAST_MAP()
I tried this patch and DailyRollingFileAppender began to work without the
error "log4cxx: No output stream or file set for the appender named ...".
Any potential problem to commit this change into svn? I has been there for a
while...
thanks.
--
View this message in context: http://www.nabble.com/a-proposed-patch-for-DailyRollingFileAppender-by-Iwan-Tomlow-tf2514825.html#a7013834
Sent from the Log4cxx - Users mailing list archive at Nabble.com.
Re: a proposed patch for DailyRollingFileAppender by Iwan Tomlow
Posted by Jing Zheng <ji...@inbox.com>.
Hi Curt, do you think this patch is good?
Jing Zheng wrote:
>
> Hi Curt, Iwan Tomlow suggested a patch for DailyRollingFileAppender in
> http://comments.gmane.org/gmane.comp.apache.logging.log4cxx.user/842
> dailyrollingfileappender.h, Ln 50:
> class DailyRollingFileAppender : public log4cxx::helpers::ObjectImpl,
> Appender {
> DECLARE_LOG4CXX_OBJECT(DailyRollingFileAppender)
> BEGIN_LOG4CXX_CAST_MAP()
> LOG4CXX_CAST_ENTRY(DailyRollingFileAppender)
> LOG4CXX_CAST_ENTRY(Appender)
> + LOG4CXX_CAST_ENTRY(spi::OptionHandler)
> END_LOG4CXX_CAST_MAP()
>
> I tried this patch and DailyRollingFileAppender began to work without the
> error "log4cxx: No output stream or file set for the appender named ...".
> Any potential problem to commit this change into svn? It has been there
> for a while...
> thanks.
>
--
View this message in context: http://www.nabble.com/a-proposed-patch-for-DailyRollingFileAppender-by-Iwan-Tomlow-tf2514825.html#a7720219
Sent from the Log4cxx - Users mailing list archive at Nabble.com.