You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by ahshahid <gi...@git.apache.org> on 2017/02/22 04:14:35 UTC
[GitHub] spark pull request #17022: Aqp 271
GitHub user ahshahid opened a pull request:
https://github.com/apache/spark/pull/17022
Aqp 271
Looks like in Spark 2.0 the optimization of repeat aggregates being represented by a single aggregate was broken because of passing of resultId: ExprID in the constructor of AggregateExpression. Thus if the query is of type
select avg(x), y from tab group by y having avg(x) > 0
ideally there should be only 1 aggregate evaluated . But since the resultID passed is different in the analyze phase, the distinct on aggregateExpressions, does not result in 1 aggregate .
The change is to implement the equality/hashCode method of aggregate expression instead of relying on scala case class generated methods. and ensuring the dependency on the aggregate which gets removed, is correctly rewritten. The test for this bug is present in CommonBugTest of aqp
(Please fill in changes proposed in this fix)
## How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)
Please review http://spark.apache.org/contributing.html before opening a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/SnappyDataInc/spark AQP-271
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/17022.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #17022
----
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17022: Aqp 271
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17022
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #17022: Aqp 271
Posted by ahshahid <gi...@git.apache.org>.
Github user ahshahid closed the pull request at:
https://github.com/apache/spark/pull/17022
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17022: Aqp 271
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/17022
@ahshahid, it seems mistakenly open. Could you close this please?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17022: Aqp 271
Posted by ahshahid <gi...@git.apache.org>.
Github user ahshahid commented on the issue:
https://github.com/apache/spark/pull/17022
Sorry I used the wrong base to generate pull request. I will close this. I
will later push an appropriate branch, as the bug does exist in master
On 21 Feb 2017 21:00, "Hyukjin Kwon" <no...@github.com> wrote:
> @ahshahid <https://github.com/ahshahid>, it seems mistakenly open. Could
> you close this please?
>
> \u2014
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/spark/pull/17022#issuecomment-281569737>, or mute
> the thread
> <https://github.com/notifications/unsubscribe-auth/AL1zaEnx7kRz3Zl9utSVltOFBQEdB24Kks5re8DagaJpZM4MIMAU>
> .
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org