You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2021/06/21 17:19:06 UTC

[GitHub] [accumulo] foster33 opened a new pull request #2171: Change WALOG Property Names to WAL

foster33 opened a new pull request #2171:
URL: https://github.com/apache/accumulo/pull/2171


   Fixes #2146 
   
   This fix makes the property names regarding write ahead logs uniform. All properties that used `walog` were tagged as deprecated and with a `@ReplacedBy` tag to its respected `wal` replacement. 
   
   For some uses of the new property names, the `conf.resolve()` function was used in order to read the values from whichever key the user used (whether it be the deprecated or new one).
   
   While making these changes I decided to exclude the use of the `resolve` function in the ITs where the new properties were used. From what I understood, there would be no real reason to resolve the usages. There were also some places where Null Pointer Exceptions would occur if they were to be resolved. Please let me know if this was wrong.
   
   I also found a section in `HadoopLogCloser` where I did not see a way to properly resolve the usage of the new property name. If this is a place where the resolve function needs to be used please mention it.
   
   Lastly, there are places where I create a Property variable `deprecatedProp` in an attempt to make the deprecation suppression area as specific as possible. I am not sure if there is a "cleaner" way of going about this, or if the suppression could be more general.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [accumulo] ctubbsii commented on a change in pull request #2171: Change WALOG Property Names to WAL

Posted by GitBox <gi...@apache.org>.
ctubbsii commented on a change in pull request #2171:
URL: https://github.com/apache/accumulo/pull/2171#discussion_r656650498



##########
File path: server/manager/src/main/java/org/apache/accumulo/manager/recovery/RecoveryManager.java
##########
@@ -197,9 +197,11 @@ public boolean recoverLogs(KeyExtent extent, Collection<Collection<String>> walo
         synchronized (this) {
           if (!closeTasksQueued.contains(sortId) && !sortsQueued.contains(sortId)) {
             AccumuloConfiguration aconf = manager.getConfiguration();
+            @SuppressWarnings("deprecation")
             LogCloser closer = Property.createInstanceFromPropertyName(aconf,
-                Property.MANAGER_WALOG_CLOSER_IMPLEMETATION, LogCloser.class,
-                new HadoopLogCloser());
+                aconf.resolve(Property.MANAGER_WAL_CLOSER_IMPLEMENTATION,
+                    Property.MANAGER_WALOG_CLOSER_IMPLEMETATION),

Review comment:
       I think @milleruntime had suggested elsewhere in his review that it might not be necessary to resolve between these two, because the one being deprecated is entirely new. However, I think it probably still is necessary, because the upgrade code will read in `master.walog.closer.implementation` as `manager.walog.closer.implementation`, so it could still be in use inside the AccumuloConfiguration object. So, I think this is fine. If we want the upgrade code to do some additional translations directly to this new version, to eliminate the intermediate `manager.walog.` version, we can do that, but I don't think we should, because having the intermediate version helps users easily transition their old config files with simple `sed` commands, and that will break if we don't have a direct mapping of all `master.` props to `manager.` ones.

##########
File path: test/src/main/java/org/apache/accumulo/test/functional/ManyWriteAheadLogsIT.java
##########
@@ -87,11 +88,13 @@ public void alterConfig() throws Exception {
     try (AccumuloClient client = Accumulo.newClient().from(getClientProps()).build()) {
       InstanceOperations iops = client.instanceOperations();
       Map<String,String> conf = iops.getSystemConfiguration();
+      AccumuloConfiguration aconf = getCluster().getSiteConfiguration();
+      @SuppressWarnings("deprecation")
+      Property deprecatedProp = Property.TSERV_WALOG_MAX_SIZE;
       majcDelay = conf.get(Property.TSERV_MAJC_DELAY.getKey());
-      walogSize = conf.get(Property.TSERV_WALOG_MAX_SIZE.getKey());
-
+      walSize = conf.get(aconf.resolve(Property.TSERV_WAL_MAX_SIZE, deprecatedProp).getKey());
       iops.setProperty(Property.TSERV_MAJC_DELAY.getKey(), "1");
-      iops.setProperty(Property.TSERV_WALOG_MAX_SIZE.getKey(), "1M");
+      iops.setProperty(aconf.resolve(Property.TSERV_WAL_MAX_SIZE, deprecatedProp).getKey(), "1M");

Review comment:
       These can just set the new property, and don't need to make a decision based on what is set already in the config. First, we control the config for the test cluster, and you've already set the cluster to use the new property, and second, even if a cluster did use the old property in its existing config, setting only the new property is sufficient, since the new property will overrule the old one.

##########
File path: server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServer.java
##########
@@ -300,23 +300,35 @@ public void run() {
           }
         }), 5000, 5000, TimeUnit.MILLISECONDS);
 
-    final long walogMaxSize = aconf.getAsBytes(Property.TSERV_WALOG_MAX_SIZE);
-    final long walogMaxAge = aconf.getTimeInMillis(Property.TSERV_WALOG_MAX_AGE);
+    @SuppressWarnings("deprecation")
+    final long walMaxSize =
+        aconf.getAsBytes(aconf.resolve(Property.TSERV_WAL_MAX_SIZE, Property.TSERV_WALOG_MAX_SIZE));
+    @SuppressWarnings("deprecation")
+    final long walMaxAge = aconf
+        .getTimeInMillis(aconf.resolve(Property.TSERV_WAL_MAX_AGE, Property.TSERV_WALOG_MAX_AGE));
     final long minBlockSize =
         context.getHadoopConf().getLong("dfs.namenode.fs-limits.min-block-size", 0);
-    if (minBlockSize != 0 && minBlockSize > walogMaxSize) {
+    if (minBlockSize != 0 && minBlockSize > walMaxSize) {
+      @SuppressWarnings("deprecation")
+      Property deprecatedProp = Property.TSERV_WALOG_MAX_SIZE;
       throw new RuntimeException("Unable to start TabletServer. Logger is set to use blocksize "
-          + walogMaxSize + " but hdfs minimum block size is " + minBlockSize
-          + ". Either increase the " + Property.TSERV_WALOG_MAX_SIZE
+          + walMaxSize + " but hdfs minimum block size is " + minBlockSize
+          + ". Either increase the " + aconf.resolve(Property.TSERV_WAL_MAX_SIZE, deprecatedProp)

Review comment:
       This message can be changed to only refer to the new property. We don't need to recommend the old one just because they were previously using it.

##########
File path: core/src/test/java/org/apache/accumulo/core/conf/SiteConfigurationTest.java
##########
@@ -75,7 +77,9 @@ public void testFile() {
     assertEquals("mysecret", conf.get(Property.INSTANCE_SECRET));
     assertEquals("hdfs://localhost:8020/accumulo123", conf.get(Property.INSTANCE_VOLUMES));
     assertEquals("123s", conf.get(Property.GENERAL_RPC_TIMEOUT));
-    assertEquals("256M", conf.get(Property.TSERV_WALOG_MAX_SIZE));
+    @SuppressWarnings("deprecation")
+    Property deprecatedProp = Property.TSERV_WALOG_MAX_SIZE;
+    assertEquals("256M", conf.get(conf.resolve(Property.TSERV_WAL_MAX_SIZE, deprecatedProp)));

Review comment:
       Since this test is just testing that we can read the file correctly, we don't need to check the deprecated prop, just the new one, so there's no need to do `conf.resolve` here. I see that you already updated the config file to use the new prop, anyway, so just checking the new prop should suffice.
   
   That is, unless you wanted this to serve as a test for `conf.resolve` itself... but I assume that's already unit tested elsewhere.

##########
File path: server/manager/src/test/resources/conf/accumulo-site.xml
##########
@@ -82,7 +82,7 @@
   </property>
 
   <property>
-    <name>tserver.walog.max.size</name>
+    <name>tserver.wal.max.size</name>

Review comment:
       Eek. Do we still support XML files in 2.x? I thought we got rid of them. I don't see a reference to this file anywhere. I had thought maybe as a test case somewhere, but I didn't find it. This file might be able to be just deleted outright.

##########
File path: test/src/main/java/org/apache/accumulo/test/functional/ManyWriteAheadLogsIT.java
##########
@@ -103,8 +106,12 @@ public void resetConfig() throws Exception {
     if (majcDelay != null) {
       try (AccumuloClient client = Accumulo.newClient().from(getClientProps()).build()) {
         InstanceOperations iops = client.instanceOperations();
+        AccumuloConfiguration conf = getServerContext().getConfiguration();
+        @SuppressWarnings("deprecation")
+        Property deprecatedProp = Property.TSERV_WALOG_MAX_SIZE;
         iops.setProperty(Property.TSERV_MAJC_DELAY.getKey(), majcDelay);
-        iops.setProperty(Property.TSERV_WALOG_MAX_SIZE.getKey(), walogSize);
+        iops.setProperty(conf.resolve(Property.TSERV_WAL_MAX_SIZE, deprecatedProp).getKey(),
+            walSize);

Review comment:
       Same here. This only needs to use the new property.

##########
File path: core/src/main/java/org/apache/accumulo/core/conf/Property.java
##########
@@ -360,25 +365,59 @@
           + " When there are more RFiles than this setting multiple passes must be"
           + " made, which is slower. However opening too many RFiles at once can cause"
           + " problems."),
+  TSERV_WAL_MAX_REFERENCED("tserver.wal.max.referenced", "3", PropertyType.COUNT,
+      "When a tablet server has more than this many write ahead logs, any tablet referencing older "
+          + "logs over this threshold is minor compacted.  Also any tablet referencing this many "
+          + "logs or more will be compacted."),
+  @Deprecated(since = "2.1.0")
+  @ReplacedBy(property = Property.TSERV_WAL_MAX_REFERENCED)
   TSERV_WALOG_MAX_REFERENCED("tserver.walog.max.referenced", "3", PropertyType.COUNT,
       "When a tablet server has more than this many write ahead logs, any tablet referencing older "
           + "logs over this threshold is minor compacted.  Also any tablet referencing this many "
           + "logs or more will be compacted."),
+  TSERV_WAL_MAX_SIZE("tserver.wal.max.size", "1G", PropertyType.BYTES,
+      "The maximum size for each write-ahead log. See comment for property"
+          + " tserver.memory.maps.max"),
+  @Deprecated(since = "2.1.0")
+  @ReplacedBy(property = Property.TSERV_WAL_MAX_SIZE)
   TSERV_WALOG_MAX_SIZE("tserver.walog.max.size", "1G", PropertyType.BYTES,
       "The maximum size for each write-ahead log. See comment for property"
           + " tserver.memory.maps.max"),
+  TSERV_WAL_MAX_AGE("tserver.wal.max.age", "24h", PropertyType.TIMEDURATION,
+      "The maximum age for each write-ahead log."),
+  @Deprecated(since = "2.1.0")
+  @ReplacedBy(property = Property.TSERV_WAL_MAX_AGE)
   TSERV_WALOG_MAX_AGE("tserver.walog.max.age", "24h", PropertyType.TIMEDURATION,
       "The maximum age for each write-ahead log."),
+  TSERV_WAL_TOLERATED_CREATION_FAILURES("tserver.wal.tolerated.creation.failures", "50",
+      PropertyType.COUNT,
+      "The maximum number of failures tolerated when creating a new write-ahead"
+          + " log. Negative values will allow unlimited creation failures. Exceeding this"
+          + " number of failures consecutively trying to create a new write-ahead log"
+          + " causes the TabletServer to exit."),
+  @Deprecated(since = "2.1.0")
+  @ReplacedBy(property = Property.TSERV_WAL_TOLERATED_CREATION_FAILURES)
   TSERV_WALOG_TOLERATED_CREATION_FAILURES("tserver.walog.tolerated.creation.failures", "50",
       PropertyType.COUNT,
       "The maximum number of failures tolerated when creating a new write-ahead"
           + " log. Negative values will allow unlimited creation failures. Exceeding this"
           + " number of failures consecutively trying to create a new write-ahead log"
           + " causes the TabletServer to exit."),
+  TSERV_WAL_TOLERATED_WAIT_INCREMENT("tserver.wal.tolerated.wait.increment", "1000ms",
+      PropertyType.TIMEDURATION,
+      "The amount of time to wait between failures to create or write a write-ahead log."),
+  @Deprecated(since = "2.1.0")
+  @ReplacedBy(property = Property.TSERV_WAL_TOLERATED_WAIT_INCREMENT)
   TSERV_WALOG_TOLERATED_WAIT_INCREMENT("tserver.walog.tolerated.wait.increment", "1000ms",
       PropertyType.TIMEDURATION,
       "The amount of time to wait between failures to create or write a write-ahead log."),
   // Never wait longer than 5 mins for a retry
+  TSERV_WAL_TOLERATED_MAXIMUM_WAIT_DURATION("tserver.wal.maximum.wait.duration", "5m",
+      PropertyType.TIMEDURATION,
+      "The maximum amount of time to wait after a failure to create or write a write-ahead log."),
+  // Never wait longer than 5 mins for a retry
+  @Deprecated(since = "2.1.0")
+  @ReplacedBy(property = Property.TSERV_WAL_TOLERATED_MAXIMUM_WAIT_DURATION)

Review comment:
       @milleruntime I'm not sure I understand your comment. It looks like these are already grouped together. Each new one looks like it was added directly next to the one it replaced, which is a nice, minimal change.

##########
File path: server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Tablet.java
##########
@@ -1926,7 +1926,7 @@ public void checkIfMinorCompactionNeededForLogs(List<DfsLogger> closedLogs) {
     // grab this outside of tablet lock.
     @SuppressWarnings("deprecation")
     int maxLogs = tableConfiguration.getCount(tableConfiguration
-        .resolve(Property.TSERV_WALOG_MAX_REFERENCED, Property.TABLE_MINC_LOGS_MAX));
+        .resolve(Property.TSERV_WAL_MAX_REFERENCED, Property.TSERV_WALOG_MAX_REFERENCED));

Review comment:
       It looks like `TABLE_MINC_LOGS_MAX` was deprecated in 2.0.0. There should be two resolves here to ensure we use the right one:
   
   ```suggestion
           .resolve(Property.TSERV_WAL_MAX_REFERENCED, tableConfiguration.resolve(Property.TSERV_WALOG_MAX_REFERENCED, Property.TABLE_MINC_LOGS_MAX));
   ```
   (this suggestion isn't formatted)
   
   If we have to do this a lot, it might make sense to modify the `resolve` command to take more than one argument, but probably not worth it if there's only one or two.

##########
File path: server/base/src/main/java/org/apache/accumulo/server/master/recovery/HadoopLogCloser.java
##########
@@ -36,7 +36,7 @@
 
   public HadoopLogCloser() {
     log.warn("{} has been deprecated. Please update property {} to {} instead.",
-        getClass().getName(), Property.MANAGER_WALOG_CLOSER_IMPLEMETATION.getKey(),
+        getClass().getName(), Property.MANAGER_WAL_CLOSER_IMPLEMENTATION.getKey(),

Review comment:
       This is one of those props that got changed multiple times in the main branch. This warning was originally added to help facilitate the migration from `master.` to `manager.`. We can keep the`manager.walog.` version around to help facilitate that transition, but the log message should really only refer to the new `manager.wal.` name. So, I think this change is good here.

##########
File path: core/src/test/java/org/apache/accumulo/core/conf/SiteConfigurationTest.java
##########
@@ -61,7 +61,9 @@ public void testDefault() {
     assertEquals("DEFAULT", conf.get(Property.INSTANCE_SECRET));
     assertEquals("", conf.get(Property.INSTANCE_VOLUMES));
     assertEquals("120s", conf.get(Property.GENERAL_RPC_TIMEOUT));
-    assertEquals("1G", conf.get(Property.TSERV_WALOG_MAX_SIZE));
+    @SuppressWarnings("deprecation")
+    Property deprecatedProp = Property.TSERV_WALOG_MAX_SIZE;
+    assertEquals("1G", conf.get(conf.resolve(Property.TSERV_WAL_MAX_SIZE, deprecatedProp)));

Review comment:
       Since this test is just testing the default values for a bunch of props not set in a config file, it'd be fine to just use the new prop, without calling `conf.resolve`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [accumulo] foster33 commented on a change in pull request #2171: Change WALOG Property Names to WAL

Posted by GitBox <gi...@apache.org>.
foster33 commented on a change in pull request #2171:
URL: https://github.com/apache/accumulo/pull/2171#discussion_r657007138



##########
File path: server/manager/src/test/resources/conf/accumulo-site.xml
##########
@@ -82,7 +82,7 @@
   </property>
 
   <property>
-    <name>tserver.walog.max.size</name>
+    <name>tserver.wal.max.size</name>

Review comment:
       Would this be best to do in a future PR?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [accumulo] milleruntime commented on a change in pull request #2171: Change WALOG Property Names to WAL

Posted by GitBox <gi...@apache.org>.
milleruntime commented on a change in pull request #2171:
URL: https://github.com/apache/accumulo/pull/2171#discussion_r657038388



##########
File path: server/manager/src/test/resources/conf/accumulo-site.xml
##########
@@ -82,7 +82,7 @@
   </property>
 
   <property>
-    <name>tserver.walog.max.size</name>
+    <name>tserver.wal.max.size</name>

Review comment:
       Yeah this file can be removed in a separate PR.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [accumulo] milleruntime commented on a change in pull request #2171: Change WALOG Property Names to WAL

Posted by GitBox <gi...@apache.org>.
milleruntime commented on a change in pull request #2171:
URL: https://github.com/apache/accumulo/pull/2171#discussion_r657047459



##########
File path: server/manager/src/main/java/org/apache/accumulo/manager/recovery/RecoveryManager.java
##########
@@ -197,9 +197,11 @@ public boolean recoverLogs(KeyExtent extent, Collection<Collection<String>> walo
         synchronized (this) {
           if (!closeTasksQueued.contains(sortId) && !sortsQueued.contains(sortId)) {
             AccumuloConfiguration aconf = manager.getConfiguration();
+            @SuppressWarnings("deprecation")
             LogCloser closer = Property.createInstanceFromPropertyName(aconf,
-                Property.MANAGER_WALOG_CLOSER_IMPLEMETATION, LogCloser.class,
-                new HadoopLogCloser());
+                aconf.resolve(Property.MANAGER_WAL_CLOSER_IMPLEMENTATION,
+                    Property.MANAGER_WALOG_CLOSER_IMPLEMETATION),

Review comment:
       > having the intermediate version helps users easily transition their old config files with simple sed commands, and that will break if we don't have a direct mapping of all master. props to manager. ones.
   
   That is a good point. It is unfortunate that we will change a user's property to a deprecated one but having the intermediate property makes the changes more flexible. I think this is OK as long as the version that eventually drops the `walog` properties, does the replace in the upgrade code. We have become better at resolving things in the upgrade code but this is another example of why you should never skip Major or Minor versions when upgrading.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [accumulo] ctubbsii merged pull request #2171: Change WALOG Property Names to WAL

Posted by GitBox <gi...@apache.org>.
ctubbsii merged pull request #2171:
URL: https://github.com/apache/accumulo/pull/2171


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [accumulo] milleruntime commented on a change in pull request #2171: Change WALOG Property Names to WAL

Posted by GitBox <gi...@apache.org>.
milleruntime commented on a change in pull request #2171:
URL: https://github.com/apache/accumulo/pull/2171#discussion_r656541916



##########
File path: core/src/test/resources/accumulo2.properties
##########
@@ -24,6 +24,6 @@ instance.volumes=hdfs://localhost:8020/accumulo123
 instance.zookeeper.host=myhost123:2181
 table.durability=flush
 tserver.memory.maps.native.enabled=false
-tserver.walog.max.size=256M
+tserver.wal.max.size=256M

Review comment:
       Good catch.

##########
File path: server/base/src/main/java/org/apache/accumulo/server/master/recovery/HadoopLogCloser.java
##########
@@ -36,7 +36,7 @@
 
   public HadoopLogCloser() {
     log.warn("{} has been deprecated. Please update property {} to {} instead.",
-        getClass().getName(), Property.MANAGER_WALOG_CLOSER_IMPLEMETATION.getKey(),
+        getClass().getName(), Property.MANAGER_WAL_CLOSER_IMPLEMENTATION.getKey(),

Review comment:
       I don't think you need to worry about resolving here. What you have is fine since this whole class was just deprecated in main. You just replaced the new property with a newer one.

##########
File path: core/src/main/java/org/apache/accumulo/core/conf/Property.java
##########
@@ -360,25 +365,59 @@
           + " When there are more RFiles than this setting multiple passes must be"
           + " made, which is slower. However opening too many RFiles at once can cause"
           + " problems."),
+  TSERV_WAL_MAX_REFERENCED("tserver.wal.max.referenced", "3", PropertyType.COUNT,
+      "When a tablet server has more than this many write ahead logs, any tablet referencing older "
+          + "logs over this threshold is minor compacted.  Also any tablet referencing this many "
+          + "logs or more will be compacted."),
+  @Deprecated(since = "2.1.0")
+  @ReplacedBy(property = Property.TSERV_WAL_MAX_REFERENCED)
   TSERV_WALOG_MAX_REFERENCED("tserver.walog.max.referenced", "3", PropertyType.COUNT,
       "When a tablet server has more than this many write ahead logs, any tablet referencing older "
           + "logs over this threshold is minor compacted.  Also any tablet referencing this many "
           + "logs or more will be compacted."),
+  TSERV_WAL_MAX_SIZE("tserver.wal.max.size", "1G", PropertyType.BYTES,
+      "The maximum size for each write-ahead log. See comment for property"
+          + " tserver.memory.maps.max"),
+  @Deprecated(since = "2.1.0")
+  @ReplacedBy(property = Property.TSERV_WAL_MAX_SIZE)
   TSERV_WALOG_MAX_SIZE("tserver.walog.max.size", "1G", PropertyType.BYTES,
       "The maximum size for each write-ahead log. See comment for property"
           + " tserver.memory.maps.max"),
+  TSERV_WAL_MAX_AGE("tserver.wal.max.age", "24h", PropertyType.TIMEDURATION,
+      "The maximum age for each write-ahead log."),
+  @Deprecated(since = "2.1.0")
+  @ReplacedBy(property = Property.TSERV_WAL_MAX_AGE)
   TSERV_WALOG_MAX_AGE("tserver.walog.max.age", "24h", PropertyType.TIMEDURATION,
       "The maximum age for each write-ahead log."),
+  TSERV_WAL_TOLERATED_CREATION_FAILURES("tserver.wal.tolerated.creation.failures", "50",
+      PropertyType.COUNT,
+      "The maximum number of failures tolerated when creating a new write-ahead"
+          + " log. Negative values will allow unlimited creation failures. Exceeding this"
+          + " number of failures consecutively trying to create a new write-ahead log"
+          + " causes the TabletServer to exit."),
+  @Deprecated(since = "2.1.0")
+  @ReplacedBy(property = Property.TSERV_WAL_TOLERATED_CREATION_FAILURES)
   TSERV_WALOG_TOLERATED_CREATION_FAILURES("tserver.walog.tolerated.creation.failures", "50",
       PropertyType.COUNT,
       "The maximum number of failures tolerated when creating a new write-ahead"
           + " log. Negative values will allow unlimited creation failures. Exceeding this"
           + " number of failures consecutively trying to create a new write-ahead log"
           + " causes the TabletServer to exit."),
+  TSERV_WAL_TOLERATED_WAIT_INCREMENT("tserver.wal.tolerated.wait.increment", "1000ms",
+      PropertyType.TIMEDURATION,
+      "The amount of time to wait between failures to create or write a write-ahead log."),
+  @Deprecated(since = "2.1.0")
+  @ReplacedBy(property = Property.TSERV_WAL_TOLERATED_WAIT_INCREMENT)
   TSERV_WALOG_TOLERATED_WAIT_INCREMENT("tserver.walog.tolerated.wait.increment", "1000ms",
       PropertyType.TIMEDURATION,
       "The amount of time to wait between failures to create or write a write-ahead log."),
   // Never wait longer than 5 mins for a retry
+  TSERV_WAL_TOLERATED_MAXIMUM_WAIT_DURATION("tserver.wal.maximum.wait.duration", "5m",
+      PropertyType.TIMEDURATION,
+      "The maximum amount of time to wait after a failure to create or write a write-ahead log."),
+  // Never wait longer than 5 mins for a retry
+  @Deprecated(since = "2.1.0")
+  @ReplacedBy(property = Property.TSERV_WAL_TOLERATED_MAXIMUM_WAIT_DURATION)

Review comment:
       Although the Property names are not sorted, we usually try to group common ones together. You could put the new tserver ones all together with the other "tserver.wal" properties. But I don't think this is a big deal since they can be sorted in an IDE.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [accumulo] ctubbsii merged pull request #2171: Change WALOG Property Names to WAL

Posted by GitBox <gi...@apache.org>.
ctubbsii merged pull request #2171:
URL: https://github.com/apache/accumulo/pull/2171


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org