You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zeppelin.apache.org by GitBox <gi...@apache.org> on 2019/05/27 03:57:23 UTC

[GitHub] [zeppelin] liuxunorg commented on a change in pull request #3372: [ZEPPELIN-3623] Create interpreter process in the cluster mode

liuxunorg commented on a change in pull request #3372: [ZEPPELIN-3623] Create interpreter process in the cluster mode
URL: https://github.com/apache/zeppelin/pull/3372#discussion_r287639758
 
 

 ##########
 File path: zeppelin-interpreter-api/pom.xml
 ##########
 @@ -68,8 +68,6 @@
               <exclude>org.apache.commons:commons-exec</exclude>
               <!-- Leave log4j unshaded so downstream users can configure logging. -->
               <exclude>log4j:log4j</exclude>
-              <exclude>com.esotericsoftware:kryo</exclude>
 
 Review comment:
   @zjffdu , I see that you excluded `kryo` in https://github.com/apache/zeppelin/commit/ae7318f4c443a1e0fb1e6bc4758ad99092b880c4.
   But the cluster needs `kryo`, So I shaded and rename `kryo` in interpreter-api pom.
   Please help me review here, See if it will affect the operation of spark, Thanks you!
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services