[Fwd: [PATCH] Preliminary patch for adding external locking file code to svn_repos_open]

[David Kopp <da...@bellsouth.net>]

Doh!

I forgot to attach the diff file to the last message. Here it is.

David

Re: [PATCH] Preliminary patch for adding external locking filecode to svn_repos_open]

[Files <fi...@poetryunlimited.com>]

Sorry David.

I missed setting the lock_conf_read value on reading the lock conf.

Apologies all.

-- 
Shamim Islam
BA BS

Files said:
> David,
>
> I think you might like this version better.
>
> It creates a default lock.conf file.
>
> It seperates the exclusive issue from the external lock file issue.
>
> And it allows you to cart around the configuration settings.
>
> Again. The same caveat as before. Your mileage may vary.
>
> Let me know if you like it.
>
> Going back to looking for the dang apr0.9.5. Argh.
>
> --
> Shamim Islam
> BA BS---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: dev-help@subversion.tigris.org

Re: [PATCH] Preliminary patch for adding external locking filecode to svn_repos_open]

[Files <fi...@poetryunlimited.com>]

David,

I think you might like this version better.

It creates a default lock.conf file.

It seperates the exclusive issue from the external lock file issue.

And it allows you to cart around the configuration settings.

Again. The same caveat as before. Your mileage may vary.

Let me know if you like it.

Going back to looking for the dang apr0.9.5. Argh.

-- 
Shamim Islam
BA BS

Re: [PATCH] Preliminary patch for adding external locking filecode to svn_repos_open]

[Files <fi...@poetryunlimited.com>]

David,

Check out this one.

I think you'll find it avoids a few pitfalls yours will have as well as
sticking to your intent. Yours I think you'll find is calling the locking
mechanism before the repository information is initialized. Whereas if you
wait to call the locking info, you can leverage the repository configuration
itself.

If you like it great. If not, you know what to do with it.

I found a few things in it that might cause problems in the config_read
section too.

Have a look.

The lock file uses a section called lock and a option called external
(true/false/yes/no etc).

This not only attempts to create the lock files, but also attempts to open the
repository in exclusive mode.

Do you think this is overkill?

P.S. The code never evaluates the lock information more than once per run.
-- 
Shamim Islam
BA BS

David Kopp said:
> Doh!
>
> I forgot to attach the diff file to the last message. Here it is.
>
> David
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: dev-help@subversion.tigris.org