You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2023/06/02 16:42:53 UTC
[GitHub] [arrow-datafusion] alamb opened a new pull request, #6535: Fix new clippy lint
alamb opened a new pull request, #6535:
URL: https://github.com/apache/arrow-datafusion/pull/6535
# Which issue does this PR close?
Closes https://github.com/apache/arrow-datafusion/issues/6529
# Rationale for this change
Rust 1.70 was released and it has some new clippy lints
# What changes are included in this PR?
Change some `///!` style comments to `//!` (note that it lost the extra `/`)
# Are these changes tested?
Yes by CI
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb merged pull request #6535: Fix new clippy lint
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #6535:
URL: https://github.com/apache/arrow-datafusion/pull/6535
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #6535: Fix new clippy lint
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #6535:
URL: https://github.com/apache/arrow-datafusion/pull/6535#issuecomment-1574078509
I also need to fix the memory calculations for slices in https://github.com/apache/arrow-datafusion/pull/6535/commits/539a4a66f6a03e1b7ad99eae73dcb96ea3f7f219
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org