You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jclouds.apache.org by Andrea Turli <no...@github.com> on 2013/11/12 13:03:27 UTC
[jclouds] JCLOUDS-375: Fix VirtualGuestToNodeMetadata when server
returns SoftLayer_Exception_Order_Item_Duplicate (#200)
* Wrap getOrderTemplate in VirtualGuestToNodeMetadata.getImage with try/catch
* Address comments from @nacx and @demobox:
- remove the fields of the custom SoftLayerOrderItemDuplicateException and propagate the HttpResponseException
- use of order = null instead of return null
- extend RuntimeException instead IllegalStateException in SoftLayerOrderItemDuplicateException
Conflicts solved:
providers/softlayer/src/main/java/org/jclouds/softlayer/compute/functions/VirtualGuestToNodeMetadata.java
You can merge this Pull Request by running:
git pull https://github.com/andreaturli/jclouds master
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds/pull/200
-- Commit Summary --
* JCLOUDS-373: Fix VirtualGuestToNodeMetadata when server returns SoftLayer_Exception_Order_Item_Duplicate
-- File Changes --
M providers/softlayer/src/main/java/org/jclouds/softlayer/compute/functions/VirtualGuestToNodeMetadata.java (25)
A providers/softlayer/src/main/java/org/jclouds/softlayer/exceptions/SoftLayerOrderItemDuplicateException.java (25)
M providers/softlayer/src/main/java/org/jclouds/softlayer/handlers/SoftLayerErrorHandler.java (3)
-- Patch Links --
https://github.com/jclouds/jclouds/pull/200.patch
https://github.com/jclouds/jclouds/pull/200.diff
Re: [jclouds] JCLOUDS-375: Fix VirtualGuestToNodeMetadata when server
returns SoftLayer_Exception_Order_Item_Duplicate (#200)
Posted by Andrew Phillips <no...@github.com>.
Committed to [master](https://git-wip-us.apache.org/repos/asf?p=jclouds.git;a=commit;h=4e75e0a1e1323122499716bdb8b7bf19fe1768e2) under [JCLOUDS-373](https://issues.apache.org/jira/browse/JCLOUDS-373)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/200#issuecomment-28393411
Re: [jclouds] JCLOUDS-375: Fix VirtualGuestToNodeMetadata when server
returns SoftLayer_Exception_Order_Item_Duplicate (#200)
Posted by Ignasi Barrera <no...@github.com>.
@andreaturli you didn't answer my question. Does this provider work without https://github.com/jclouds/jclouds/pull/77? In that case, shoudn't be a PR for that be opened before this one?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/200#issuecomment-28292408
Re: [jclouds] JCLOUDS-375: Fix VirtualGuestToNodeMetadata when server
returns SoftLayer_Exception_Order_Item_Duplicate (#200)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #383](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/383/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/200#issuecomment-28290923
Re: [jclouds] JCLOUDS-375: Fix VirtualGuestToNodeMetadata when server
returns SoftLayer_Exception_Order_Item_Duplicate (#200)
Posted by Andrea Turli <no...@github.com>.
Shall I reopen [JCLOUDS-213](https://issues.apache.org/jira/browse/JCLOUDS-213) and [JCLOUDS-373](https://issues.apache.org/jira/browse/JCLOUDS-373) or only the generic JCLOUDS-213 ?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/200#issuecomment-28294907
Re: [jclouds] JCLOUDS-375: Fix VirtualGuestToNodeMetadata when server
returns SoftLayer_Exception_Order_Item_Duplicate (#200)
Posted by Andrea Turli <no...@github.com>.
@nacx sorry but I'm not familiar with the entire process :(
This PR is independent from #77 but it is needed as well on master (I thought it was already merged) - sorry
Probably I need to cherry-pick #77 as well but I think we can put it after that.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/200#issuecomment-28294262
Re: [jclouds] JCLOUDS-375: Fix VirtualGuestToNodeMetadata when server
returns SoftLayer_Exception_Order_Item_Duplicate (#200)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-java-7-pull-requests #845](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/845/) FAILURE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/200#issuecomment-28288844
Re: [jclouds] JCLOUDS-375: Fix VirtualGuestToNodeMetadata when server
returns SoftLayer_Exception_Order_Item_Duplicate (#200)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-java-7-pull-requests #847](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/847/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/200#issuecomment-28290948
Re: [jclouds] JCLOUDS-375: Fix VirtualGuestToNodeMetadata when server
returns SoftLayer_Exception_Order_Item_Duplicate (#200)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds #601](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/601/) FAILURE
Looks like there's a problem with this pull request
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/200#issuecomment-28290601
Re: [jclouds] JCLOUDS-375: Fix VirtualGuestToNodeMetadata when server
returns SoftLayer_Exception_Order_Item_Duplicate (#200)
Posted by Ignasi Barrera <no...@github.com>.
Apart from the build failure, the commit message does not match the JIRA issue. Also, shouldn't the PR to add https://github.com/jclouds/jclouds/pull/77 be made before this?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/200#issuecomment-28289405
Re: [jclouds] JCLOUDS-375: Fix VirtualGuestToNodeMetadata when server
returns SoftLayer_Exception_Order_Item_Duplicate (#200)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #384](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/384/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/200#issuecomment-28290937
Re: [jclouds] JCLOUDS-375: Fix VirtualGuestToNodeMetadata when server
returns SoftLayer_Exception_Order_Item_Duplicate (#200)
Posted by Andrea Turli <no...@github.com>.
Sorry @nacx, now it should be better
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/200#issuecomment-28289768
Re: [jclouds] JCLOUDS-375: Fix VirtualGuestToNodeMetadata when server
returns SoftLayer_Exception_Order_Item_Duplicate (#200)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds #602](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/602/) UNSTABLE
Looks like there's a problem with this pull request
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/200#issuecomment-28293481
Re: [jclouds] JCLOUDS-375: Fix VirtualGuestToNodeMetadata when server
returns SoftLayer_Exception_Order_Item_Duplicate (#200)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-java-7-pull-requests #846](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/846/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/200#issuecomment-28290949
Re: [jclouds] JCLOUDS-375: Fix VirtualGuestToNodeMetadata when server
returns SoftLayer_Exception_Order_Item_Duplicate (#200)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #382](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/382/) FAILURE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/200#issuecomment-28288978