[GitHub] [ozone] adoroszlai commented on a change in pull request #2783: HDDS-5912. Add description of hdds.datanode.dir in Getting Started

[GitBox <gi...@apache.org>]

adoroszlai commented on a change in pull request #2783:
URL: https://github.com/apache/ozone/pull/2783#discussion_r744890072



##########
File path: hadoop-hdds/docs/content/start/OnPrem.md
##########
@@ -115,6 +126,7 @@ Here is an  example,
 | ozone.scm.client.address       | SCM server name and port     | Used by client-side                                              |
 | ozone.scm.datanode.address     | SCM server name and port     | Used by datanode to talk to SCM                                  |
 | ozone.om.address               | OM server name               | Used by Ozone handler and Ozone file system.                     |
+| hdds.datanode.dir               | file path                | The HDDS data will be stored here.                     |

Review comment:
       ```suggestion
   | hdds.datanode.dir               | file path                | HDDS datanodes store data in this directory.           |
   ```

##########
File path: hadoop-hdds/docs/content/start/OnPrem.zh.md
##########
@@ -87,6 +87,18 @@ ozone genconf <path>
     </property>
 {{< /highlight >}}
 
+* **hdds.datanode.dir** HDDS数据在datanode本地文件系统中的存储路径，如果路径不存在，ozone会自动创建。
+如果没有指定该选项，ozone会默认使用dfs.datanode.data.dir的值，
+
+示例如下：
+
+{{< highlight xml >}}
+    <property>
+       <name>hdds.datanode.dir</name>
+       <value>/data/disk1/data</value>
+    </property>
+{{< /highlight >}}
+

Review comment:
       ```suggestion
   ```

##########
File path: hadoop-hdds/docs/content/start/OnPrem.md
##########
@@ -104,6 +104,17 @@ Here is an  example,
     </property>
 {{< /highlight >}}
 
+* **hdds.datanode.dir** Determines where on the local filesystem HDDS data will be
+stored. Defaults to dfs.datanode.data.dir if not specified.
+
+Here is an  example,
+{{< highlight xml >}}
+    <property>
+       <name>hdds.datanode.dir</name>
+       <value>/data/disk1/data</value>
+    </property>
+{{< /highlight >}}
+

Review comment:
       This section lists properties which are present in the `ozone-site.xml` config file created by `ozone genconf`.  `hdds.datanode.dir` is not such a property, so I think this section should not list it.
   
   ```suggestion
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org